From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED2BBC4332F for ; Tue, 10 May 2022 15:51:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346768AbiEJPzJ (ORCPT ); Tue, 10 May 2022 11:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347090AbiEJPv5 (ORCPT ); Tue, 10 May 2022 11:51:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59F6A24F0D8; Tue, 10 May 2022 08:46:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3781614A6; Tue, 10 May 2022 15:46:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70068C385A6; Tue, 10 May 2022 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652197613; bh=AvMJv2jCQvxUqPnjz3GXZ5jMdU/1LfpW54CJT3n+Cy4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GkXt8M4bak9KBaeq/Kn+TY31fJM51Vz1+qfEdkTRW23L+FFBqpW/W35LG8npGatNf aDNjhWz3XN+SVUOY4scS8POx7e9imkT1RIVNtpIbIF+faRvqcU927U9UrB+VW8njfJ QKwK2aRgSY4ojDcQtGFFGhAbGEb/rC8fq3DxlKzJRgNZoUFi5GueansVCRnKDUtR+O UgdRU8U7CvD7xQXVYtpY5jjwwCjgTX0d9Bz1AeO6so7Kv0p79axwq97d7z2GzXuvrE 4UWphDjMKqNnKy2Ah0mpk6l5955Rtpt76PjvSrtTw7HSSc4q6FO9qFyn/1eSgbB1OI LOFZLMHmvkWGw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mark Brown , Sasha Levin , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 4.14 3/5] ASoC: max98090: Generate notifications on changes for custom control Date: Tue, 10 May 2022 11:46:35 -0400 Message-Id: <20220510154637.154283-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510154637.154283-1-sashal@kernel.org> References: <20220510154637.154283-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown [ Upstream commit 13fcf676d9e102594effc686d98521ff5c90b925 ] The max98090 driver has some custom controls which share a put() function which returns 0 unconditionally, meaning that events are not generated when the value changes. Fix that. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220420193454.2647908-2-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/max98090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index a25183f6fba6..362d1fb2aae9 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -436,7 +436,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol, mask << mc->shift, sel << mc->shift); - return 0; + return *select != val; } static const char *max98090_perf_pwr_text[] = -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27D4AC433EF for ; Tue, 10 May 2022 15:50:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id ED1C91934; Tue, 10 May 2022 17:49:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz ED1C91934 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652197805; bh=AvMJv2jCQvxUqPnjz3GXZ5jMdU/1LfpW54CJT3n+Cy4=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VpCK122YLQscc+iUS1KtEnXMvg8ar0kX/M1eT0XSt+npjwZNuIbLCeoIwzwS7/dMV 6J3zQB/SOQB8XsmuhFH2gg1edwOMpTIyuyE++Bccf7OTDUc1kL6eWF7H9ZXAejqdz4 pw+Cj2hwjRNlcF3dy2dPvMEFaO9KMJNciPc517Gc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BF9A7F80563; Tue, 10 May 2022 17:46:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 41E07F8055B; Tue, 10 May 2022 17:46:57 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E64B5F80536 for ; Tue, 10 May 2022 17:46:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E64B5F80536 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GkXt8M4b" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 84F4EB81DFB; Tue, 10 May 2022 15:46:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70068C385A6; Tue, 10 May 2022 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652197613; bh=AvMJv2jCQvxUqPnjz3GXZ5jMdU/1LfpW54CJT3n+Cy4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GkXt8M4bak9KBaeq/Kn+TY31fJM51Vz1+qfEdkTRW23L+FFBqpW/W35LG8npGatNf aDNjhWz3XN+SVUOY4scS8POx7e9imkT1RIVNtpIbIF+faRvqcU927U9UrB+VW8njfJ QKwK2aRgSY4ojDcQtGFFGhAbGEb/rC8fq3DxlKzJRgNZoUFi5GueansVCRnKDUtR+O UgdRU8U7CvD7xQXVYtpY5jjwwCjgTX0d9Bz1AeO6so7Kv0p79axwq97d7z2GzXuvrE 4UWphDjMKqNnKy2Ah0mpk6l5955Rtpt76PjvSrtTw7HSSc4q6FO9qFyn/1eSgbB1OI LOFZLMHmvkWGw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 3/5] ASoC: max98090: Generate notifications on changes for custom control Date: Tue, 10 May 2022 11:46:35 -0400 Message-Id: <20220510154637.154283-3-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510154637.154283-1-sashal@kernel.org> References: <20220510154637.154283-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Cc: Sasha Levin , alsa-devel@alsa-project.org, lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Mark Brown [ Upstream commit 13fcf676d9e102594effc686d98521ff5c90b925 ] The max98090 driver has some custom controls which share a put() function which returns 0 unconditionally, meaning that events are not generated when the value changes. Fix that. Signed-off-by: Mark Brown Link: https://lore.kernel.org/r/20220420193454.2647908-2-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/max98090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index a25183f6fba6..362d1fb2aae9 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -436,7 +436,7 @@ static int max98090_put_enab_tlv(struct snd_kcontrol *kcontrol, mask << mc->shift, sel << mc->shift); - return 0; + return *select != val; } static const char *max98090_perf_pwr_text[] = -- 2.35.1