From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5032CC433F5 for ; Wed, 11 May 2022 08:20:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243517AbiEKIUG (ORCPT ); Wed, 11 May 2022 04:20:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243518AbiEKITy (ORCPT ); Wed, 11 May 2022 04:19:54 -0400 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2450720F9DF for ; Wed, 11 May 2022 01:19:51 -0700 (PDT) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24B5qhP6003641; Wed, 11 May 2022 03:19:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=0eyRXSzf2QZB1V1ZCvvAzIQwDPvDlifjrkBSxcnFh7k=; b=X/3dG21/THnsqn3xvVDJV7nBNb2uX3RASEZOxhlxHUmf2g1V1x7zXUdEe3G6H6iUR2EE qSeviXRexB23jr/HDRT5MqR/mBN2HeIfCyn3d17u2DA/1xeoCs1/pHGBqwxTGtP75K4n hlIdfkAzDbWzXWrNwwoVg6fbE7xGmWDkR5X2U4l7zZVhckfAfF/9rrOZ5mQuxeiZ7Lxe DN7gEIsQBzl3LOgraV2EsKJ0q/KG37qby4cnYBMAy99MI2VrE/2XDftX0QeYq7IcZahs KELzsUi1WjJWU+9NoxBoZWBVXHtM9H0W1x3GPS1zY0qlS1v4ghbD7VNVn3dznWbACmn+ gg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3fwp616bnb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 11 May 2022 03:19:25 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 09:19:23 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 11 May 2022 09:19:23 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 42408B10; Wed, 11 May 2022 08:19:23 +0000 (UTC) Date: Wed, 11 May 2022 08:19:23 +0000 From: Charles Keepax To: Zheyu Ma CC: , , , , , , , , , , Subject: Re: [PATCH v2] ASoC: cs42l56: Fix the error handling of cs42l56_i2c_probe() Message-ID: <20220511081923.GF38351@ediswmail.ad.cirrus.com> References: <20220510155410.GC38351@ediswmail.ad.cirrus.com> <20220511015514.1777923-1-zheyuma97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220511015514.1777923-1-zheyuma97@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: DR3sAZuLLq0ll-Wlxagsrk4CxHQgi-si X-Proofpoint-ORIG-GUID: DR3sAZuLLq0ll-Wlxagsrk4CxHQgi-si X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2022 at 09:55:14AM +0800, Zheyu Ma wrote: > The driver should goto label 'err_enable' when failing at regmap_read(). > > Signed-off-by: Zheyu Ma > --- > Changes in v2: > - Fix the typo in the subject > --- Acked-by: Charles Keepax Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86537C433EF for ; Wed, 11 May 2022 08:20:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B7D751947; Wed, 11 May 2022 10:19:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B7D751947 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652257227; bh=OyAhROpWV5Td+mReH04hqwdw7uSDGnxHxUth1s5Aqss=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=q1fykrOxkD4GO6NMVnCKKcDZIBERroWWZGSvkEk6zfETwGIt3vdqNrSAkLJ1/hevS fsV4V4MZDimnakAWjmXGYQSLCfFqf9/K03iDHbWrpviBC9cj/6GRrZbL8j+jR9mm/g bEf5aVXRip0Pc3vsG85bqkpb50elXe7WOzHj3iI8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4C953F80137; Wed, 11 May 2022 10:19:37 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DC1CEF8015B; Wed, 11 May 2022 10:19:34 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 82306F800BB for ; Wed, 11 May 2022 10:19:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 82306F800BB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="X/3dG21/" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24B5qhP6003641; Wed, 11 May 2022 03:19:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=0eyRXSzf2QZB1V1ZCvvAzIQwDPvDlifjrkBSxcnFh7k=; b=X/3dG21/THnsqn3xvVDJV7nBNb2uX3RASEZOxhlxHUmf2g1V1x7zXUdEe3G6H6iUR2EE qSeviXRexB23jr/HDRT5MqR/mBN2HeIfCyn3d17u2DA/1xeoCs1/pHGBqwxTGtP75K4n hlIdfkAzDbWzXWrNwwoVg6fbE7xGmWDkR5X2U4l7zZVhckfAfF/9rrOZ5mQuxeiZ7Lxe DN7gEIsQBzl3LOgraV2EsKJ0q/KG37qby4cnYBMAy99MI2VrE/2XDftX0QeYq7IcZahs KELzsUi1WjJWU+9NoxBoZWBVXHtM9H0W1x3GPS1zY0qlS1v4ghbD7VNVn3dznWbACmn+ gg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3fwp616bnb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 11 May 2022 03:19:25 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 09:19:23 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 11 May 2022 09:19:23 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 42408B10; Wed, 11 May 2022 08:19:23 +0000 (UTC) Date: Wed, 11 May 2022 08:19:23 +0000 From: Charles Keepax To: Zheyu Ma Subject: Re: [PATCH v2] ASoC: cs42l56: Fix the error handling of cs42l56_i2c_probe() Message-ID: <20220511081923.GF38351@ediswmail.ad.cirrus.com> References: <20220510155410.GC38351@ediswmail.ad.cirrus.com> <20220511015514.1777923-1-zheyuma97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220511015514.1777923-1-zheyuma97@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: DR3sAZuLLq0ll-Wlxagsrk4CxHQgi-si X-Proofpoint-ORIG-GUID: DR3sAZuLLq0ll-Wlxagsrk4CxHQgi-si X-Proofpoint-Spam-Reason: safe Cc: alsa-devel@alsa-project.org, tanureal@opensource.cirrus.com, patches@opensource.cirrus.com, tiwai@suse.com, lgirdwood@gmail.com, david.rhodes@cirrus.com, rf@opensource.cirrus.com, broonie@kernel.org, james.schulman@cirrus.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, May 11, 2022 at 09:55:14AM +0800, Zheyu Ma wrote: > The driver should goto label 'err_enable' when failing at regmap_read(). > > Signed-off-by: Zheyu Ma > --- > Changes in v2: > - Fix the typo in the subject > --- Acked-by: Charles Keepax Thanks, Charles