From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC783C433F5 for ; Wed, 11 May 2022 08:58:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5A2C383BF4; Wed, 11 May 2022 10:58:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id C110583B74; Wed, 11 May 2022 10:57:59 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 2501E842CB for ; Wed, 11 May 2022 10:57:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67109106F; Wed, 11 May 2022 01:57:56 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DEA573F73D; Wed, 11 May 2022 01:57:54 -0700 (PDT) Date: Wed, 11 May 2022 09:57:51 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Eddie James , Heiko Schocher , Michal Simek , Oleksandr Suvorov , Philippe Reynes , Sebastian Reichel , Simon Glass , T Karthik Reddy Subject: Re: [PATCH] gpio: sunxi: Fix build with CONFIG_SPL_SERIAL=n Message-ID: <20220511095751.26e80c70@donnerap.cambridge.arm.com> In-Reply-To: <20220511000334.37989-1-samuel@sholland.org> References: <20220511000334.37989-1-samuel@sholland.org> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Tue, 10 May 2022 19:03:34 -0500 Samuel Holland wrote: Hi, > This driver uses simple_strtol(), so it needs SPL_STRTO. Before commit > 88ca8e26958b6 ("disk: Add an option for partitions in SPL"), SPL_STRTO > was always selected indirectly. Now it is not, so select it here. >=20 > Signed-off-by: Samuel Holland =46rom what I can see, CONFIG_MMC is the trigger, calling sunxi_name_to_gpio(), which is the actual user of simple_strtol() in the SPL. For the three boards not using MMC I don't see simple_strol() being mentioned in the objdump. But I think this patch is a more robust solution (compared to tying it to MMC usage), so: Reviewed-by: Andre Przywara Cheers, Andre > --- >=20 > drivers/gpio/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 89068c7800..b955543e97 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -347,6 +347,7 @@ config SANDBOX_GPIO_COUNT > config SUNXI_GPIO > bool "Allwinner GPIO driver" > depends on ARCH_SUNXI > + select SPL_STRTO if SPL > help > Support the GPIO device in Allwinner SoCs. > =20