Re: [PATCH v4 1/3] dt-bindings: net: adin: document phy clock

From: Michael Walle <michael@walle.cc>
To: kuba@kernel.org
Cc: alexandru.ardelean@analog.com, alvaro.karsz@solid-run.com,
	davem@davemloft.net, edumazet@google.com, josua@solid-run.com,
	krzysztof.kozlowski+dt@linaro.org, michael.hennerich@analog.com,
	netdev@vger.kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
	Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v4 1/3] dt-bindings: net: adin: document phy clock
Date: Wed, 11 May 2022 14:58:55 +0200	[thread overview]
Message-ID: <20220511125855.3708961-1-michael@walle.cc> (raw)
In-Reply-To: <20220510133928.6a0710dd@kernel.org>

> On Mon,  9 May 2022 17:36:33 +0300 Josua Mayer wrote:
> > +  adi,phy-output-clock:
> > +    description: Select clock output on GP_CLK pin. Three clocks are available:
> > +      A 25MHz reference, a free-running 125MHz and a recovered 125MHz.
> > +      The phy can also automatically switch between the reference and the
> > +      respective 125MHz clocks based on its internal state.
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    enum:
> > +      - 25mhz-reference
> > +      - 125mhz-free-running
> > +      - 125mhz-recovered
> > +      - adaptive-free-running
> > +      - adaptive-recovered
> 
> I'm still not convinced that exposing the free running vs recovered
> distinction from the start is a good idea. Intuitively it'd seem that
> it's better to use the recovered clock to feed the wire side of the MAC,
> this patch set uses the free running. So I'd personally strip the last 
> part off and add it later if needed.

FWIW, the recovered clock only works if there is a link. AFAIR on the
AR8031 you can have the free-running one enabled even if there is no
link, which might sometimes be useful.

-michael