From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E44CC433F5 for ; Wed, 11 May 2022 22:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348836AbiEKWcl (ORCPT ); Wed, 11 May 2022 18:32:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348781AbiEKWcc (ORCPT ); Wed, 11 May 2022 18:32:32 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC8B562A18 for ; Wed, 11 May 2022 15:32:30 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id x23so3160219pff.9 for ; Wed, 11 May 2022 15:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lu8Yk3g+KqauzNzBiFKSP6KQpOiG+G3Df6KTkrdelIs=; b=niGOrTTEvvwDakGPfaEm+H/jXShM05yULb78ZRtInqcr0ntY7ypT568jGc5K9zi/NK RvZCIZgIO5a6JOvTXSsEU9k1t13N7gMcSLzP7XtdlnXEccTeQnQtMdAFVAY2OvP9VNc5 cf+eEx6HGQtK59kyC+ae06R1Pb5Bl+TkVXjvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lu8Yk3g+KqauzNzBiFKSP6KQpOiG+G3Df6KTkrdelIs=; b=e/BNagSHcOTA3NxtwzImTQFgp4zcS17p35lehe2AJFut4+2IjcTKhvXEpv3pWPxY8B pv1iRLkCjA1mIJIzVrJ0HAMKb0MrySWmMxUevQBsfaa9+QBEN+y9JvcphNkieFICBR49 pO767sYv0NkFRd013jj95P6fu0kAKDBSZOVQEZT/z/VLmTk4LRSqXYEmmcZ/McY3YBZS mdmdbuo231GNzY4GHXoNNxwtO1emJa+YOTwxFUSwltAo3KYsbdwvIeBdM54AHhxpbonQ 9uRqiLYNboeHOdV/cfp9fteDw3RoJCuSrYaw+NAIYh2WYDaxdWf+zLaNGtzyqAeW3pvD /ByA== X-Gm-Message-State: AOAM530nOnP1vmikPeYcj2zwfNsteYKYCDOSSTFSsB3rkOZTjLa0Q0rE FZpwi4OR34CThaUg6ZnD203QOtmBU8v80A== X-Google-Smtp-Source: ABdhPJywPERqtDjyK6IMSaCkF3byY8oVHiUYV1+JAYdH4mGwmEW2PT4iA5vzx2yw+YiBsg79ZtNpcA== X-Received: by 2002:a63:1a5c:0:b0:3c1:9a7c:3739 with SMTP id a28-20020a631a5c000000b003c19a7c3739mr22723271pgm.272.1652308350421; Wed, 11 May 2022 15:32:30 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t19-20020a62d153000000b005087c23ad8dsm2240431pfl.0.2022.05.11.15.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 15:32:29 -0700 (PDT) Date: Wed, 11 May 2022 15:32:29 -0700 From: Kees Cook To: Maninder Singh Cc: mcgrof@kernel.org, avimalin@gmail.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, pmladek@suse.com, rostedt@goodmis.org, senozhatsky@chromium.org, andriy.shevchenko@linux.intel.com, naveen.n.rao@linux.ibm.com, davem@davemloft.net, mhiramat@kernel.org, anil.s.keshavamurthy@intel.com, linux@rasmusvillemoes.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, v.narang@samsung.com, Onkarnath Subject: Re: [PATCH 1/2] kallsyms: add kallsyms_show_value definition in all cases Message-ID: <202205111525.92B1C597@keescook> References: <20220511080657.3996053-1-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220511080657.3996053-1-maninder1.s@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2022 at 01:36:56PM +0530, Maninder Singh wrote: > kallsyms_show_value return false if KALLSYMS is disabled, > but its usage is done by module.c also. > Thus when KALLSYMS is disabled, system will not print module > load address: Eek, I hadn't see the other changes this depends on. I think those changes need to be reworked first. Notably in the other patch, this is no good: /* address belongs to module */ if (add_offset) len = sprintf(buf, "0x%p+0x%lx", base, offset); else len = sprintf(buf, "0x%lx", value); This is printing raw kernel addresses with no hashing, as far as I can tell. That's not okay at all. Once that other patch gets fixed, this one then can be revisited. And just on naming: "kallsyms_tiny" is a weird name: it's just "ksyms" -- there's no "all". :) -- Kees Cook