From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AB3C433F5 for ; Thu, 12 May 2022 06:55:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350585AbiELGz2 (ORCPT ); Thu, 12 May 2022 02:55:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350505AbiELGz0 (ORCPT ); Thu, 12 May 2022 02:55:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E2A5B227B57 for ; Wed, 11 May 2022 23:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652338522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KIW16efPZTPXF7vXmoAKJ6+LI7vVPqzYCyoW+qf9gM4=; b=ZjNEr+S9uMezBanGXquw8oH2+rmygi6bWJ5XnCe7RZCgW+3fPe9E8meLbTDU4UIM8DP0uQ t1hZEAjd0YgrUsnsGTSoN46XXSKUwrvV9JutkIAuMpmD8hA2QnFidXNBdOPcSaRckZNAj0 JUdGWKwsUyTWDFkevejhohgGRXqFtdU= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-556-5jgu1FWjNFe9qQezUFbVSg-1; Thu, 12 May 2022 02:55:21 -0400 X-MC-Unique: 5jgu1FWjNFe9qQezUFbVSg-1 Received: by mail-pl1-f197.google.com with SMTP id i16-20020a170902cf1000b001540b6a09e3so2325524plg.0 for ; Wed, 11 May 2022 23:55:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KIW16efPZTPXF7vXmoAKJ6+LI7vVPqzYCyoW+qf9gM4=; b=xEBdEQJoWVpwB2ehST6D9ce8paDYnyIrGW/qgbuyNL2qgj3pnbvysk8WzRzFYgaEcD t1kEx+Iaxtt04amB9JimxNJHHFKqrWFPlnynOoDgfTsbaxoqJ6hFpS3ng9QimYyovfM5 lILHDa99wOvB+yYl/m1bxIt+7aAiXLMzAJwns/rti7g7jI3DjJRPQJfTtq0CIQwReWci 9eriVhGtLQRPYQ0ac0wY0ftgVVg0SyBnMHw4bjU5SejruXABHW32UgHUAWWg5whX6SQu tS99dX/RgtQkpA0x8LWFi25tAZrfWJN5+e2h1eQnNtClIqXTdz3SKnOZA6aio7AUZdpE TUcA== X-Gm-Message-State: AOAM532Dg2LK1iORxN75uET0hxuu1RNarPtIvcwpzT3t/POX4c2GfqY5 voWy2f+w7B6AzCAHIwLhh8diqvP5fyfDtTdGD42peypzd54bBiGVy+zG/rc/sBgu50CipIrqy4U h6K7Iyjt9J02pPURLGgE= X-Received: by 2002:a63:80c6:0:b0:3c2:88f0:9035 with SMTP id j189-20020a6380c6000000b003c288f09035mr24278688pgd.606.1652338520732; Wed, 11 May 2022 23:55:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkdTJ7sQGjP+3Rj3u8vSGTO9HWGPdcwyACt6Ww8UmyQOmDfjVrRB+T+y5XgfYVWwoXO1Gqrg== X-Received: by 2002:a63:80c6:0:b0:3c2:88f0:9035 with SMTP id j189-20020a6380c6000000b003c288f09035mr24278669pgd.606.1652338520467; Wed, 11 May 2022 23:55:20 -0700 (PDT) Received: from localhost ([240e:3a1:2e9:efa0:e73c:e550:ac9e:58fd]) by smtp.gmail.com with ESMTPSA id l12-20020a170902d34c00b0015e8d4eb296sm3022491plk.224.2022.05.11.23.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 23:55:20 -0700 (PDT) Date: Thu, 12 May 2022 14:54:09 +0800 From: Coiby Xu To: Baoquan He Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Michal Suchanek , Dave Young , Will Deacon , "Eric W . Biederman" , Mimi Zohar , Chun-Yi Lee , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, stable@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v7 2/4] kexec, KEYS: make the code in bzImage64_verify_sig generic Message-ID: <20220512065409.xxegsttgwfh63fsv@Rk> References: <20220512023402.9913-1-coxu@redhat.com> <20220512023402.9913-3-coxu@redhat.com> <20220512043310.v3e22423ybe4z65e@Rk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On Thu, May 12, 2022 at 02:22:57PM +0800, Baoquan He wrote: >On 05/12/22 at 12:33pm, Coiby Xu wrote: [...] >> > Just to make clear , is this patch fixing an issue, or it's just an >> > preparation for later patch's use? >> > >> > Or I should ask in another way, any problem is solved with this patch? >> >> At least it doesn't fix an issue that satisfy the criteria listed in >> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > >Then it should not be CC-ed to stable. OK, I'll drop "CC:" in next version. > >> >> > >> > >> > > > Reviewed-by: Michal Suchanek >> > > > Signed-off-by: Coiby Xu >> > > > --- >> > > >> > > You can put the note here, it won't be added to commit log when merged. >> > > Maybe it can be removed when merged. >> >> Thanks for the suggestion! Shall I send a version to fix this problem or >> can I just bother the maintainer to remove it? > >Better send a clean one, it will save maintainer's time, they can pick >it directly. Thanks for the confirmation! I'll simply delete them because, 1. these notes don't make sense anymore if I don't CC the patches to the stable tree 2. I've explained in the cover letter the first two patches are the prerequisite patches for the 3rd patch. -- Best regards, Coiby From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D19BFC433EF for ; Thu, 12 May 2022 06:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z5FdRDMgf6C5z+Y8ITxAPdRIEiFDSyh+Vp+yl2RaHfw=; b=AR6rC9fsN2CW+u3/wwUff/uOj1 Y9oSCGCIQpUPpWaJr079VsSLFsm1FMsME5uO+5lIjnMPg1QZDN52ouTGUddO1mUzqIkWKWaBq0B6V UqQDRqEGNgjltbpvGuEkWail0/sXReGYoeWZ2/o9GaIwvtliY1ZOgJbm37Qa14OzTir06z8Kn7/SY dIY0O5eVQq/QCrUZWdiak59ixRjSR6UQjxxGJHT4+nUUgUyhq6BZ7UGM7yG5IucJqTc0gOWM3rMDj 4NTToYpsdqFXTcg6eXjonVM/rRUlzH2000SnOueM8tncoA8E8LG95wiOj0RIrYsj9S8wTel7x+ayK +FuneETA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1np2jT-00Ab1q-5n; Thu, 12 May 2022 06:55:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1np2jP-00Ab0f-BP for linux-arm-kernel@lists.infradead.org; Thu, 12 May 2022 06:55:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652338524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KIW16efPZTPXF7vXmoAKJ6+LI7vVPqzYCyoW+qf9gM4=; b=LMtI8BI+qESvjstEIkT0xeBTq9zN48S4rkZvyciR0Rh1kYsEZ6f7ldVer30d5167Qa9+Qy 5U6+RTwCjsBPQszxvec5xay8D4jiMRJW8F9jMjrwdJLpBzK/F9kUZe3HE0jO1Egf7WeZLa Pi+d0at6YhUF2SDHfVeh+2eahBSHYKc= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-575-kq2_gjPvOpiYRwhho-F0cg-1; Thu, 12 May 2022 02:55:21 -0400 X-MC-Unique: kq2_gjPvOpiYRwhho-F0cg-1 Received: by mail-pl1-f198.google.com with SMTP id t14-20020a1709028c8e00b0015cf7e541feso2309018plo.1 for ; Wed, 11 May 2022 23:55:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KIW16efPZTPXF7vXmoAKJ6+LI7vVPqzYCyoW+qf9gM4=; b=w1rqZ3ERPDP77UUCdjaZe1sp1zOVOXy34R2DuA4ULl6big3CSg8lGAYa3jMMeMeVqa feAANgarhV9sroOcvV/OaUrUTKzb/HnI8bqpfUlCm3OK95l14oPHKoMKUybPSqafdCEw wtOj4DXA07Pz98z+xj1ntFTAq3TrRRjDh6CYxRAykV3SmfGENvGGTVYJw2vHfYC7jvlc lKmPzLrZjKD/IYWzYOxNlF9WL2Z3SlRkiBEcHpkdcUr38z2LdtU/x8I/2O5miWyMrKgS uk8UmmE5ZkX8hYLtXAs5bEUPbbl5sxndRKz3moEcGHI3WLQfEPFnVSL0/FfsAKgP4dOr 0e5A== X-Gm-Message-State: AOAM531mlXLoRWX/R7SoNG1D0LCxmIPg5TdzcZsrbT5+Gs8oSHieCdPI sAuE4VB2MmqxuBROIghHJRPxMxHBIhC31nNr35Hqh6UMcfWVA3izynLr7gZxg0DT5KjZerCyHHf Y7xDszLNBFPEFuV6MkzlKKuxoea6m8JpFJ8Y= X-Received: by 2002:a63:80c6:0:b0:3c2:88f0:9035 with SMTP id j189-20020a6380c6000000b003c288f09035mr24278691pgd.606.1652338520733; Wed, 11 May 2022 23:55:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkdTJ7sQGjP+3Rj3u8vSGTO9HWGPdcwyACt6Ww8UmyQOmDfjVrRB+T+y5XgfYVWwoXO1Gqrg== X-Received: by 2002:a63:80c6:0:b0:3c2:88f0:9035 with SMTP id j189-20020a6380c6000000b003c288f09035mr24278669pgd.606.1652338520467; Wed, 11 May 2022 23:55:20 -0700 (PDT) Received: from localhost ([240e:3a1:2e9:efa0:e73c:e550:ac9e:58fd]) by smtp.gmail.com with ESMTPSA id l12-20020a170902d34c00b0015e8d4eb296sm3022491plk.224.2022.05.11.23.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 23:55:20 -0700 (PDT) Date: Thu, 12 May 2022 14:54:09 +0800 From: Coiby Xu To: Baoquan He Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Michal Suchanek , Dave Young , Will Deacon , "Eric W . Biederman" , Mimi Zohar , Chun-Yi Lee , keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, stable@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v7 2/4] kexec, KEYS: make the code in bzImage64_verify_sig generic Message-ID: <20220512065409.xxegsttgwfh63fsv@Rk> References: <20220512023402.9913-1-coxu@redhat.com> <20220512023402.9913-3-coxu@redhat.com> <20220512043310.v3e22423ybe4z65e@Rk> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=coxu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220511_235527_529021_2A39AB50 X-CRM114-Status: GOOD ( 23.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 12, 2022 at 02:22:57PM +0800, Baoquan He wrote: >On 05/12/22 at 12:33pm, Coiby Xu wrote: [...] >> > Just to make clear , is this patch fixing an issue, or it's just an >> > preparation for later patch's use? >> > >> > Or I should ask in another way, any problem is solved with this patch? >> >> At least it doesn't fix an issue that satisfy the criteria listed in >> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > >Then it should not be CC-ed to stable. OK, I'll drop "CC:" in next version. > >> >> > >> > >> > > > Reviewed-by: Michal Suchanek >> > > > Signed-off-by: Coiby Xu >> > > > --- >> > > >> > > You can put the note here, it won't be added to commit log when merged. >> > > Maybe it can be removed when merged. >> >> Thanks for the suggestion! Shall I send a version to fix this problem or >> can I just bother the maintainer to remove it? > >Better send a clean one, it will save maintainer's time, they can pick >it directly. Thanks for the confirmation! I'll simply delete them because, 1. these notes don't make sense anymore if I don't CC the patches to the stable tree 2. I've explained in the cover letter the first two patches are the prerequisite patches for the 3rd patch. -- Best regards, Coiby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Coiby Xu Date: Thu, 12 May 2022 14:54:09 +0800 Subject: [PATCH v7 2/4] kexec, KEYS: make the code in bzImage64_verify_sig generic In-Reply-To: References: <20220512023402.9913-1-coxu@redhat.com> <20220512023402.9913-3-coxu@redhat.com> <20220512043310.v3e22423ybe4z65e@Rk> Message-ID: <20220512065409.xxegsttgwfh63fsv@Rk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kexec@lists.infradead.org On Thu, May 12, 2022 at 02:22:57PM +0800, Baoquan He wrote: >On 05/12/22 at 12:33pm, Coiby Xu wrote: [...] >> > Just to make clear , is this patch fixing an issue, or it's just an >> > preparation for later patch's use? >> > >> > Or I should ask in another way, any problem is solved with this patch? >> >> At least it doesn't fix an issue that satisfy the criteria listed in >> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > >Then it should not be CC-ed to stable. OK, I'll drop "CC:" in next version. > >> >> > >> > >> > > > Reviewed-by: Michal Suchanek >> > > > Signed-off-by: Coiby Xu >> > > > --- >> > > >> > > You can put the note here, it won't be added to commit log when merged. >> > > Maybe it can be removed when merged. >> >> Thanks for the suggestion! Shall I send a version to fix this problem or >> can I just bother the maintainer to remove it? > >Better send a clean one, it will save maintainer's time, they can pick >it directly. Thanks for the confirmation! I'll simply delete them because, 1. these notes don't make sense anymore if I don't CC the patches to the stable tree 2. I've explained in the cover letter the first two patches are the prerequisite patches for the 3rd patch. -- Best regards, Coiby