From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43069C433F5 for ; Thu, 12 May 2022 08:08:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 36F5A10E0AC; Thu, 12 May 2022 08:08:40 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C27010E215; Thu, 12 May 2022 08:08:38 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A01F05C018B; Thu, 12 May 2022 04:08:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 12 May 2022 04:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1652342917; x=1652429317; bh=e3zvtlZZgp P3opYYwBrzo7Xj3xYhujuBf/aC3yTsqys=; b=P1EzjwR/vkjKjkQ2qG2EVZq1ps iYP4H3kDUIBkOzetX56Gj2zriFor9Y/xn4WcxrNwnoozQRQr2jYAXDEECXtHmzgr i3nYQoeZf7B8i603P5nBhEGet9KMZOxg3KirHIoiyf2galSEeJmUtC9KFSPez6l5 sd4kX/LAhY6dz/t0DK/kInBMjyx48fsASE8/0+J/g8CIimEZIoA1FkICuSag8exY 9KsFrPhCR9eonBM+VefYfmhgGA2grwkiqwPSpJ6TpAroF4cJOlCxctRNBm10D98F hGZh6wDW8Xj7F+XC9jqOD+0Zg27BFNj3KVB5wBlYtFUKaK2y76fHYpTa6Hxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652342917; x= 1652429317; bh=e3zvtlZZgpP3opYYwBrzo7Xj3xYhujuBf/aC3yTsqys=; b=j RiXl7v9yzuLZEJqYL5Yt/hzaUhpT8nN3dhYgeib1GuTcBKf6unDXATd1Ccog8+w+ y2B3/ey+n9KzM7csukde3KvhrhVMI2cLS0zG8zP1pmgHAaWN36pM2/X9PToZpgEk S+CO47tStv6cQHQQ6Z6emMdOPtaTcwrY5xaZlyVYRa0LB/2J/P3kWhkVFMFCaI/Q buJTsErKIMtWkQ0JsmKc4hQy/8seuyc1w3TaOqRLF18G+PoAyGv+WLkdWUYQaUX0 drfnndqFmTvl8DrjqEVZ1wXNEMpgr5GY/201wwDXuBH1dBb7DjI0linYc20j9ZQE AIW91sxKIiAnkjO4uK2HQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeeigdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefhkeehfedthfejfeejtdfhvddvueeigeejjeeuteegveffhfffgeffieeu ueduvdenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggt hh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 May 2022 04:08:36 -0400 (EDT) Date: Thu, 12 May 2022 10:08:35 +0200 From: Maxime Ripard To: Daniel Vetter Subject: Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks Message-ID: <20220512080835.oy6cvqycgsfsjcly@houat> References: <20220331152021.2671937-1-daniel.vetter@ffwll.ch> <823b3f2c-b624-f7a3-8bdc-4c069571c810@quicinc.com> <0e957a37-87ad-4981-01c5-287c4b06afa3@quicinc.com> <03186a69-0ade-7f8d-4b8b-46f525bc0cb4@quicinc.com> <20220428080847.nbolnkxemblz5qer@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pyaxx6vcdg2jdru4" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Kalyan Thota , Daniel Vetter , Michel =?utf-8?Q?D=C3=A4nzer?= , Abhinav Kumar , DRI Development , "Kazlauskas, Nicholas" , Dmitry Osipenko , Daniel Vetter , Jessica Zhang , Mikita Lipski , Intel Graphics Development Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --pyaxx6vcdg2jdru4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Daniel, An update on this On Thu, Apr 28, 2022 at 02:09:40PM +0200, Daniel Vetter wrote: > > We integrated this in the (downstream) RaspberryPi kernel, and it seems > > to trigger some weird regressions: > >=20 > > - If we move the cursor under X, the primary plane update is stuck: > > https://github.com/raspberrypi/linux/issues/4988 So it turns out the upstream driver doesn't seem affected by this, but only a downstream alternative. > > - Switching back and forth between VT gets the kernel stuck (with a > > locking issue in fb_release?) > > https://github.com/raspberrypi/linux/issues/5011 And this one turned out to be a separate issue fixed by Javier already. So as far as I'm concerned, this patch seems to be working fine on vc4 Maxime --pyaxx6vcdg2jdru4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYnzAgwAKCRDj7w1vZxhR xRmUAP9gyrp/Aj/5NDiw5nVrmVFu4wFB72A3XdKVeMaXaZ2msQD9H3kP2u/U8cP6 igZxLkbJY3X7qhMosmVoTGdZyFwEzQo= =mOcg -----END PGP SIGNATURE----- --pyaxx6vcdg2jdru4-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2E6AC433EF for ; Thu, 12 May 2022 08:08:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 320C510E215; Thu, 12 May 2022 08:08:39 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C27010E215; Thu, 12 May 2022 08:08:38 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A01F05C018B; Thu, 12 May 2022 04:08:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 12 May 2022 04:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1652342917; x=1652429317; bh=e3zvtlZZgp P3opYYwBrzo7Xj3xYhujuBf/aC3yTsqys=; b=P1EzjwR/vkjKjkQ2qG2EVZq1ps iYP4H3kDUIBkOzetX56Gj2zriFor9Y/xn4WcxrNwnoozQRQr2jYAXDEECXtHmzgr i3nYQoeZf7B8i603P5nBhEGet9KMZOxg3KirHIoiyf2galSEeJmUtC9KFSPez6l5 sd4kX/LAhY6dz/t0DK/kInBMjyx48fsASE8/0+J/g8CIimEZIoA1FkICuSag8exY 9KsFrPhCR9eonBM+VefYfmhgGA2grwkiqwPSpJ6TpAroF4cJOlCxctRNBm10D98F hGZh6wDW8Xj7F+XC9jqOD+0Zg27BFNj3KVB5wBlYtFUKaK2y76fHYpTa6Hxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1652342917; x= 1652429317; bh=e3zvtlZZgpP3opYYwBrzo7Xj3xYhujuBf/aC3yTsqys=; b=j RiXl7v9yzuLZEJqYL5Yt/hzaUhpT8nN3dhYgeib1GuTcBKf6unDXATd1Ccog8+w+ y2B3/ey+n9KzM7csukde3KvhrhVMI2cLS0zG8zP1pmgHAaWN36pM2/X9PToZpgEk S+CO47tStv6cQHQQ6Z6emMdOPtaTcwrY5xaZlyVYRa0LB/2J/P3kWhkVFMFCaI/Q buJTsErKIMtWkQ0JsmKc4hQy/8seuyc1w3TaOqRLF18G+PoAyGv+WLkdWUYQaUX0 drfnndqFmTvl8DrjqEVZ1wXNEMpgr5GY/201wwDXuBH1dBb7DjI0linYc20j9ZQE AIW91sxKIiAnkjO4uK2HQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeeigdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefhkeehfedthfejfeejtdfhvddvueeigeejjeeuteegveffhfffgeffieeu ueduvdenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggt hh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 May 2022 04:08:36 -0400 (EDT) Date: Thu, 12 May 2022 10:08:35 +0200 From: Maxime Ripard To: Daniel Vetter Message-ID: <20220512080835.oy6cvqycgsfsjcly@houat> References: <20220331152021.2671937-1-daniel.vetter@ffwll.ch> <823b3f2c-b624-f7a3-8bdc-4c069571c810@quicinc.com> <0e957a37-87ad-4981-01c5-287c4b06afa3@quicinc.com> <03186a69-0ade-7f8d-4b8b-46f525bc0cb4@quicinc.com> <20220428080847.nbolnkxemblz5qer@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pyaxx6vcdg2jdru4" Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Kalyan Thota , Daniel Vetter , Michel =?utf-8?Q?D=C3=A4nzer?= , Abhinav Kumar , DRI Development , "Kazlauskas, Nicholas" , Dmitry Osipenko , Daniel Vetter , Jessica Zhang , Mikita Lipski , Intel Graphics Development Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --pyaxx6vcdg2jdru4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Daniel, An update on this On Thu, Apr 28, 2022 at 02:09:40PM +0200, Daniel Vetter wrote: > > We integrated this in the (downstream) RaspberryPi kernel, and it seems > > to trigger some weird regressions: > >=20 > > - If we move the cursor under X, the primary plane update is stuck: > > https://github.com/raspberrypi/linux/issues/4988 So it turns out the upstream driver doesn't seem affected by this, but only a downstream alternative. > > - Switching back and forth between VT gets the kernel stuck (with a > > locking issue in fb_release?) > > https://github.com/raspberrypi/linux/issues/5011 And this one turned out to be a separate issue fixed by Javier already. So as far as I'm concerned, this patch seems to be working fine on vc4 Maxime --pyaxx6vcdg2jdru4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYnzAgwAKCRDj7w1vZxhR xRmUAP9gyrp/Aj/5NDiw5nVrmVFu4wFB72A3XdKVeMaXaZ2msQD9H3kP2u/U8cP6 igZxLkbJY3X7qhMosmVoTGdZyFwEzQo= =mOcg -----END PGP SIGNATURE----- --pyaxx6vcdg2jdru4--