Re: [PATCH 2/5 v1] mm: add numa_count field for rss_stat

[kernel test robot <lkp@intel.com>]

Hi Gang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on s390/features]
[also build test ERROR on kees/for-next/execve tip/perf/core linus/master v5.18-rc6]
[cannot apply to akpm-mm/mm-everything rostedt-trace/for-next next-20220512]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Gang-Li/mm-oom-Introduce-per-numa-node-oom-for-CONSTRAINT_MEMORY_POLICY/20220512-124948
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: x86_64-randconfig-a003-20220509 (https://download.01.org/0day-ci/archive/20220513/202205130046.1baess3J-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 18dd123c56754edf62c7042dcf23185c3727610f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/3e724f844e3fe45cdffd9f359d140a424aeb462c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gang-Li/mm-oom-Introduce-per-numa-node-oom-for-CONSTRAINT_MEMORY_POLICY/20220512-124948
        git checkout 3e724f844e3fe45cdffd9f359d140a424aeb462c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> kernel/fork.c:878:6: warning: no previous prototype for function 'rss_stat_free' [-Wmissing-prototypes]
   void rss_stat_free(struct task_struct *p) {}
        ^
   kernel/fork.c:878:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void rss_stat_free(struct task_struct *p) {}
   ^
   static 
>> kernel/fork.c:1110:1: warning: unused label 'free_stack' [-Wunused-label]
   free_stack:
   ^~~~~~~~~~~
>> kernel/fork.c:2207:36: error: no member named 'rss_stat' in 'struct task_struct'
           memset(&p->rss_stat, 0, sizeof(p->rss_stat));
                                          ~  ^
   include/linux/fortify-string.h:272:52: note: expanded from macro 'memset'
   #define memset(p, c, s) __fortify_memset_chk(p, c, s,                   \
                                                      ^
   include/linux/fortify-string.h:263:35: note: expanded from macro '__fortify_memset_chk'
           size_t __fortify_size = (size_t)(size);                         \
                                            ^~~~
   kernel/fork.c:2207:13: error: no member named 'rss_stat' in 'struct task_struct'
           memset(&p->rss_stat, 0, sizeof(p->rss_stat));
                   ~  ^
   include/linux/fortify-string.h:273:25: note: expanded from macro 'memset'
                   __builtin_object_size(p, 0), __builtin_object_size(p, 1))
                                         ^
   include/linux/fortify-string.h:264:37: note: expanded from macro '__fortify_memset_chk'
           fortify_memset_chk(__fortify_size, p_size, p_size_field),       \
                                              ^~~~~~
   kernel/fork.c:2207:13: error: no member named 'rss_stat' in 'struct task_struct'
           memset(&p->rss_stat, 0, sizeof(p->rss_stat));
                   ~  ^
   include/linux/fortify-string.h:273:54: note: expanded from macro 'memset'
                   __builtin_object_size(p, 0), __builtin_object_size(p, 1))
                                                                      ^
   include/linux/fortify-string.h:264:45: note: expanded from macro '__fortify_memset_chk'
           fortify_memset_chk(__fortify_size, p_size, p_size_field),       \
                                                      ^~~~~~~~~~~~
   kernel/fork.c:2207:13: error: no member named 'rss_stat' in 'struct task_struct'
           memset(&p->rss_stat, 0, sizeof(p->rss_stat));
                   ~  ^
   include/linux/fortify-string.h:272:46: note: expanded from macro 'memset'
   #define memset(p, c, s) __fortify_memset_chk(p, c, s,                   \
                                                ^
   include/linux/fortify-string.h:265:22: note: expanded from macro '__fortify_memset_chk'
           __underlying_memset(p, c, __fortify_size);                      \
                               ^
   2 warnings and 4 errors generated.


vim +2207 kernel/fork.c

0f2122045b9462 Jens Axboe        2020-09-13  2203  
3e724f844e3fe4 Gang Li           2022-05-12  2204  #ifdef SPLIT_RSS_NUMA_COUNTING
3e724f844e3fe4 Gang Li           2022-05-12  2205  	memset(&p->rss_stat, 0, sizeof(p->rss_stat) - sizeof(p->rss_stat.numa_count));
3e724f844e3fe4 Gang Li           2022-05-12  2206  #else
a3a2e76c77fa22 KAMEZAWA Hiroyuki 2010-04-06 @2207  	memset(&p->rss_stat, 0, sizeof(p->rss_stat));
a3a2e76c77fa22 KAMEZAWA Hiroyuki 2010-04-06  2208  #endif
172ba844a8851c Balbir Singh      2007-07-09  2209  
6976675d94042f Arjan van de Ven  2008-09-01  2210  	p->default_timer_slack_ns = current->timer_slack_ns;
6976675d94042f Arjan van de Ven  2008-09-01  2211  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp