From: Ping-Ke Shih <pkshih@realtek.com>
To: <kvalo@kernel.org>
Cc: <linux-wireless@vger.kernel.org>, <kevin_yang@realtek.com>
Subject: [PATCH 6/6] rtw89: pci: only mask out INT indicator register for disable interrupt v1
Date: Fri, 13 May 2022 13:42:24 +0800 [thread overview]
Message-ID: <20220513054224.16902-7-pkshih@realtek.com> (raw)
In-Reply-To: <20220513054224.16902-1-pkshih@realtek.com>
The design of INT indicator register (R_AX_PCIE_HIMR00_V1) is to reduce IO
during frequent interrupts, because it can stop chip sending interrupt to
host if we just set this indicator to 0, not all IMR(s). This indicator
register looks like a root interrupt controller of wifi chip.
However, we can't set all other IMR(s) to 0 during we are running on
interrupt service routine, or the indicator register can't reflect the
status of certain interrupt happened during this period, and then miss
some interrupts especially SER interrupt events.
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
drivers/net/wireless/realtek/rtw89/pci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index 2bdce7024f25b..0ef7821b2e0fc 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -682,9 +682,6 @@ EXPORT_SYMBOL(rtw89_pci_enable_intr_v1);
void rtw89_pci_disable_intr_v1(struct rtw89_dev *rtwdev, struct rtw89_pci *rtwpci)
{
rtw89_write32(rtwdev, R_AX_PCIE_HIMR00_V1, 0);
- rtw89_write32(rtwdev, R_AX_HIMR0, 0);
- rtw89_write32(rtwdev, R_AX_HAXI_HIMR00, 0);
- rtw89_write32(rtwdev, R_AX_HIMR1, 0);
}
EXPORT_SYMBOL(rtw89_pci_disable_intr_v1);
--
2.25.1
prev parent reply other threads:[~2022-05-13 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 5:42 [PATCH 0/6] rtw89: add missing functions and fix misbehavior found by verification Ping-Ke Shih
2022-05-13 5:42 ` [PATCH 1/6] rtw89: add ieee80211::sta_rc_update ops Ping-Ke Shih
2022-05-13 5:42 ` [PATCH 2/6] rtw89: 8852c: set TX antenna path Ping-Ke Shih
2022-05-13 5:42 ` [PATCH 3/6] rtw89: cfo: check mac_id to avoid out-of-bounds Ping-Ke Shih
2022-05-13 5:42 ` [PATCH 4/6] rtw89: 8852c: update txpwr tables to HALRF_027_00_052 Ping-Ke Shih
2022-05-13 5:42 ` [PATCH 5/6] rtw89: convert rtw89_band to nl80211_band precisely Ping-Ke Shih
2022-05-13 16:34 ` Jeff Johnson
2022-05-16 0:41 ` Pkshih
2022-05-13 5:42 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513054224.16902-7-pkshih@realtek.com \
--to=pkshih@realtek.com \
--cc=kevin_yang@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.