From: Jakub Kicinski <kuba@kernel.org>
To: Maxim Mikityanskiy <maximmi@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Paolo Abeni <pabeni@redhat.com>,
Boris Pismenny <borisp@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] tls: Add opt-in zerocopy mode of sendfile()
Date: Fri, 13 May 2022 09:02:13 -0700 [thread overview]
Message-ID: <20220513090213.2d1ca3c8@kernel.org> (raw)
In-Reply-To: <507d2140-1f22-174d-f55e-16ebcf03f249@nvidia.com>
On Fri, 13 May 2022 10:57:06 +0300 Maxim Mikityanskiy wrote:
> > What about the reporting via sock diag? Am I misremembering something?
>
> I recall we discussed that "zerocopy is active" can be restored as
> "hardware offload && setsockopt flag requested", and I saw that
> tls_get_info exposes the hardware offload state for the socket, so I
> thought the existing information in sock_diag was enough.
>
> If you think, though, that it will be better to have an explicit
> indication of the zerocopy flag to sock_diag, I can add it, it's not a
> problem.
Yeah, my thinking is that if a user reports problems to me I'd like to
be able to log in to the box and see what they have configured on the
socket. ss is quick and easy to type. I'm not aware of tooling that'd
grab descriptors for sockets and do getsockopt() (even tho technically
it is doable), are there any? I'm not feeling strong about sock_diag
specifically being the way but for such a potentially correctness-
-impacting optimization we should give admins an easy way to
interrogate if it's enabled or not.
> Does the rest of the patch look good to you?
Yup!
prev parent reply other threads:[~2022-05-13 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 12:15 [PATCH net-next v2] tls: Add opt-in zerocopy mode of sendfile() Maxim Mikityanskiy
2022-05-12 23:34 ` Jakub Kicinski
2022-05-13 7:57 ` Maxim Mikityanskiy
2022-05-13 16:02 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513090213.2d1ca3c8@kernel.org \
--to=kuba@kernel.org \
--cc=borisp@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.