From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8822C433EF for ; Fri, 13 May 2022 16:48:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240361AbiEMQs3 (ORCPT ); Fri, 13 May 2022 12:48:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233139AbiEMQs2 (ORCPT ); Fri, 13 May 2022 12:48:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB830522C3 for ; Fri, 13 May 2022 09:48:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 62D9E61EFE for ; Fri, 13 May 2022 16:48:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92B45C34100; Fri, 13 May 2022 16:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652460505; bh=R8Ovr0t1XquDu8/0O/FVoSyineOGnSMDllavpJzGm3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pjw85g0VbZFckhbyvInWIlyi1gaNTmEma7X8e+JHYmtG0/XFj9LqRYm6hQrifVHUE MBNRxQH7U4natczXTNOdA8tWXQi+i3OL07Yg4RceZ191+8OiIRN//lsRNlyFn2Cujm 5rVpv2fnFXGiKMI2FZkKsvZ1Bjgj8sED8IwUKkV4LUVHwDna0mPQNPHUQ3YEWzza9l TUHfwXsbGI1sdzYn0arB1yAWmc+16KBLv7gBcXC52/AF6qL3aj+664RwCdQbXNrESu aedbzdV1j7umrA/lNlBQYm5Na47NPH3LFu+XAU3FkJVsEWSFAa8j76kdfvADV3fb5X G/U1BeGwEQ6nw== Received: by pali.im (Postfix) id B4BEC2B90; Fri, 13 May 2022 18:48:22 +0200 (CEST) Date: Fri, 13 May 2022 18:48:22 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Marek =?utf-8?B?QmVow7pu?= , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 00/18] PCI: aardvark controller changes BATCH 5 Message-ID: <20220513164822.x34qe4blx5hfw5tx@pali> References: <20220220193346.23789-1-kabel@kernel.org> <20220513103328.GB26886@lpieralisi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220513103328.GB26886@lpieralisi> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Friday 13 May 2022 11:33:28 Lorenzo Pieralisi wrote: > On Sun, Feb 20, 2022 at 08:33:28PM +0100, Marek Behún wrote: > > Hello Lorenzo, Krzysztof, > > > > here comes batch 5 of changes for Aardvark PCIe controller. > > > > This batch > > - adds support for AER > > - adds support for DLLSC and hotplug interrupt > > - adds support for sending slot power limit message > > - adds enabling/disabling PCIe clock > > - adds suspend support > > - optimizes link training by adding it into separate worker > > - optimizes GPIO resetting by asserting it only if it wasn't asserted > > already > > I had a look and I can take patches 3 and 5 to cut the delta further, > please let me know if that helps. Hello! Hopefully Marek would be back in week or more. Meanwhile patches 3 and 5 should be fine to take. > Thanks, > Lorenzo > > > Marek > > > > Marek Behún (1): > > arm64: dts: marvell: armada-37xx: Add clock to PCIe node > > > > Miquel Raynal (2): > > PCI: aardvark: Add clock support > > PCI: aardvark: Add suspend to RAM support > > > > Pali Rohár (13): > > PCI: aardvark: Add support for AER registers on emulated bridge > > PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros > > PCI: aardvark: Fix reporting Slot capabilities on emulated bridge > > PCI: pciehp: Enable DLLSC interrupt only if supported > > PCI: pciehp: Enable Command Completed Interrupt only if supported > > PCI: aardvark: Add support for DLLSC and hotplug interrupt > > PCI: Add PCI_EXP_SLTCTL_ASPL_DISABLE macro > > PCI: Add function for parsing `slot-power-limit-milliwatt` DT property > > dt-bindings: PCI: aardvark: Describe slot-power-limit-milliwatt > > PCI: aardvark: Send Set_Slot_Power_Limit message > > arm64: dts: armada-3720-turris-mox: Define slot-power-limit-milliwatt > > for PCIe > > PCI: aardvark: Run link training in separate worker > > PCI: aardvark: Optimize PCIe card reset via GPIO > > > > Russell King (2): > > PCI: pci-bridge-emul: Re-arrange register tests > > PCI: pci-bridge-emul: Add support for PCIe extended capabilities > > > > .../devicetree/bindings/pci/aardvark-pci.txt | 2 + > > .../dts/marvell/armada-3720-turris-mox.dts | 1 + > > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 + > > drivers/pci/controller/pci-aardvark.c | 380 ++++++++++++++++-- > > drivers/pci/hotplug/pciehp_hpc.c | 34 +- > > drivers/pci/hotplug/pnv_php.c | 13 +- > > drivers/pci/of.c | 64 +++ > > drivers/pci/pci-bridge-emul.c | 130 +++--- > > drivers/pci/pci-bridge-emul.h | 15 + > > drivers/pci/pci.h | 15 + > > include/uapi/linux/pci_regs.h | 4 + > > 11 files changed, 565 insertions(+), 94 deletions(-) > > > > -- > > 2.34.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9CBFC433EF for ; Fri, 13 May 2022 16:49:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mQplily9ZrK64BrGaMpFQqBpGVMKro6uBDEvFSN/61A=; b=UBkzYIhsJbm9gP lrNKVeTN8yxJATX0u/fGFjamxIA9btk/ydH9J9GP+9QmKqiUcG4J943GeSr7LQJLDZF6D1T+05rD5 yKj2ddxNmJcfQN32aaDw6AGbYaigBxHtOcbVZ0goTRdycc54uv8xv2QjA+gtbsGyQ5lBfeePwgykG 1SWy1d7n2L18ZT42UzSY3fy4WpncupPNRECb/Xkf2OJjzUtC7ux9oERnJWpzSpra6okAoX0uAFePF lejqz705MGUrD8mdaDUaAIyS/kOIh97pklrVGxIHvvo5DRlJFq0eDUH5x9D7vn182nJKb5CyVDGgV LxAl0HQ/1kc19Fd5LvAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npYSu-00Gtjw-2q; Fri, 13 May 2022 16:48:32 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npYSq-00GtjP-NW for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 16:48:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AF6361EE4; Fri, 13 May 2022 16:48:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92B45C34100; Fri, 13 May 2022 16:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652460505; bh=R8Ovr0t1XquDu8/0O/FVoSyineOGnSMDllavpJzGm3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pjw85g0VbZFckhbyvInWIlyi1gaNTmEma7X8e+JHYmtG0/XFj9LqRYm6hQrifVHUE MBNRxQH7U4natczXTNOdA8tWXQi+i3OL07Yg4RceZ191+8OiIRN//lsRNlyFn2Cujm 5rVpv2fnFXGiKMI2FZkKsvZ1Bjgj8sED8IwUKkV4LUVHwDna0mPQNPHUQ3YEWzza9l TUHfwXsbGI1sdzYn0arB1yAWmc+16KBLv7gBcXC52/AF6qL3aj+664RwCdQbXNrESu aedbzdV1j7umrA/lNlBQYm5Na47NPH3LFu+XAU3FkJVsEWSFAa8j76kdfvADV3fb5X G/U1BeGwEQ6nw== Received: by pali.im (Postfix) id B4BEC2B90; Fri, 13 May 2022 18:48:22 +0200 (CEST) Date: Fri, 13 May 2022 18:48:22 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Lorenzo Pieralisi Cc: Marek =?utf-8?B?QmVow7pu?= , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 00/18] PCI: aardvark controller changes BATCH 5 Message-ID: <20220513164822.x34qe4blx5hfw5tx@pali> References: <20220220193346.23789-1-kabel@kernel.org> <20220513103328.GB26886@lpieralisi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220513103328.GB26886@lpieralisi> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220513_094828_883090_6F734904 X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpZGF5IDEzIE1heSAyMDIyIDExOjMzOjI4IExvcmVuem8gUGllcmFsaXNpIHdyb3RlOgo+ IE9uIFN1biwgRmViIDIwLCAyMDIyIGF0IDA4OjMzOjI4UE0gKzAxMDAsIE1hcmVrIEJlaMO6biB3 cm90ZToKPiA+IEhlbGxvIExvcmVuem8sIEtyenlzenRvZiwKPiA+IAo+ID4gaGVyZSBjb21lcyBi YXRjaCA1IG9mIGNoYW5nZXMgZm9yIEFhcmR2YXJrIFBDSWUgY29udHJvbGxlci4KPiA+IAo+ID4g VGhpcyBiYXRjaAo+ID4gLSBhZGRzIHN1cHBvcnQgZm9yIEFFUgo+ID4gLSBhZGRzIHN1cHBvcnQg Zm9yIERMTFNDIGFuZCBob3RwbHVnIGludGVycnVwdAo+ID4gLSBhZGRzIHN1cHBvcnQgZm9yIHNl bmRpbmcgc2xvdCBwb3dlciBsaW1pdCBtZXNzYWdlCj4gPiAtIGFkZHMgZW5hYmxpbmcvZGlzYWJs aW5nIFBDSWUgY2xvY2sKPiA+IC0gYWRkcyBzdXNwZW5kIHN1cHBvcnQKPiA+IC0gb3B0aW1pemVz IGxpbmsgdHJhaW5pbmcgYnkgYWRkaW5nIGl0IGludG8gc2VwYXJhdGUgd29ya2VyCj4gPiAtIG9w dGltaXplcyBHUElPIHJlc2V0dGluZyBieSBhc3NlcnRpbmcgaXQgb25seSBpZiBpdCB3YXNuJ3Qg YXNzZXJ0ZWQKPiA+ICAgYWxyZWFkeQo+IAo+IEkgaGFkIGEgbG9vayBhbmQgSSBjYW4gdGFrZSBw YXRjaGVzIDMgYW5kIDUgdG8gY3V0IHRoZSBkZWx0YSBmdXJ0aGVyLAo+IHBsZWFzZSBsZXQgbWUg a25vdyBpZiB0aGF0IGhlbHBzLgoKSGVsbG8hIEhvcGVmdWxseSBNYXJlayB3b3VsZCBiZSBiYWNr IGluIHdlZWsgb3IgbW9yZS4gTWVhbndoaWxlIHBhdGNoZXMKMyBhbmQgNSBzaG91bGQgYmUgZmlu ZSB0byB0YWtlLgoKPiBUaGFua3MsCj4gTG9yZW56bwo+IAo+ID4gTWFyZWsKPiA+IAo+ID4gTWFy ZWsgQmVow7puICgxKToKPiA+ICAgYXJtNjQ6IGR0czogbWFydmVsbDogYXJtYWRhLTM3eHg6IEFk ZCBjbG9jayB0byBQQ0llIG5vZGUKPiA+IAo+ID4gTWlxdWVsIFJheW5hbCAoMik6Cj4gPiAgIFBD STogYWFyZHZhcms6IEFkZCBjbG9jayBzdXBwb3J0Cj4gPiAgIFBDSTogYWFyZHZhcms6IEFkZCBz dXNwZW5kIHRvIFJBTSBzdXBwb3J0Cj4gPiAKPiA+IFBhbGkgUm9ow6FyICgxMyk6Cj4gPiAgIFBD STogYWFyZHZhcms6IEFkZCBzdXBwb3J0IGZvciBBRVIgcmVnaXN0ZXJzIG9uIGVtdWxhdGVkIGJy aWRnZQo+ID4gICBQQ0k6IEFkZCBQQ0lfRVhQX1NMVENBUF8qX1NISUZUIG1hY3Jvcwo+ID4gICBQ Q0k6IGFhcmR2YXJrOiBGaXggcmVwb3J0aW5nIFNsb3QgY2FwYWJpbGl0aWVzIG9uIGVtdWxhdGVk IGJyaWRnZQo+ID4gICBQQ0k6IHBjaWVocDogRW5hYmxlIERMTFNDIGludGVycnVwdCBvbmx5IGlm IHN1cHBvcnRlZAo+ID4gICBQQ0k6IHBjaWVocDogRW5hYmxlIENvbW1hbmQgQ29tcGxldGVkIElu dGVycnVwdCBvbmx5IGlmIHN1cHBvcnRlZAo+ID4gICBQQ0k6IGFhcmR2YXJrOiBBZGQgc3VwcG9y dCBmb3IgRExMU0MgYW5kIGhvdHBsdWcgaW50ZXJydXB0Cj4gPiAgIFBDSTogQWRkIFBDSV9FWFBf U0xUQ1RMX0FTUExfRElTQUJMRSBtYWNybwo+ID4gICBQQ0k6IEFkZCBmdW5jdGlvbiBmb3IgcGFy c2luZyBgc2xvdC1wb3dlci1saW1pdC1taWxsaXdhdHRgIERUIHByb3BlcnR5Cj4gPiAgIGR0LWJp bmRpbmdzOiBQQ0k6IGFhcmR2YXJrOiBEZXNjcmliZSBzbG90LXBvd2VyLWxpbWl0LW1pbGxpd2F0 dAo+ID4gICBQQ0k6IGFhcmR2YXJrOiBTZW5kIFNldF9TbG90X1Bvd2VyX0xpbWl0IG1lc3NhZ2UK PiA+ICAgYXJtNjQ6IGR0czogYXJtYWRhLTM3MjAtdHVycmlzLW1veDogRGVmaW5lIHNsb3QtcG93 ZXItbGltaXQtbWlsbGl3YXR0Cj4gPiAgICAgZm9yIFBDSWUKPiA+ICAgUENJOiBhYXJkdmFyazog UnVuIGxpbmsgdHJhaW5pbmcgaW4gc2VwYXJhdGUgd29ya2VyCj4gPiAgIFBDSTogYWFyZHZhcms6 IE9wdGltaXplIFBDSWUgY2FyZCByZXNldCB2aWEgR1BJTwo+ID4gCj4gPiBSdXNzZWxsIEtpbmcg KDIpOgo+ID4gICBQQ0k6IHBjaS1icmlkZ2UtZW11bDogUmUtYXJyYW5nZSByZWdpc3RlciB0ZXN0 cwo+ID4gICBQQ0k6IHBjaS1icmlkZ2UtZW11bDogQWRkIHN1cHBvcnQgZm9yIFBDSWUgZXh0ZW5k ZWQgY2FwYWJpbGl0aWVzCj4gPiAKPiA+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvYWFy ZHZhcmstcGNpLnR4dCAgfCAgIDIgKwo+ID4gIC4uLi9kdHMvbWFydmVsbC9hcm1hZGEtMzcyMC10 dXJyaXMtbW94LmR0cyAgICB8ICAgMSArCj4gPiAgYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2ZWxs L2FybWFkYS0zN3h4LmR0c2kgIHwgICAxICsKPiA+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL3Bj aS1hYXJkdmFyay5jICAgICAgICAgfCAzODAgKysrKysrKysrKysrKysrKy0tCj4gPiAgZHJpdmVy cy9wY2kvaG90cGx1Zy9wY2llaHBfaHBjLmMgICAgICAgICAgICAgIHwgIDM0ICstCj4gPiAgZHJp dmVycy9wY2kvaG90cGx1Zy9wbnZfcGhwLmMgICAgICAgICAgICAgICAgIHwgIDEzICstCj4gPiAg ZHJpdmVycy9wY2kvb2YuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDY0ICsrKwo+ ID4gIGRyaXZlcnMvcGNpL3BjaS1icmlkZ2UtZW11bC5jICAgICAgICAgICAgICAgICB8IDEzMCAr KystLS0KPiA+ICBkcml2ZXJzL3BjaS9wY2ktYnJpZGdlLWVtdWwuaCAgICAgICAgICAgICAgICAg fCAgMTUgKwo+ID4gIGRyaXZlcnMvcGNpL3BjaS5oICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAxNSArCj4gPiAgaW5jbHVkZS91YXBpL2xpbnV4L3BjaV9yZWdzLmggICAgICAgICAgICAg ICAgIHwgICA0ICsKPiA+ICAxMSBmaWxlcyBjaGFuZ2VkLCA1NjUgaW5zZXJ0aW9ucygrKSwgOTQg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IC0tIAo+ID4gMi4zNC4xCj4gPiAKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK