From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E29B9C433F5 for ; Fri, 13 May 2022 17:42:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383156AbiEMRmS (ORCPT ); Fri, 13 May 2022 13:42:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349689AbiEMRmQ (ORCPT ); Fri, 13 May 2022 13:42:16 -0400 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8336E3B3DA; Fri, 13 May 2022 10:42:14 -0700 (PDT) Received: by mail-qk1-f175.google.com with SMTP id z126so7594503qkb.2; Fri, 13 May 2022 10:42:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=97E4heSYwRBKYVRwXdi6vqHrNTq98nZhg9phqwxgAhQ=; b=19BtCJIHeXx6YnUtlZG+Xsgl/V3sPmmrZWTw0FpiVXE+B6xMY+rECSSIqaDxW0cYfz Gbab6THd8K47ALkttdapGVg0d1VdEqV/zdHHYz4cqHWgpoC5fcy4vNhxJtfa+tZ6cf/F rR/uUQLg3LeaQVbvIotNP7sDefxBf546BqQC24ztr951gbp2gB6MZ3+EPXCAKjYSAKUy i+dkPS3sG7p1PRa0SFArPoI4oG6j8LjJLwxeUqIP9+A4bW4UNiil0Sv2X7nsM9cddBSY ojzQmLJXpdIFUU9urBATpokDnlP/f/DqrF5mVffkYjEON7ClNA6nma2mOU8/tkHqxtUa oUeQ== X-Gm-Message-State: AOAM532LD8kAvA3Z0Rx2opu8xGKzAdLOe21FEVclr65wP3pi/iW9L/dG va1KYWQOJ4K7yabojlGv76A= X-Google-Smtp-Source: ABdhPJw/SDz0dQHBIutw7pRAimO1JpJHMkuofuWyT/cEabDgF7Kn0Vimv3OrPdeEdfry+uEXmlkDpA== X-Received: by 2002:a37:98c4:0:b0:69a:e14:16a2 with SMTP id a187-20020a3798c4000000b0069a0e1416a2mr4538933qke.610.1652463733017; Fri, 13 May 2022 10:42:13 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-014.fbsv.net. [2a03:2880:20ff:e::face:b00c]) by smtp.gmail.com with ESMTPSA id u123-20020ae9d881000000b006a0462eb091sm1634970qkf.80.2022.05.13.10.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 10:42:12 -0700 (PDT) Date: Fri, 13 May 2022 10:42:11 -0700 From: David Vernet To: Michal =?utf-8?Q?Koutn=C3=BD?= Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, tj@kernel.org, Richard Palethorpe Subject: Re: [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling Message-ID: <20220513174211.uv5yxzt5sochmwal@dev0025.ash9.facebook.com> References: <20220512174452.tr34tuh4k5jm6qjs@dev0025.ash9.facebook.com> <20220513171811.730-1-mkoutny@suse.com> <20220513171811.730-3-mkoutny@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220513171811.730-3-mkoutny@suse.com> User-Agent: NeoMutt/20211029 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2022 at 07:18:09PM +0200, Michal Koutný wrote: > This is effectively a revert of commit cdc69458a5f3 ("cgroup: account > for memory_recursiveprot in test_memcg_low()"). The case test_memcg_low > will fail with memory_recursiveprot until resolved in reclaim > code. > However, this patch preserves the existing helpers and variables for > later uses. > > Signed-off-by: Michal Koutný > --- > tools/testing/selftests/cgroup/test_memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c > index 4958b42201a9..eba252fa64ac 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > @@ -528,7 +528,7 @@ static int test_memcg_low(const char *root) > } > > for (i = 0; i < ARRAY_SIZE(children); i++) { > - int no_low_events_index = has_recursiveprot ? 2 : 1; > + int no_low_events_index = 1; > > oom = cg_read_key_long(children[i], "memory.events", "oom "); > low = cg_read_key_long(children[i], "memory.events", "low "); > -- > 2.35.3 > Reviewed-by: David Vernet From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vernet Subject: Re: [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling Date: Fri, 13 May 2022 10:42:11 -0700 Message-ID: <20220513174211.uv5yxzt5sochmwal@dev0025.ash9.facebook.com> References: <20220512174452.tr34tuh4k5jm6qjs@dev0025.ash9.facebook.com> <20220513171811.730-1-mkoutny@suse.com> <20220513171811.730-3-mkoutny@suse.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20220513171811.730-3-mkoutny-IBi9RG/b67k@public.gmane.org> List-ID: Content-Type: text/plain; charset="iso-8859-1" To: Michal =?utf-8?Q?Koutn=C3=BD?= Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Richard Palethorpe On Fri, May 13, 2022 at 07:18:09PM +0200, Michal Koutn=FD wrote: > This is effectively a revert of commit cdc69458a5f3 ("cgroup: account > for memory_recursiveprot in test_memcg_low()"). The case test_memcg_low > will fail with memory_recursiveprot until resolved in reclaim > code. > However, this patch preserves the existing helpers and variables for > later uses. >=20 > Signed-off-by: Michal Koutn=FD > --- > tools/testing/selftests/cgroup/test_memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/tes= ting/selftests/cgroup/test_memcontrol.c > index 4958b42201a9..eba252fa64ac 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > @@ -528,7 +528,7 @@ static int test_memcg_low(const char *root) > } > =20 > for (i =3D 0; i < ARRAY_SIZE(children); i++) { > - int no_low_events_index =3D has_recursiveprot ? 2 : 1; > + int no_low_events_index =3D 1; > =20 > oom =3D cg_read_key_long(children[i], "memory.events", "oom "); > low =3D cg_read_key_long(children[i], "memory.events", "low "); > --=20 > 2.35.3 >=20 Reviewed-by: David Vernet