From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 926CCC433EF for ; Fri, 13 May 2022 23:14:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1705540420; Fri, 13 May 2022 23:14:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7KLaYWUwte1Z; Fri, 13 May 2022 23:14:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id E1E5F40235; Fri, 13 May 2022 23:14:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B9CCAC0032; Fri, 13 May 2022 23:14:25 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 497B8C002D for ; Fri, 13 May 2022 23:14:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2886283E96 for ; Fri, 13 May 2022 23:14:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gzK9Kz4kAnq4 for ; Fri, 13 May 2022 23:14:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by smtp1.osuosl.org (Postfix) with ESMTPS id EA5A482849 for ; Fri, 13 May 2022 23:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652483662; x=1684019662; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+wjfqOqIYe6TZTMHFU68r4+WktU+l0Y6oPd5aHItbaM=; b=LmpkmlaRZMlYWmEKReMaZJBxJrFOmFxq46JAXeiHl5prp6A/b/QwTFYA 9V/GKuc9thnUCvH5FIrr6NeBgAycESwwebjv7FhYzhUzUudrrc1XHEorn YI/s7qwa0DYFA3IBsvGWou6q9xA0KqvP2Ba+GplOlsmAczdn883ISV28r +v1znY8NWWKwpp3zkT9zzEmO8KM3K+YR1CPWTh7S+3wLIVCigDru2oRF8 pzdUh7vIKsvGa/SyG6d5mq4Sl3Jr2V+23BTkXQAhs2t+QX3t5OjB8cIup OriFbMALHjg0eTkHYtihi3ObpsGSm196Ys3HXuM3ZynA4ZAyrzAKXPGuF g==; X-IronPort-AV: E=McAfee;i="6400,9594,10346"; a="333465800" X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="333465800" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 16:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="815594245" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmsmga006.fm.intel.com with ESMTP; 13 May 2022 16:14:19 -0700 Date: Fri, 13 May 2022 16:17:54 -0700 From: Ricardo Neri To: Nicholas Piggin Subject: Re: [PATCH v6 24/29] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog" Message-ID: <20220513231754.GB9074@ranerica-svr.sc.intel.com> References: <20220506000008.30892-1-ricardo.neri-calderon@linux.intel.com> <20220506000008.30892-25-ricardo.neri-calderon@linux.intel.com> <1652179333.fnu2fjiffn.astroid@bobo.none> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1652179333.fnu2fjiffn.astroid@bobo.none> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: "Ravi V. Shankar" , Andi Kleen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian , Ricardo Neri , iommu@lists.linux-foundation.org, Tony Luck , Thomas Gleixner , David Woodhouse , Andrew Morton X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, May 10, 2022 at 08:46:41PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > Prepare hardlockup_panic_setup() to handle a comma-separated list of > > options. Thus, it can continue parsing its own command-line options while > > ignoring parameters that are relevant only to specific implementations of > > the hardlockup detector. Such implementations may use an early_param to > > parse their own options. > > It can't really handle comma separated list though, until the next > patch. nmi_watchdog=panic,0 does not make sense, so you lost error > handling of that. Yes that is true. All possible combinations need to be checked. > > And is it kosher to double handle options like this? I'm sure it > happens but it's ugly. > > Would you consider just add a new option for x86 and avoid changing > this? Less code and patches. Sure, I can not modify this code and add a x86-specific command-line option. Thanks and BR, Ricardo _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F1FC433F5 for ; Fri, 13 May 2022 23:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233366AbiEMXOi (ORCPT ); Fri, 13 May 2022 19:14:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbiEMXOe (ORCPT ); Fri, 13 May 2022 19:14:34 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A093320CB5 for ; Fri, 13 May 2022 16:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652483661; x=1684019661; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+wjfqOqIYe6TZTMHFU68r4+WktU+l0Y6oPd5aHItbaM=; b=Mah62wU8ASEQE1z70AZpSnzFUBLvtPJuqVJ3Mt1gQrhJ0/84a7PfWviq Z/PSEKxIFaRpTOhB0xC5aLD03avu4vapzKtH79L4cD1wh/t3ZnrSgQ0rP v45JYY77S8659Q+VqAMwPf/+bAs+/6Li/f2cAYa5GfWX5OnILlnGJffFh 00ZcySfLIbavc65EiwxIlsF99jcxopppAk5zo4b8gO1ax9AdUwIMgqARZ 7f6TSfcLqohQjZgg/tBnxCVy7jorN7GYBiW6r+2CamyYfi8PXEc2/3fyO its2hLyPXkNvRBXEt0whNg4jnnjGctQJbR+fQ/hcNlOeLmuJBAZxITPTe A==; X-IronPort-AV: E=McAfee;i="6400,9594,10346"; a="356855218" X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="356855218" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 16:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="815594245" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmsmga006.fm.intel.com with ESMTP; 13 May 2022 16:14:19 -0700 Date: Fri, 13 May 2022 16:17:54 -0700 From: Ricardo Neri To: Nicholas Piggin Cc: Thomas Gleixner , x86@kernel.org, Andi Kleen , Andrew Morton , Lu Baolu , David Woodhouse , Stephane Eranian , iommu@lists.linux-foundation.org, Joerg Roedel , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "Ravi V. Shankar" , Ricardo Neri , Suravee Suthikulpanit , Tony Luck Subject: Re: [PATCH v6 24/29] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog" Message-ID: <20220513231754.GB9074@ranerica-svr.sc.intel.com> References: <20220506000008.30892-1-ricardo.neri-calderon@linux.intel.com> <20220506000008.30892-25-ricardo.neri-calderon@linux.intel.com> <1652179333.fnu2fjiffn.astroid@bobo.none> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1652179333.fnu2fjiffn.astroid@bobo.none> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 08:46:41PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > Prepare hardlockup_panic_setup() to handle a comma-separated list of > > options. Thus, it can continue parsing its own command-line options while > > ignoring parameters that are relevant only to specific implementations of > > the hardlockup detector. Such implementations may use an early_param to > > parse their own options. > > It can't really handle comma separated list though, until the next > patch. nmi_watchdog=panic,0 does not make sense, so you lost error > handling of that. Yes that is true. All possible combinations need to be checked. > > And is it kosher to double handle options like this? I'm sure it > happens but it's ugly. > > Would you consider just add a new option for x86 and avoid changing > this? Less code and patches. Sure, I can not modify this code and add a x86-specific command-line option. Thanks and BR, Ricardo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A234C433F5 for ; Fri, 13 May 2022 23:15:59 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L0Pdp0CG6z3cFm for ; Sat, 14 May 2022 09:15:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Vgu2J1nN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ricardo.neri-calderon@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Vgu2J1nN; dkim-atps=neutral Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4L0Pd5553yz2yJ5 for ; Sat, 14 May 2022 09:15:21 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652483721; x=1684019721; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+wjfqOqIYe6TZTMHFU68r4+WktU+l0Y6oPd5aHItbaM=; b=Vgu2J1nNJQgs5EXgBTxF4FNScto+IELBc4yiIWjdYI4s5txrEnk56BUA 16cPzpCUMjS77XTmh77iFLgXjEmLAtw/i/c/oM5b2d8hSVjjBHj86a3A+ 0TCdhlXI9uPr/RiKeKGrrnaGI0HjLtF2gnIksg+CAcV4KAMAlmfVYHAPc cj2Xtoo8idBvxBmAt3SDVqTUsJcxUgNlj6gEn98ZT10+XEwqiwG9EivbU NJDMg+tlJZSkHlVqhN7Ol0yZFp6pEtjwOSkuN04NntK152J15mAQpoMVY 9iQvanDMtGrHZI8M+rmK6GIltY2LhZkhPNxQbWiUTuyaJed+4+E41mrIj g==; X-IronPort-AV: E=McAfee;i="6400,9594,10346"; a="270104314" X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="270104314" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 16:14:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="815594245" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmsmga006.fm.intel.com with ESMTP; 13 May 2022 16:14:19 -0700 Date: Fri, 13 May 2022 16:17:54 -0700 From: Ricardo Neri To: Nicholas Piggin Subject: Re: [PATCH v6 24/29] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog" Message-ID: <20220513231754.GB9074@ranerica-svr.sc.intel.com> References: <20220506000008.30892-1-ricardo.neri-calderon@linux.intel.com> <20220506000008.30892-25-ricardo.neri-calderon@linux.intel.com> <1652179333.fnu2fjiffn.astroid@bobo.none> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1652179333.fnu2fjiffn.astroid@bobo.none> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Ravi V. Shankar" , Andi Kleen , linuxppc-dev@lists.ozlabs.org, Joerg Roedel , x86@kernel.org, linux-kernel@vger.kernel.org, Stephane Eranian , Ricardo Neri , iommu@lists.linux-foundation.org, Tony Luck , Suravee Suthikulpanit , Thomas Gleixner , David Woodhouse , Andrew Morton , Lu Baolu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, May 10, 2022 at 08:46:41PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > Prepare hardlockup_panic_setup() to handle a comma-separated list of > > options. Thus, it can continue parsing its own command-line options while > > ignoring parameters that are relevant only to specific implementations of > > the hardlockup detector. Such implementations may use an early_param to > > parse their own options. > > It can't really handle comma separated list though, until the next > patch. nmi_watchdog=panic,0 does not make sense, so you lost error > handling of that. Yes that is true. All possible combinations need to be checked. > > And is it kosher to double handle options like this? I'm sure it > happens but it's ugly. > > Would you consider just add a new option for x86 and avoid changing > this? Less code and patches. Sure, I can not modify this code and add a x86-specific command-line option. Thanks and BR, Ricardo