From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B53C2F25 for ; Sat, 14 May 2022 21:54:18 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id i1so11104719plg.7 for ; Sat, 14 May 2022 14:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FykryA/PR0f3p83HjJunId+gp3pqJzOIiL8j+Agnd3A=; b=P0ytf3VHbbsXrhqae2Zd5Ll2MuTMZ+sX3YHcECJ6uHTAKjjZna4wFiZzv5hRwMvEBn MxFkALqYT4Cep0hR0dt+cnddTbsgr75zHgcZlKpFQ9CIHgn+CBZ3EJ9Igtchk6wXVYPF Y/kmkar9pi2d7USkoTKnPI5F2B7oJSyz12a68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FykryA/PR0f3p83HjJunId+gp3pqJzOIiL8j+Agnd3A=; b=N2lAiuAD3ywfP7Z6nn7M0n3AGj/whkJkFUG6FQNLNgje8pNClwwH/AV7y3MUdn1fXr ls5RbOEVKyloHyEjNQ8sQDUy+5ls/d1J+/Fey7uU1Uz++CDhXsMt1gzWhOdxZtJ9wtdO 5moPtyMYjJ4WR786QXQpjBvn7PCnq+5cqgEgjP35F92lnq+DaxS7HHJqJXrtLh+H0emq UyFHRWYQkmpw45bvpsUIhar++bwozJAyi8PjpPKiqbuZRCr4I3T8el+NAy0kGl1UBg1H xi8m+vFhlPw0Mcx4QLW28M+Wd710Rnltgnljp0+dytNahzm1P/r6btogjJSPKCcj/Zup bp5g== X-Gm-Message-State: AOAM532HH+5a3WJaaQ3d0vfyzF+JWPFfSbh5ge3FjQXDKnZus3R3gLdn 0TkdzxFQId+KneLyLjLctnqkfw== X-Google-Smtp-Source: ABdhPJzoC13YHvqAZkelFuizL5j4/KrYwDhjo/xw/hl3PuFmx/isLndYV81BpaWdnzBIXYZT4z2fTA== X-Received: by 2002:a17:902:d507:b0:15e:afc4:85b5 with SMTP id b7-20020a170902d50700b0015eafc485b5mr10971844plg.52.1652565258544; Sat, 14 May 2022 14:54:18 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id fv7-20020a17090b0e8700b001cd4989fecfsm5694602pjb.27.2022.05.14.14.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:54:18 -0700 (PDT) Date: Sat, 14 May 2022 14:54:17 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 12/21] treewide: Drop function_nocfi Message-ID: <202205141454.9EBF450@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-13-samitolvanen@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220513202159.1550547-13-samitolvanen@google.com> On Fri, May 13, 2022 at 01:21:50PM -0700, Sami Tolvanen wrote: > With -fsanitize=kcfi, we no longer need function_nocfi() as > the compiler won't change function references to point to a > jump table. Remove all implementations and uses of the macro. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14E64C433EF for ; Sat, 14 May 2022 21:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+0i6cul3Tyg06ZfWnq+UJJs3Y+SbXMq9bGwrj7p9koY=; b=361PLNCgPwiCJ2 ZEminwjBQJVjpsR4D19/mSxGsfSQoiY4xSbU3H7HUEzgq75mtqidPbRNZeD0DcEja+h5bq5Yvtgbd 2VTaTt3sQ+Olq+Exp3lcNgFI0QjBv3xSSHe6OIye4M5yZPUeQilaHPvRldoTgt8T2Ns0Lb5jxsLfs sM10LJnPbNJq+8oMhJKMvQaDkwFT/hQPzPJqg3QaKQ1uaDXo5YhvP/knFQuBen5zQcvajcU7gwTjA gDPuhfhAhqwajWD8TH0vJPTzOjIcOxADzt/+SyxRFqOm6aKTjSuqBh9g50tHGT5bPQNMP0wRrKrtv 80ldbXRJplLb+mmp/qzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npziQ-002OP9-PP; Sat, 14 May 2022 21:54:23 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npziN-002ONh-O4 for linux-arm-kernel@lists.infradead.org; Sat, 14 May 2022 21:54:21 +0000 Received: by mail-pl1-x62e.google.com with SMTP id n8so11121309plh.1 for ; Sat, 14 May 2022 14:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FykryA/PR0f3p83HjJunId+gp3pqJzOIiL8j+Agnd3A=; b=P0ytf3VHbbsXrhqae2Zd5Ll2MuTMZ+sX3YHcECJ6uHTAKjjZna4wFiZzv5hRwMvEBn MxFkALqYT4Cep0hR0dt+cnddTbsgr75zHgcZlKpFQ9CIHgn+CBZ3EJ9Igtchk6wXVYPF Y/kmkar9pi2d7USkoTKnPI5F2B7oJSyz12a68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FykryA/PR0f3p83HjJunId+gp3pqJzOIiL8j+Agnd3A=; b=KL1krQC4zB/mo0DunVgVNsyxI4yR2t7NJywqxskL6n34uGR41vwqMI8QTsN7lFGdNV nkr4GGzHG3Azv4c5zrWv2SA76bhaCcxgQVtMB3733i46Im3OceQ84GvY3F7BZqeaWvzs BwaJYj3Np09zCu7UWA4v5AtAaja8NfeX8iS6xrvKy3bRxH70ykKPSmh7br/bPOoPDThj F18atoahkZRKXLPuv3FHqJz5Ck5DEmb7lw083Q2z7G/5z/vOjdDcpkPuudf0BtTdeP3L SUYXDgvdEN7Y8ija95xzBPm1LnVWceZghcTPq17Fhop5eyBOSp0ODFAKoXQfMenlzyvx i1WA== X-Gm-Message-State: AOAM532RrAe37dyIjT2SMefaoo6JB9XGgtBpAEP6I90KPZ1Kq+IbgSX2 /afrt1kQChAVWlPzxgEx9F5R8Q== X-Google-Smtp-Source: ABdhPJzoC13YHvqAZkelFuizL5j4/KrYwDhjo/xw/hl3PuFmx/isLndYV81BpaWdnzBIXYZT4z2fTA== X-Received: by 2002:a17:902:d507:b0:15e:afc4:85b5 with SMTP id b7-20020a170902d50700b0015eafc485b5mr10971844plg.52.1652565258544; Sat, 14 May 2022 14:54:18 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id fv7-20020a17090b0e8700b001cd4989fecfsm5694602pjb.27.2022.05.14.14.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:54:18 -0700 (PDT) Date: Sat, 14 May 2022 14:54:17 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 12/21] treewide: Drop function_nocfi Message-ID: <202205141454.9EBF450@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-13-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220513202159.1550547-13-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_145419_858046_EC175CCD X-CRM114-Status: GOOD ( 11.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 13, 2022 at 01:21:50PM -0700, Sami Tolvanen wrote: > With -fsanitize=kcfi, we no longer need function_nocfi() as > the compiler won't change function references to point to a > jump table. Remove all implementations and uses of the macro. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel