From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A76492F25 for ; Sat, 14 May 2022 21:58:08 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id q76so10665531pgq.10 for ; Sat, 14 May 2022 14:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F4n+C6M9Aw1zMVfcPORGXMMVLEr2xX50zcVOAMomtNI=; b=ORcydA/uFIOR4odJFAV1XxY+PcGt2zebDpivlroBUEMd4PMs7KqLIIwFyrSrx1hQve IphjhRek3rFH0b0wKiFSafB46D14B6zsDaIUkgdWyUVQ4HxGNE+LGPeFItDUMmv7WDWQ l82UrDZKj39Vo1sdMxdDyg2ceu7AxyeuoD9GA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F4n+C6M9Aw1zMVfcPORGXMMVLEr2xX50zcVOAMomtNI=; b=fc2KD7CKVa9XtC9pLvAg7Sa4QFaJieBBSa2RhXlE/CuOG2ysljNZTgzXu2IA+/0z/I TFDA+oihy01lVhKpPFAaCXg3RyxwMdbR+cOvBSVAnlB+fFmdiKWaMZv/e4f4vRg+kzTH Ze0J6Bge4/eNuMvARLe8agoz/j2AxyNjh0iqfj5I6koNS+GagU8pVMBJjnuWWqYWNyb1 qVLVY3F8QymR2hx62JWoF3aA7uBTZ6sBCnw+vqggNye1omdhfE+dthahxRIGUCew1g7D Hx3gLYSL3jddJ4TmEJijlM+C0yODrbFTWyNrnhKasjGXp7HkGeoJxyeM6V9bUSMeH4vQ YpeQ== X-Gm-Message-State: AOAM530QXAU4pqW2tvgowsuGANr2gpnKbUe0PlyjFZt7qt4FqaORbnEi 40Ww9HdsiYIm8/DdQfBYSZu7Aw== X-Google-Smtp-Source: ABdhPJwOtndnmF6wotSc9dg7+c73fyG5+SBhQYVy5w8DsKeAwdpvOT6FhYjPgzOsGs5Q1NOcr1h40Q== X-Received: by 2002:a63:190f:0:b0:3db:972b:46bb with SMTP id z15-20020a63190f000000b003db972b46bbmr7949134pgl.554.1652565488145; Sat, 14 May 2022 14:58:08 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o14-20020a655bce000000b003db8dd388afsm3840321pgr.10.2022.05.14.14.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:58:07 -0700 (PDT) Date: Sat, 14 May 2022 14:58:07 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 17/21] x86: Add types to indirectly called assembly functions Message-ID: <202205141458.80233E7ED@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-18-samitolvanen@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220513202159.1550547-18-samitolvanen@google.com> On Fri, May 13, 2022 at 01:21:55PM -0700, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, assembly functions indirectly called from C code > must be annotated with type identifiers to pass CFI checking. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57F91C433EF for ; Sat, 14 May 2022 21:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b/S+avbY6kOsgLRu+LHhJNoS0AQU2N77D1faVtmN1iw=; b=WKYKG5KFBXvAhg B7QxeeQE9cHz9aVjmlJHhBzrD/09LPjgMae2CH4jAXEd17wDtsbb2iqkX5ul7JGWuBMaGBypqNTbD MowC2fH1nGUMi7JTbFevc1W7A14d+FDAHKn9UUGribKvRoRyLZmHUzC/CFpcBqrybuKZ38GyM/Ai6 8HrLLer0QkLKL2tV8QE2ry71U2oo4Ic+JjRp14xc8jjcvzSdQxXKF12vjdwldo1GXYw20YbRsmALG gOTWUNJzaZyrbLEyAitjhpyWsQbV3sJ8fbxWIw0nBBUmfNsr5tYbwiIBVbUWk9uIagZrfl8/7Hhdd JE8mo+mtpacjpHC6undA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzm7-002Prx-Tu; Sat, 14 May 2022 21:58:12 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npzm5-002Ppz-6K for linux-arm-kernel@lists.infradead.org; Sat, 14 May 2022 21:58:10 +0000 Received: by mail-pg1-x529.google.com with SMTP id x12so10682895pgj.7 for ; Sat, 14 May 2022 14:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F4n+C6M9Aw1zMVfcPORGXMMVLEr2xX50zcVOAMomtNI=; b=ORcydA/uFIOR4odJFAV1XxY+PcGt2zebDpivlroBUEMd4PMs7KqLIIwFyrSrx1hQve IphjhRek3rFH0b0wKiFSafB46D14B6zsDaIUkgdWyUVQ4HxGNE+LGPeFItDUMmv7WDWQ l82UrDZKj39Vo1sdMxdDyg2ceu7AxyeuoD9GA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F4n+C6M9Aw1zMVfcPORGXMMVLEr2xX50zcVOAMomtNI=; b=eohLpMM3gMLuIhyq7nAkbzYM1D5YlB5bklISA+hr74xJmbvsn99gA09T4jn/hKN2Xx ttIg4KQ754qaIlltkozGhkr4LeUdqGvhr+3qD2IQbQxwaEob+6DfvmsiJSynq9dogAJQ jHBJObQoPHQzEAWooIgHVzRlv1dCyakX8ynRUWaTe8gSOmJtVVlqLcvyksJLpcQLuNzo //1isGX9jd3TdHL8qS4mHhVy4B4+pKCHk2Hb8mMNR86np3Rl1bh1gfatMrdka4reFi1h uH0nR0fyPmunkr1V3jUYJQ9RT1ZESSX5DgroYYUm6MuvqFm3+2PQnsL386k1pWJD3E7h Y7rQ== X-Gm-Message-State: AOAM530BFJmW7xlSYIQ0jcZJZqMTsjpKcPHTgkN0BmCTRWr6tW/Wa/i3 oT4gvvakwvesoufgDhE1OWrbTA== X-Google-Smtp-Source: ABdhPJwOtndnmF6wotSc9dg7+c73fyG5+SBhQYVy5w8DsKeAwdpvOT6FhYjPgzOsGs5Q1NOcr1h40Q== X-Received: by 2002:a63:190f:0:b0:3db:972b:46bb with SMTP id z15-20020a63190f000000b003db972b46bbmr7949134pgl.554.1652565488145; Sat, 14 May 2022 14:58:08 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o14-20020a655bce000000b003db8dd388afsm3840321pgr.10.2022.05.14.14.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 14:58:07 -0700 (PDT) Date: Sat, 14 May 2022 14:58:07 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [RFC PATCH v2 17/21] x86: Add types to indirectly called assembly functions Message-ID: <202205141458.80233E7ED@keescook> References: <20220513202159.1550547-1-samitolvanen@google.com> <20220513202159.1550547-18-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220513202159.1550547-18-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_145809_276038_7115E672 X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 13, 2022 at 01:21:55PM -0700, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, assembly functions indirectly called from C code > must be annotated with type identifiers to pass CFI checking. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel