From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0649CC433EF for ; Sun, 15 May 2022 01:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233660AbiEOB7t (ORCPT ); Sat, 14 May 2022 21:59:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233368AbiEOB7s (ORCPT ); Sat, 14 May 2022 21:59:48 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 428672B1B1 for ; Sat, 14 May 2022 18:59:47 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 3AA347159; Sat, 14 May 2022 21:59:46 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 3AA347159 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1652579986; bh=GMYdsCBCj3TGW3DG1ozLxaC75Un7iB+CKMvrAMqrF5U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mrMFby3BsS/B9s2G+NrJEEb0OpRjOrAYYUkn1qydVE1Nd48DSzX/v+GGPewFsVpwr ZtDw9HFNufInrWv0OBhkuxTb7tp9o2523DNlhAb1BouxnlVnqdDriEA7biodqDypMN QSW0uamWaV2B31ePxLy/+oBBGXOwCEdQKROQQT5g= Date: Sat, 14 May 2022 21:59:46 -0400 From: "J.Bruce Fields" To: trondmy@kernel.org Cc: Steve Dickson , linux-nfs@vger.kernel.org Subject: Re: [PATCH 0/6] Allow nfs4-acl-tools to access 'dacl' and 'sacl' Message-ID: <20220515015946.GB30004@fieldses.org> References: <20220514144436.4298-1-trondmy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220514144436.4298-1-trondmy@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Sat, May 14, 2022 at 10:44:30AM -0400, trondmy@kernel.org wrote: > From: Trond Myklebust > > The following patch set matches the kernel patches to allow access to > the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are very > basic, adding support for encoding/decoding the new attributes only when > the user specifies the '--dacl' or '--sacl' flags on the command line. Seems like a reasonable thing to do. I'd rather not be responsible for nfs4-acl-tools any longer, though. --b. > > Trond Myklebust (6): > libnfs4acl: Add helpers to set the dacl and sacl > libnfs4acl: Add support for the NFS4.1 ACE_INHERITED_ACE flag > The NFSv41 DACL and SACL prepend an extra field to the acl > nfs4_getacl: Add support for the --dacl and --sacl options > nfs4_setacl: Add support for the --dacl and --sacl options > Edit manpages to document the new --dacl, --sacl and inheritance > features > > include/libacl_nfs4.h | 18 +++++++ > include/nfs4.h | 6 +++ > libnfs4acl/Makefile | 2 + > libnfs4acl/acl_nfs4_copy_acl.c | 2 + > libnfs4acl/acl_nfs4_xattr_load.c | 14 +++++- > libnfs4acl/acl_nfs4_xattr_pack.c | 22 ++++++-- > libnfs4acl/nfs4_ace_from_string.c | 3 ++ > libnfs4acl/nfs4_get_ace_flags.c | 2 + > libnfs4acl/nfs4_getacl.c | 84 +++++++++++++++++++++++++++++++ > libnfs4acl/nfs4_new_acl.c | 1 + > libnfs4acl/nfs4_setacl.c | 49 ++++++++++++++++++ > man/man1/nfs4_getfacl.1 | 14 ++++++ > man/man1/nfs4_setfacl.1 | 8 +++ > man/man5/nfs4_acl.5 | 10 ++++ > nfs4_getfacl/nfs4_getfacl.c | 73 ++++++++++++++++++++++++--- > nfs4_setfacl/nfs4_setfacl.c | 67 ++++++++++++++++++++++-- > 16 files changed, 359 insertions(+), 16 deletions(-) > create mode 100644 libnfs4acl/nfs4_getacl.c > create mode 100644 libnfs4acl/nfs4_setacl.c > > -- > 2.36.1