[PATCH] MIPS: CPC: Fix refcount leak in mips_cpc_default_phys_base

From: Miaoqian Lin <linmq006@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Miaoqian Lin <linmq006@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Miodrag Dinic <miodrag.dinic@mips.com>,
	James Hogan <jhogan@kernel.org>,
	Paul Burton <paulburton@kernel.org>,
	Aleksandar Markovic <aleksandar.markovic@mips.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] MIPS: CPC: Fix refcount leak in mips_cpc_default_phys_base
Date: Mon, 16 May 2022 08:33:50 +0400	[thread overview]
Message-ID: <20220516043353.8147-1-linmq006@gmail.com> (raw)

of_find_compatible_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: 791412dafbbf ("MIPS: CPC: Map registers using DT in mips_cpc_default_phys_base()")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 arch/mips/kernel/mips-cpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c
index 17aff13cd7ce..3e386f7e1545 100644
--- a/arch/mips/kernel/mips-cpc.c
+++ b/arch/mips/kernel/mips-cpc.c
@@ -28,6 +28,7 @@ phys_addr_t __weak mips_cpc_default_phys_base(void)
 	cpc_node = of_find_compatible_node(of_root, NULL, "mti,mips-cpc");
 	if (cpc_node) {
 		err = of_address_to_resource(cpc_node, 0, &res);
+		of_node_put(cpc_node);
 		if (!err)
 			return res.start;
 	}
-- 
2.25.1

