From: Jason Gunthorpe <jgg@nvidia.com>
To: Cheng Xu <chengyou@linux.alibaba.com>
Cc: dledford@redhat.com, leon@kernel.org, linux-rdma@vger.kernel.org,
KaiShen@linux.alibaba.com, tonylu@linux.alibaba.com,
BMT@zurich.ibm.com
Subject: Re: [PATCH for-next v7 12/12] RDMA/erdma: Add driver to kernel build environment
Date: Mon, 16 May 2022 11:13:02 -0300 [thread overview]
Message-ID: <20220516141302.GX1343366@nvidia.com> (raw)
In-Reply-To: <cb86ec72-5878-6bba-1f4f-e0c2f25e45c9@linux.alibaba.com>
On Mon, May 16, 2022 at 11:40:46AM +0800, Cheng Xu wrote:
> > > diff --git a/drivers/infiniband/hw/Makefile b/drivers/infiniband/hw/Makefile
> > > index fba0b3be903e..6b3a88046125 100644
> > > +++ b/drivers/infiniband/hw/Makefile
> > > @@ -13,3 +13,4 @@ obj-$(CONFIG_INFINIBAND_HFI1) += hfi1/
> > > obj-$(CONFIG_INFINIBAND_HNS) += hns/
> > > obj-$(CONFIG_INFINIBAND_QEDR) += qedr/
> > > obj-$(CONFIG_INFINIBAND_BNXT_RE) += bnxt_re/
> > > +obj-$(CONFIG_INFINIBAND_ERDMA) += erdma/
> > > diff --git a/drivers/infiniband/hw/erdma/Kconfig b/drivers/infiniband/hw/erdma/Kconfig
> > > new file mode 100644
> > > index 000000000000..c90f2be1ea63
> > > +++ b/drivers/infiniband/hw/erdma/Kconfig
> > > @@ -0,0 +1,12 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only
> > > +config INFINIBAND_ERDMA
> > > + tristate "Alibaba Elastic RDMA Adapter (ERDMA) support"
> > > + depends on PCI_MSI && 64BIT && !CPU_BIG_ENDIAN
> >
> > Why !CPU_BIG_ENDIAN? That is usually not OK.
>
> we want use !CPU_BIG_ENDIAN to disable the erdma compilation on big
> endian machine
Do not copy this
> because we only have little endian machines, and don't support big
> endian machines. I have no idea why it is usually not OK, could you
> explain it any more?
It is considered bad coding practice in the kernel. Write the required endian
swaps.
Jason
next prev parent reply other threads:[~2022-05-16 14:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 7:17 [PATCH for-next v7 00/12] Elastic RDMA Adapter (ERDMA) driver Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 01/12] RDMA: Add ERDMA to rdma_driver_id definition Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 02/12] RDMA/core: Allow calling query_port when netdev isn't attached in iWarp Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 03/12] RDMA/erdma: Add the hardware related definitions Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 04/12] RDMA/erdma: Add main include file Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 05/12] RDMA/erdma: Add cmdq implementation Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 06/12] RDMA/erdma: Add event queue implementation Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 07/12] RDMA/erdma: Add verbs header file Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 08/12] RDMA/erdma: Add verbs implementation Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 09/12] RDMA/erdma: Add connection management (CM) support Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 10/12] RDMA/erdma: Add the erdma module Cheng Xu
2022-05-10 13:17 ` Jason Gunthorpe
2022-05-16 3:15 ` Cheng Xu
2022-05-16 11:49 ` Jason Gunthorpe
2022-05-16 12:37 ` Cheng Xu
2022-05-16 12:40 ` Cheng Xu
2022-05-16 13:59 ` Cheng Xu
2022-05-16 14:07 ` Jason Gunthorpe
2022-05-16 15:14 ` Cheng Xu
2022-05-16 17:31 ` Jason Gunthorpe
2022-05-17 1:53 ` Cheng Xu
2022-05-18 8:30 ` Cheng Xu
2022-05-18 14:46 ` Jason Gunthorpe
2022-05-18 16:24 ` Cheng Xu
2022-05-18 16:31 ` Jason Gunthorpe
2022-05-19 16:20 ` Bernard Metzler
2022-05-19 18:51 ` Tom Talpey
2022-05-20 7:03 ` Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 11/12] RDMA/erdma: Add the ABI definitions Cheng Xu
2022-04-21 7:17 ` [PATCH for-next v7 12/12] RDMA/erdma: Add driver to kernel build environment Cheng Xu
2022-05-10 13:18 ` Jason Gunthorpe
2022-05-16 3:40 ` Cheng Xu
2022-05-16 7:11 ` Cheng Xu
2022-05-16 10:07 ` Cheng Xu
2022-05-16 14:13 ` Jason Gunthorpe [this message]
2022-05-16 14:41 ` Cheng Xu
2022-05-10 12:50 ` [PATCH for-next v7 00/12] Elastic RDMA Adapter (ERDMA) driver Jason Gunthorpe
2022-05-16 2:30 ` Cheng Xu
2022-05-16 14:13 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516141302.GX1343366@nvidia.com \
--to=jgg@nvidia.com \
--cc=BMT@zurich.ibm.com \
--cc=KaiShen@linux.alibaba.com \
--cc=chengyou@linux.alibaba.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.