All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sireesh Kodali <sireeshkodali1@gmail.com>,
	Sibi Sankar <quic_sibis@quicinc.com>
Subject: Re: [PATCH 08/12] dt-bindings: remoteproc: qcom,smd-edge: define re-usable schema for smd-edge
Date: Mon, 16 May 2022 10:25:21 -0500	[thread overview]
Message-ID: <20220516152521.GA2672819-robh@kernel.org> (raw)
In-Reply-To: <20220512100006.99695-9-krzysztof.kozlowski@linaro.org>

On Thu, May 12, 2022 at 12:00:02PM +0200, Krzysztof Kozlowski wrote:
> 'smd-edge' property appears in multiple bindings, so split it into one
> place which can be re-used.  This reduces code duplication and strict
> schema matching for smd-edge nodes (instead of just "type:object").
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/remoteproc/qcom,adsp.yaml        |  2 +-
>  .../bindings/remoteproc/qcom,smd-edge.yaml    | 88 +++++++++++++++++++
>  .../bindings/soc/qcom/qcom,smd.yaml           | 53 +----------
>  3 files changed, 91 insertions(+), 52 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 4dfbfece1ec7..3072af5f9d79 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -148,7 +148,7 @@ properties:
>        three offsets within syscon for q6, modem and nc halt registers.
>  
>    smd-edge:
> -    type: object
> +    $ref: /schemas/remoteproc/qcom,smd-edge.yaml#
>      description:
>        Qualcomm Shared Memory subnode which represents communication edge,
>        channels and devices related to the ADSP.
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml
> new file mode 100644
> index 000000000000..fde2c450e8b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,smd-edge.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/qcom,smd-edge.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SMD Edge communication channel nodes
> +
> +maintainers:
> +  - Bjorn Andersson <bjorn.andersson@linaro.org>
> +
> +description:
> +  Qualcomm SMD subnode represents a remote subsystem or a remote processor of
> +  some sort - or in SMD language an "edge". The name of the edges are not
> +  important.
> +
> +
> +  See also Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml
> +
> +properties:
> +  $nodename:
> +    const: "smd-edge"
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  label:
> +    $ref: /schemas/types.yaml#/definitions/string

Don't need a type here. Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2022-05-16 15:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12  9:59 [PATCH 00/12] dt-bindings: remoteproc: qcom: cleanups and improvements Krzysztof Kozlowski
2022-05-12  9:59 ` [PATCH 01/12] dt-bindings: soc: qcom,wcnss: remove unneeded ref for names Krzysztof Kozlowski
2022-05-16 15:21   ` Rob Herring
2022-05-12  9:59 ` [PATCH 02/12] dt-bindings: remoteproc: " Krzysztof Kozlowski
2022-05-16 15:21   ` Rob Herring
2022-05-12  9:59 ` [PATCH 03/12] dt-bindings: remoteproc: qcom,adsp: add interconnects Krzysztof Kozlowski
2022-05-12  9:59 ` [PATCH 04/12] dt-bindings: remoteproc: qcom,adsp: simplify interrupts Krzysztof Kozlowski
2022-05-12  9:59 ` [PATCH 05/12] dt-bindings: remoteproc: qcom,adsp: simplify SM8150 power domains Krzysztof Kozlowski
2022-05-16 15:22   ` Rob Herring
2022-05-12 10:00 ` [PATCH 06/12] dt-bindings: remoteproc: qcom,adsp: use GIC_SPI defines in example Krzysztof Kozlowski
2022-05-13 12:33   ` Rob Herring
2022-05-12 10:00 ` [PATCH 07/12] dt-bindings: remoteproc: qcom,glink-edge: define re-usable schema for glink-edge Krzysztof Kozlowski
2022-05-16 15:23   ` Rob Herring
2022-05-12 10:00 ` [PATCH 08/12] dt-bindings: remoteproc: qcom,smd-edge: define re-usable schema for smd-edge Krzysztof Kozlowski
2022-05-16 15:25   ` Rob Herring [this message]
2022-05-12 10:00 ` [PATCH 09/12] arm64: dts: qcom: ipq6018: add label to remoteproc node Krzysztof Kozlowski
2022-05-12 10:00 ` [PATCH 10/12] arm64: dts: qcom: sdm630: remove unneeded address/size cells in glink-edge Krzysztof Kozlowski
2022-05-12 10:00 ` [PATCH 11/12] arm64: dts: qcom: sm8350: remove duplicated glink-edge interrupt Krzysztof Kozlowski
2022-05-12 10:00 ` [PATCH 12/12] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220516152521.GA2672819-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=quic_sibis@quicinc.com \
    --cc=sireeshkodali1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.