From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CC0C433F5 for ; Tue, 17 May 2022 03:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237938AbiEQDYY (ORCPT ); Mon, 16 May 2022 23:24:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238172AbiEQDYW (ORCPT ); Mon, 16 May 2022 23:24:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06DE946143 for ; Mon, 16 May 2022 20:24:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5A563B80D2C for ; Tue, 17 May 2022 03:24:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 703BDC385AA; Tue, 17 May 2022 03:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652757856; bh=lIb4LTEmMJ+9Fi6aXyTcRQ4qMsUp8+2ufFcwO9rQDyA=; h=From:To:Cc:Subject:Date:From; b=XGz3qNfM7GbIeXPDGPabGDbG/5klt0LpGzaUcOW+uGcFBlEcXIkSyxMpzUHMAgURA qJAbmQKwA7pYkpjmudLZ3EDx2L8TYTXfFRYBRN8qgzp0mBAvwHHYibo5LgXfrJI3W5 Kx9cQgDIa+bE3UAZlNz5YDoJONmay+Td0/SAl1vrmkpUVuww80ljj8Sysn40NCZ0pg zbf3m53xUU1RlkFt8ZSG471F97BwkBMYJCj0CvlVn0YIjpuyD8qtPJxZzroKAzCYvj 10ysxU/8xyq1E66yYRI5AUxT3sKSZu8dweEiKwAyNZTN5kOIXuGx1zmw/RzpLiUKME MEfiIO0C++3mg== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu , Chao Yu Subject: [PATCH v4] f2fs: separate NOCoW and pinfile semantics Date: Tue, 17 May 2022 11:24:10 +0800 Message-Id: <20220517032410.3564033-1-chao@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pinning a file is heavy, because skipping pinned files make GC running with heavy load or no effect. So that this patch proposes to separate nocow and pinfile semantics: - NOCoW flag can only be set on regular file. - NOCoW file will only trigger IPU at common writeback/flush. - NOCow file will do OPU during GC. This flag can satisfying the demand of: 1) avoiding fragment of file's physical block 2) userspace doesn't want to pin file's physical address After commit 5d539245cb18 ("f2fs: export FS_NOCOW_FL flag to user"), Pin_file and NOCoW flags have already been twined closely. e.g. once we set pinfile flag in file, nocow flag will be shown; and after clearing pinfile flag, nocow flag will disappear. So, in order to keep backward compatibility, let use below semantics: f2fs_ioc_set_pin_file/f2fs_fileattr_set logic: pinfile nocow set set pinfile | nocow set nocow clear clear pinfile | nocow clear nocow File Behaviors: w/ pinfile, w/ nocow: use pinfile semantics w/ pinfile, w/o nocow: use pinfile semantics w/o pinfile, w/ nocow: use nocow semantics w/o pinfile, w/o nocow: no pinfile or nocow semantics NOCoW can also be set on directory, and it will have no effect on directory, however, new files created in nocow directory will have the flag set. Signed-off-by: Chao Yu --- v4: - allow IPU only for NoCowed regular inode. fs/f2fs/data.c | 3 +++ fs/f2fs/f2fs.h | 13 +++++++++++-- fs/f2fs/file.c | 18 +++++++++++++++++- 3 files changed, 31 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 54a7a8ad994d..42d95ac6b508 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2498,6 +2498,9 @@ bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) if (f2fs_is_pinned_file(inode)) return true; + if (S_ISREG(inode->i_mode) && F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) + return true; + /* if this is cold file, we should overwrite to avoid fragmentation */ if (file_is_cold(inode)) return true; diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 492af5b96de1..5c67736000a7 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2916,13 +2916,15 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) #define F2FS_NOCOMP_FL 0x00000400 /* Don't compress */ #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ #define F2FS_CASEFOLD_FL 0x40000000 /* Casefolded file */ /* Flags that should be inherited by new inodes from their parent. */ #define F2FS_FL_INHERITED (F2FS_SYNC_FL | F2FS_NODUMP_FL | F2FS_NOATIME_FL | \ F2FS_DIRSYNC_FL | F2FS_PROJINHERIT_FL | \ - F2FS_CASEFOLD_FL | F2FS_COMPR_FL | F2FS_NOCOMP_FL) + F2FS_CASEFOLD_FL | F2FS_COMPR_FL | F2FS_NOCOMP_FL | \ + F2FS_NOCOW_FL) /* Flags that are appropriate for regular files (all but dir-specific ones). */ #define F2FS_REG_FLMASK (~(F2FS_DIRSYNC_FL | F2FS_PROJINHERIT_FL | \ @@ -2954,9 +2956,16 @@ static inline void __mark_inode_dirty_flag(struct inode *inode, fallthrough; case FI_DATA_EXIST: case FI_INLINE_DOTS: - case FI_PIN_FILE: case FI_COMPRESS_RELEASED: f2fs_mark_inode_dirty_sync(inode, true); + break; + case FI_PIN_FILE: + if (set) + F2FS_I(inode)->i_flags |= F2FS_NOCOW_FL; + else + F2FS_I(inode)->i_flags &= ~F2FS_NOCOW_FL; + f2fs_mark_inode_dirty_sync(inode, true); + break; } } diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 216081ea8c81..9e71ce8601f9 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1851,6 +1851,20 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) if (IS_NOQUOTA(inode)) return -EPERM; + if ((iflags ^ masked_flags) & F2FS_NOCOW_FL) { + int ret; + + if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode)) + return -EINVAL; + if (S_ISREG(inode->i_mode)) { + if (f2fs_should_update_outplace(inode, NULL)) + return -EINVAL; + ret = f2fs_convert_inline_inode(inode); + if (ret) + return ret; + } + } + if ((iflags ^ masked_flags) & F2FS_CASEFOLD_FL) { if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) return -EOPNOTSUPP; @@ -1926,6 +1940,7 @@ static const struct { { F2FS_NOCOMP_FL, FS_NOCOMP_FL }, { F2FS_INDEX_FL, FS_INDEX_FL }, { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, + { F2FS_NOCOW_FL, FS_NOCOW_FL }, { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, { F2FS_CASEFOLD_FL, FS_CASEFOLD_FL }, }; @@ -1957,7 +1972,8 @@ static const struct { FS_NOCOMP_FL | \ FS_DIRSYNC_FL | \ FS_PROJINHERIT_FL | \ - FS_CASEFOLD_FL) + FS_CASEFOLD_FL | \ + FS_NOCOW_FL) /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ static inline u32 f2fs_iflags_to_fsflags(u32 iflags) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AAA6C433F5 for ; Tue, 17 May 2022 03:24:30 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nqnox-0006ND-TO; Tue, 17 May 2022 03:24:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqnox-0006N7-Bm for linux-f2fs-devel@lists.sourceforge.net; Tue, 17 May 2022 03:24:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5oMl00gX5xjQyVkBkzRskjBuRT+a13k4RygNqSTrga8=; b=nAyx46dsLB/gyOhVPGr8s6I6fC ycx1aSOcvA0OHiq2zzPkWiVZun35VhPNyE1R8TW3DDnLs3lWYSM5W71/maR0S9hZ7+to20vdy1jzM 6ZB4jbIa2ioZGBgbXR+rCDUDSDAEEJamS/nhkiL+WpKieE3eU6djwyJwosYGnwR9reKI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=5oMl00gX5xjQyVkBkzRskjBuRT+a13k4RygNqSTrga8=; b=B zrtAY8MhY1aBtnbuwa9i4bYYLSxOQqHZofXalINjnysWO8gizV9alCjN7YDNGSedBzifqlb/XDkzE lkeUANad8WCzietPxzwpa7rR9yNOJjvBDJrJVb87bL8Uxy2tKXii0oK3pI9CXz4oSfrxixUD5EJTW 1dR/oUopZpF4FxNw=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nqnov-0002TQ-96 for linux-f2fs-devel@lists.sourceforge.net; Tue, 17 May 2022 03:24:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5D058B816CA; Tue, 17 May 2022 03:24:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 703BDC385AA; Tue, 17 May 2022 03:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652757856; bh=lIb4LTEmMJ+9Fi6aXyTcRQ4qMsUp8+2ufFcwO9rQDyA=; h=From:To:Cc:Subject:Date:From; b=XGz3qNfM7GbIeXPDGPabGDbG/5klt0LpGzaUcOW+uGcFBlEcXIkSyxMpzUHMAgURA qJAbmQKwA7pYkpjmudLZ3EDx2L8TYTXfFRYBRN8qgzp0mBAvwHHYibo5LgXfrJI3W5 Kx9cQgDIa+bE3UAZlNz5YDoJONmay+Td0/SAl1vrmkpUVuww80ljj8Sysn40NCZ0pg zbf3m53xUU1RlkFt8ZSG471F97BwkBMYJCj0CvlVn0YIjpuyD8qtPJxZzroKAzCYvj 10ysxU/8xyq1E66yYRI5AUxT3sKSZu8dweEiKwAyNZTN5kOIXuGx1zmw/RzpLiUKME MEfiIO0C++3mg== From: Chao Yu To: jaegeuk@kernel.org Date: Tue, 17 May 2022 11:24:10 +0800 Message-Id: <20220517032410.3564033-1-chao@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Headers-End: 1nqnov-0002TQ-96 Subject: [f2fs-dev] [PATCH v4] f2fs: separate NOCoW and pinfile semantics X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Pinning a file is heavy, because skipping pinned files make GC running with heavy load or no effect. So that this patch proposes to separate nocow and pinfile semantics: - NOCoW flag can only be set on regular file. - NOCoW file will only trigger IPU at common writeback/flush. - NOCow file will do OPU during GC. This flag can satisfying the demand of: 1) avoiding fragment of file's physical block 2) userspace doesn't want to pin file's physical address After commit 5d539245cb18 ("f2fs: export FS_NOCOW_FL flag to user"), Pin_file and NOCoW flags have already been twined closely. e.g. once we set pinfile flag in file, nocow flag will be shown; and after clearing pinfile flag, nocow flag will disappear. So, in order to keep backward compatibility, let use below semantics: f2fs_ioc_set_pin_file/f2fs_fileattr_set logic: pinfile nocow set set pinfile | nocow set nocow clear clear pinfile | nocow clear nocow File Behaviors: w/ pinfile, w/ nocow: use pinfile semantics w/ pinfile, w/o nocow: use pinfile semantics w/o pinfile, w/ nocow: use nocow semantics w/o pinfile, w/o nocow: no pinfile or nocow semantics NOCoW can also be set on directory, and it will have no effect on directory, however, new files created in nocow directory will have the flag set. Signed-off-by: Chao Yu --- v4: - allow IPU only for NoCowed regular inode. fs/f2fs/data.c | 3 +++ fs/f2fs/f2fs.h | 13 +++++++++++-- fs/f2fs/file.c | 18 +++++++++++++++++- 3 files changed, 31 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 54a7a8ad994d..42d95ac6b508 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2498,6 +2498,9 @@ bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) if (f2fs_is_pinned_file(inode)) return true; + if (S_ISREG(inode->i_mode) && F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) + return true; + /* if this is cold file, we should overwrite to avoid fragmentation */ if (file_is_cold(inode)) return true; diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 492af5b96de1..5c67736000a7 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -2916,13 +2916,15 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) #define F2FS_NOCOMP_FL 0x00000400 /* Don't compress */ #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ #define F2FS_CASEFOLD_FL 0x40000000 /* Casefolded file */ /* Flags that should be inherited by new inodes from their parent. */ #define F2FS_FL_INHERITED (F2FS_SYNC_FL | F2FS_NODUMP_FL | F2FS_NOATIME_FL | \ F2FS_DIRSYNC_FL | F2FS_PROJINHERIT_FL | \ - F2FS_CASEFOLD_FL | F2FS_COMPR_FL | F2FS_NOCOMP_FL) + F2FS_CASEFOLD_FL | F2FS_COMPR_FL | F2FS_NOCOMP_FL | \ + F2FS_NOCOW_FL) /* Flags that are appropriate for regular files (all but dir-specific ones). */ #define F2FS_REG_FLMASK (~(F2FS_DIRSYNC_FL | F2FS_PROJINHERIT_FL | \ @@ -2954,9 +2956,16 @@ static inline void __mark_inode_dirty_flag(struct inode *inode, fallthrough; case FI_DATA_EXIST: case FI_INLINE_DOTS: - case FI_PIN_FILE: case FI_COMPRESS_RELEASED: f2fs_mark_inode_dirty_sync(inode, true); + break; + case FI_PIN_FILE: + if (set) + F2FS_I(inode)->i_flags |= F2FS_NOCOW_FL; + else + F2FS_I(inode)->i_flags &= ~F2FS_NOCOW_FL; + f2fs_mark_inode_dirty_sync(inode, true); + break; } } diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 216081ea8c81..9e71ce8601f9 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1851,6 +1851,20 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) if (IS_NOQUOTA(inode)) return -EPERM; + if ((iflags ^ masked_flags) & F2FS_NOCOW_FL) { + int ret; + + if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode)) + return -EINVAL; + if (S_ISREG(inode->i_mode)) { + if (f2fs_should_update_outplace(inode, NULL)) + return -EINVAL; + ret = f2fs_convert_inline_inode(inode); + if (ret) + return ret; + } + } + if ((iflags ^ masked_flags) & F2FS_CASEFOLD_FL) { if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) return -EOPNOTSUPP; @@ -1926,6 +1940,7 @@ static const struct { { F2FS_NOCOMP_FL, FS_NOCOMP_FL }, { F2FS_INDEX_FL, FS_INDEX_FL }, { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, + { F2FS_NOCOW_FL, FS_NOCOW_FL }, { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, { F2FS_CASEFOLD_FL, FS_CASEFOLD_FL }, }; @@ -1957,7 +1972,8 @@ static const struct { FS_NOCOMP_FL | \ FS_DIRSYNC_FL | \ FS_PROJINHERIT_FL | \ - FS_CASEFOLD_FL) + FS_CASEFOLD_FL | \ + FS_NOCOW_FL) /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ static inline u32 f2fs_iflags_to_fsflags(u32 iflags) -- 2.25.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel