From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D85C433EF for ; Tue, 17 May 2022 05:51:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238083AbiEQFvi (ORCPT ); Tue, 17 May 2022 01:51:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230378AbiEQFve (ORCPT ); Tue, 17 May 2022 01:51:34 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FAE73DDD7; Mon, 16 May 2022 22:51:32 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id q7so5025957plx.3; Mon, 16 May 2022 22:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PwvzoeY6N9lJ4fKAAqEsuvjxiVm8EwN2t9yaRifsIoc=; b=IuBnJZko7z+mYQOiTfa5mrvWE04qWHy4+1eddt0J8qUj59+sfA03udQJQaX96+iHcv P1b5J/dplK6ghbqW3+VYgAsom2M9WheUcYvCSBzKpma5XPVT7lQ7nN3VuepLGQjF0B5y QDMGNvGh9NL1zl2VLOh0sTuwdtZaWxFOJguydVyW16KT3u64ydyNqSDC1bThTMCmdJ0D Z7dKNY5vIX8r74SWTZFAbOYFpGe/az/8Hvux2nMiguucbyfEo5PXp6LUp3nWGTy4ZDjC egLg7TIXkbtTl2/ll5yQBWDt85HWHB/cZIZ5RPYn6De6UZXFmUR6p0kegLlsDLYNBFvO /k2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PwvzoeY6N9lJ4fKAAqEsuvjxiVm8EwN2t9yaRifsIoc=; b=OJKTbS1ulOoe56j0x09UpPuBxkxaDGNESeC3I2iIjec5IALqExNCPKpD3kahBQyIM6 xS4XrlrU5X391FPpiVxLUM6OZqVh0dWXfA8PuxID4711txteP95kOFlMO7QkHRsOEykG O0xVb4CcyFcnEXT+G6XKn/iyJG1tRtw7CtIxiIEaS8b/KyzoLNr2i9l65cbq1MbS/qst W/7jZJbCkm506tQGocjNZXc23DpCupZeUGtuyhPc/ouiMeaBHh3Cd9rQ5qpqtcksizsA XbqpJOoA5UwPF1cjZgFKRMc+4m/AAVgAl1eVi35j3m8/OI41j1JcaQ09ofHGI2voYvm/ kAzg== X-Gm-Message-State: AOAM531ORLhZFLvOCOdQnY+7/dWQijc1P6g+C1OcTUG9fOav42QsToXZ w0213oh1tWotm92TiYflWsg= X-Google-Smtp-Source: ABdhPJxUvQzeLnS5fgfw4sRQZ85fmjGNSpwRzd4pl8qtvQDNTT/6Z3W8r7fBlzshAsesUF1CgWechA== X-Received: by 2002:a17:902:eccd:b0:161:9e20:1a14 with SMTP id a13-20020a170902eccd00b001619e201a14mr3566936plh.43.1652766691934; Mon, 16 May 2022 22:51:31 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id c7-20020a62f847000000b0050dc76281f7sm7825217pfm.209.2022.05.16.22.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 22:51:31 -0700 (PDT) From: Miaoqian Lin To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH v2] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe Date: Tue, 17 May 2022 09:51:21 +0400 Message-Id: <20220517055121.18092-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_find_node_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support") Signed-off-by: Miaoqian Lin --- changes in v2: - use goto statement, also move of_node_put(sensor_np) to goto label v1 Link: https://lore.kernel.org/all/20220516073151.25918-1-linmq006@gmail.com/ --- drivers/thermal/imx_sc_thermal.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c index 8d76dbfde6a9..331a241eb0ef 100644 --- a/drivers/thermal/imx_sc_thermal.c +++ b/drivers/thermal/imx_sc_thermal.c @@ -94,8 +94,8 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL); if (!sensor) { of_node_put(child); - of_node_put(sensor_np); - return -ENOMEM; + ret = -ENOMEM; + goto put_node; } ret = thermal_zone_of_get_sensor_id(child, @@ -124,7 +124,9 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n"); } +put_node: of_node_put(sensor_np); + of_node_put(np); return ret; } -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C056C433F5 for ; Tue, 17 May 2022 05:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=phMuaOeFirXa80GdgyCjIoVkouKiRGrCPObBxjxmbvE=; b=Db97y27LWRcTWL wBNp1uxy+DQmwlYgdrpy0DORjgdCUN6cQDR+IBoVDD9Rf2feOPFP7GPARD9yg8i/AxNcGTgo/W8kx NauNb6HgRnUQh40JvNSt0kKaQm5claBAFT7DMfwHrEsG7egHe6AQ1bZ1swWc9ddj466Ra6QgzF7zC x1nyP8wN9pLTIsApE6e6Of2AFFsCqJsHkTZFYqdAy4lZyCVShsIYOU56Cu78ewdHG56lExSHK33Gp 8hQ/t+3Qsz3qbkXR1jv7RuJDz2WUZL7VNSsNmvbn+klKGognZ5CClx6l84J6iG2lySNKoD6FqG4vE JzO+YtDwIAFnXAYNbksg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqq7Q-00Bjqj-MF; Tue, 17 May 2022 05:51:40 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqq7M-00BjpP-V0 for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 05:51:38 +0000 Received: by mail-pl1-x632.google.com with SMTP id n8so16444230plh.1 for ; Mon, 16 May 2022 22:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PwvzoeY6N9lJ4fKAAqEsuvjxiVm8EwN2t9yaRifsIoc=; b=IuBnJZko7z+mYQOiTfa5mrvWE04qWHy4+1eddt0J8qUj59+sfA03udQJQaX96+iHcv P1b5J/dplK6ghbqW3+VYgAsom2M9WheUcYvCSBzKpma5XPVT7lQ7nN3VuepLGQjF0B5y QDMGNvGh9NL1zl2VLOh0sTuwdtZaWxFOJguydVyW16KT3u64ydyNqSDC1bThTMCmdJ0D Z7dKNY5vIX8r74SWTZFAbOYFpGe/az/8Hvux2nMiguucbyfEo5PXp6LUp3nWGTy4ZDjC egLg7TIXkbtTl2/ll5yQBWDt85HWHB/cZIZ5RPYn6De6UZXFmUR6p0kegLlsDLYNBFvO /k2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PwvzoeY6N9lJ4fKAAqEsuvjxiVm8EwN2t9yaRifsIoc=; b=6CLLPCFSlJuPM+cK6QeH18K8fxmDFbVMgcQ7S/uDOL9XflehckFORQDpscKGdOWwN4 IdIDsgbcIw5GHMXPfng+Y2QpLU3+awvXNtP1gb3P6aELDzkzRyshNCHDnQEvJXIqdsT5 YbqxdRIwznHgvLC7+cwHISoAotBbo4cHCvzeuR4U+gtlYSdbFIy5CJxayqYb2diSWiAL 6zvtHHj/pEd+Y8kko1pYF/PRCLXW+5VmQwaWkeZNlKS6IlQx1c8Cuc28h8JPS9zzSqto oR5hJC5Cexu9aG+NgfUjSWppgjVkoSshl72j4YIM8ZY/6ebZlXWotZlXev49kTGwfyHt r+EQ== X-Gm-Message-State: AOAM530spYZhmI6UorV8xVSt+lMeg5a1ZnKsQUKlKXUNzPS7/pkEVsJD 8iHJPlpyyMNM5EUwJZwAHbQ= X-Google-Smtp-Source: ABdhPJxUvQzeLnS5fgfw4sRQZ85fmjGNSpwRzd4pl8qtvQDNTT/6Z3W8r7fBlzshAsesUF1CgWechA== X-Received: by 2002:a17:902:eccd:b0:161:9e20:1a14 with SMTP id a13-20020a170902eccd00b001619e201a14mr3566936plh.43.1652766691934; Mon, 16 May 2022 22:51:31 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id c7-20020a62f847000000b0050dc76281f7sm7825217pfm.209.2022.05.16.22.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 22:51:31 -0700 (PDT) From: Miaoqian Lin To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH v2] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe Date: Tue, 17 May 2022 09:51:21 +0400 Message-Id: <20220517055121.18092-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_225137_056607_3C75F61B X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support") Signed-off-by: Miaoqian Lin --- changes in v2: - use goto statement, also move of_node_put(sensor_np) to goto label v1 Link: https://lore.kernel.org/all/20220516073151.25918-1-linmq006@gmail.com/ --- drivers/thermal/imx_sc_thermal.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c index 8d76dbfde6a9..331a241eb0ef 100644 --- a/drivers/thermal/imx_sc_thermal.c +++ b/drivers/thermal/imx_sc_thermal.c @@ -94,8 +94,8 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL); if (!sensor) { of_node_put(child); - of_node_put(sensor_np); - return -ENOMEM; + ret = -ENOMEM; + goto put_node; } ret = thermal_zone_of_get_sensor_id(child, @@ -124,7 +124,9 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n"); } +put_node: of_node_put(sensor_np); + of_node_put(np); return ret; } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel