From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D0ACC433EF for ; Tue, 17 May 2022 07:09:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234402AbiEQHJr (ORCPT ); Tue, 17 May 2022 03:09:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241325AbiEQHJe (ORCPT ); Tue, 17 May 2022 03:09:34 -0400 X-Greylist: delayed 913 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 17 May 2022 00:09:14 PDT Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D306F48332; Tue, 17 May 2022 00:09:14 -0700 (PDT) Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 8051A4000B; Tue, 17 May 2022 07:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1652771353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6uz66M6HKOhBBcFLOcI2X/Dc3dQ8CXRWUl8K+WprspY=; b=cxSTVJUfdqK5sCWJtLbD+UkKCzrUy+aXziA5PrVkA7TvObO+wasqxf2s7rtRjg84pkqa0g E3xICkblItbWMeOAeOhwDYp+Lnd/LylzPQbyTnQ0+V5snjqtjLswDInmtW5ZUWR2gVwr2v TtzfWKum36PG9gMOaKg/1skpGpQBTmBVQL09vx+q5l/tGF8NAh8XzmGLEc1Pueof//jrEo ZsTpt0ReJX7cvSf1zhLFMq7d/5+mmshE9DNuwgFUr5oPlKQGcdG7vTrS4K9osp0Mrn8NnA ZdmsLihzujnwLpOSnX0Ko2uq80GShHUMzwya0A3wiu7c55bLGoczSTF5huSwhg== Date: Tue, 17 May 2022 09:09:10 +0200 From: Maxime Chevallier To: "Russell King (Oracle)" Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v2 1/5] net: ipqess: introduce the Qualcomm IPQESS driver Message-ID: <20220517090910.7e1344ca@pc-20.home> In-Reply-To: References: <20220514150656.122108-1-maxime.chevallier@bootlin.com> <20220514150656.122108-2-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Russell, Thanks for the review. On Sat, 14 May 2022 18:18:17 +0100 "Russell King (Oracle)" wrote: > On Sat, May 14, 2022 at 05:06:52PM +0200, Maxime Chevallier wrote: > > +static int ipqess_do_ioctl(struct net_device *netdev, struct ifreq > > *ifr, int cmd) +{ > > + struct ipqess *ess = netdev_priv(netdev); > > + > > + switch (cmd) { > > + case SIOCGMIIPHY: > > + case SIOCGMIIREG: > > + case SIOCSMIIREG: > > + return phylink_mii_ioctl(ess->phylink, ifr, cmd); > > + default: > > + break; > > + } > > + > > + return -EOPNOTSUPP; > > +} > > Is there a reason this isn't just: > > return phylink_mii_ioctl(ess->phylink, ifr, cmd); Not really, an oversight on my part, I'll address that in v3 > ? > > > +static int ipqess_axi_probe(struct platform_device *pdev) > > +{ > > + struct device_node *np = pdev->dev.of_node; > > + struct net_device *netdev; > > + phy_interface_t phy_mode; > > + struct resource *res; > > + struct ipqess *ess; > > + int i, err = 0; > > + > > + netdev = devm_alloc_etherdev_mqs(&pdev->dev, sizeof(struct > > ipqess), > > + IPQESS_NETDEV_QUEUES, > > + IPQESS_NETDEV_QUEUES); > > + if (!netdev) > > + return -ENOMEM; > > + > > + ess = netdev_priv(netdev); > > + ess->netdev = netdev; > > + ess->pdev = pdev; > > + spin_lock_init(&ess->stats_lock); > > + SET_NETDEV_DEV(netdev, &pdev->dev); > > + platform_set_drvdata(pdev, netdev); > > + > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + ess->hw_addr = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(ess->hw_addr)) > > + return PTR_ERR(ess->hw_addr); > > + > > + err = of_get_phy_mode(np, &phy_mode); > > + if (err) { > > + dev_err(&pdev->dev, "incorrect phy-mode\n"); > > + return err; > > + } > > + > > + ess->ess_clk = devm_clk_get(&pdev->dev, "ess"); > > + if (!IS_ERR(ess->ess_clk)) > > + clk_prepare_enable(ess->ess_clk); > > + > > + ess->ess_rst = devm_reset_control_get(&pdev->dev, "ess"); > > + if (IS_ERR(ess->ess_rst)) > > + goto err_clk; > > + > > + ipqess_reset(ess); > > + > > + ess->phylink_config.dev = &netdev->dev; > > + ess->phylink_config.type = PHYLINK_NETDEV; > > + > > + __set_bit(PHY_INTERFACE_MODE_INTERNAL, > > + ess->phylink_config.supported_interfaces); > > No mac capabilities? My bad too, I also missed that. I'll also address that in v3. > > + > > + ess->phylink = phylink_create(&ess->phylink_config, > > + of_fwnode_handle(np), > > phy_mode, > > + &ipqess_phylink_mac_ops); > Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D76D5C433F5 for ; Tue, 17 May 2022 07:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CX8zDXSIb1Cmu6pQqYq084HNpeNEuyktJiOxuYjv4Bw=; b=wWoWW6jX52LzJA gCcKsp0u8QM269NoylokPRsseBsTxMORCe4p1rcki4MyUjto8wOjXotc8nmapSRvYnbtEHjzeD1XE ZZp4uyApVNlTcW93ozX9cjzhk4+YrNMPr1A8Xd8rys7I5KUqA+UbIhnhI/o/C/2nPXcuIapLnpW8T kFEuLIEmVj+PcnQUbDaN6iwqH/3DUUFbLcbY+2HfPZztwoQ2EWvy4K44G8ttBHZzN/DWJQIQuPjIZ gPtU0FHbej+qyVjhai0EyNPZrwGgMAH4lDmzCATvU4gaKJxok2IQRARyaitY/GjZfYf32lzgr8wQU c++auOiq5fUZ6EOeMZdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqrLY-00C1ei-3o; Tue, 17 May 2022 07:10:20 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqrKX-00C152-6w for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 07:09:19 +0000 Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 8051A4000B; Tue, 17 May 2022 07:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1652771353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6uz66M6HKOhBBcFLOcI2X/Dc3dQ8CXRWUl8K+WprspY=; b=cxSTVJUfdqK5sCWJtLbD+UkKCzrUy+aXziA5PrVkA7TvObO+wasqxf2s7rtRjg84pkqa0g E3xICkblItbWMeOAeOhwDYp+Lnd/LylzPQbyTnQ0+V5snjqtjLswDInmtW5ZUWR2gVwr2v TtzfWKum36PG9gMOaKg/1skpGpQBTmBVQL09vx+q5l/tGF8NAh8XzmGLEc1Pueof//jrEo ZsTpt0ReJX7cvSf1zhLFMq7d/5+mmshE9DNuwgFUr5oPlKQGcdG7vTrS4K9osp0Mrn8NnA ZdmsLihzujnwLpOSnX0Ko2uq80GShHUMzwya0A3wiu7c55bLGoczSTF5huSwhg== Date: Tue, 17 May 2022 09:09:10 +0200 From: Maxime Chevallier To: "Russell King (Oracle)" Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v2 1/5] net: ipqess: introduce the Qualcomm IPQESS driver Message-ID: <20220517090910.7e1344ca@pc-20.home> In-Reply-To: References: <20220514150656.122108-1-maxime.chevallier@bootlin.com> <20220514150656.122108-2-maxime.chevallier@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_000917_635535_912820F2 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Russell, Thanks for the review. On Sat, 14 May 2022 18:18:17 +0100 "Russell King (Oracle)" wrote: > On Sat, May 14, 2022 at 05:06:52PM +0200, Maxime Chevallier wrote: > > +static int ipqess_do_ioctl(struct net_device *netdev, struct ifreq > > *ifr, int cmd) +{ > > + struct ipqess *ess = netdev_priv(netdev); > > + > > + switch (cmd) { > > + case SIOCGMIIPHY: > > + case SIOCGMIIREG: > > + case SIOCSMIIREG: > > + return phylink_mii_ioctl(ess->phylink, ifr, cmd); > > + default: > > + break; > > + } > > + > > + return -EOPNOTSUPP; > > +} > > Is there a reason this isn't just: > > return phylink_mii_ioctl(ess->phylink, ifr, cmd); Not really, an oversight on my part, I'll address that in v3 > ? > > > +static int ipqess_axi_probe(struct platform_device *pdev) > > +{ > > + struct device_node *np = pdev->dev.of_node; > > + struct net_device *netdev; > > + phy_interface_t phy_mode; > > + struct resource *res; > > + struct ipqess *ess; > > + int i, err = 0; > > + > > + netdev = devm_alloc_etherdev_mqs(&pdev->dev, sizeof(struct > > ipqess), > > + IPQESS_NETDEV_QUEUES, > > + IPQESS_NETDEV_QUEUES); > > + if (!netdev) > > + return -ENOMEM; > > + > > + ess = netdev_priv(netdev); > > + ess->netdev = netdev; > > + ess->pdev = pdev; > > + spin_lock_init(&ess->stats_lock); > > + SET_NETDEV_DEV(netdev, &pdev->dev); > > + platform_set_drvdata(pdev, netdev); > > + > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + ess->hw_addr = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(ess->hw_addr)) > > + return PTR_ERR(ess->hw_addr); > > + > > + err = of_get_phy_mode(np, &phy_mode); > > + if (err) { > > + dev_err(&pdev->dev, "incorrect phy-mode\n"); > > + return err; > > + } > > + > > + ess->ess_clk = devm_clk_get(&pdev->dev, "ess"); > > + if (!IS_ERR(ess->ess_clk)) > > + clk_prepare_enable(ess->ess_clk); > > + > > + ess->ess_rst = devm_reset_control_get(&pdev->dev, "ess"); > > + if (IS_ERR(ess->ess_rst)) > > + goto err_clk; > > + > > + ipqess_reset(ess); > > + > > + ess->phylink_config.dev = &netdev->dev; > > + ess->phylink_config.type = PHYLINK_NETDEV; > > + > > + __set_bit(PHY_INTERFACE_MODE_INTERNAL, > > + ess->phylink_config.supported_interfaces); > > No mac capabilities? My bad too, I also missed that. I'll also address that in v3. > > + > > + ess->phylink = phylink_create(&ess->phylink_config, > > + of_fwnode_handle(np), > > phy_mode, > > + &ipqess_phylink_mac_ops); > Thanks, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel