From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E2BC433EF for ; Tue, 17 May 2022 12:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346488AbiEQMyw (ORCPT ); Tue, 17 May 2022 08:54:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346765AbiEQMyi (ORCPT ); Tue, 17 May 2022 08:54:38 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B3B4D9D8 for ; Tue, 17 May 2022 05:54:13 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id fw21-20020a17090b129500b001df9f62edd6so220711pjb.0 for ; Tue, 17 May 2022 05:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tjiV1xKHbPTP8VkdWgv75f9elF2yNt/M/Hgxyubwsvs=; b=jJAeyDDGVYAM6anJp5eoX+Bdo0+J99EROle8FXnCYomSg/lbrcKJLLjd6hcvwzDvUm 6zr4/avmcBBW6EM5X3wFV/U9Ynp8o4RUuago9cZIMUpj55YnxmTwlBg3M+h97wI0fOiW 49eJ9lwL8F26LCUDhVAeljV8Hs6OWpTO/V3DqQv1co1K45gP1DEyjY4J8OIac6KE3CY+ /KjuLFXew+595Z8SpuJCTvFRgpYCLioPegnwmdHFMe8E8DcQGmo9mfKH2xHfuWJ4LNFn 2BAwRhWXavX2UiGRAsGVfYBH2NLdqOAgqwTokZNJjG5RkOtC6E7gJuy4CpCBcNCc3NLg IQdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tjiV1xKHbPTP8VkdWgv75f9elF2yNt/M/Hgxyubwsvs=; b=N/PSD0X8xJD4Nd72PkZkBTyoYWGQkJ0mIuqCWEco/rc1aoiKBHnI3JMqZTY8yK8L15 /pvXxOKchq0T39o0AMZ7npNUPphuPFVwDPUl9h1qyeIcBnh4GW1rtfoMChgoZti93idx OkjorqZdY+4eeYqzUmX9qD7iJxrk+T2+qlEjJ37/Cp+JfqRzp+nQOldAO0GhXVOF9IXi Kcr+HdNkvyWG2/acgSS2J47mkUnGT/iNpukfx/MVj1UoWDjKZwumF5qSqdN3pYqrhbgI fjlm7MYxVuX8gEHLAdpq3Lr4GrkSHJL5yGX7cSlyp04+qEYlx9RRGxElQgdxxF6lwxbz JwlQ== X-Gm-Message-State: AOAM532a9L+gsDTUbQqQm+Fgl6y5h/msSqc7T2CtVWkp7i3cGBexGbie Y/MI8Asgw15uTGI+KVQCFAagpA== X-Google-Smtp-Source: ABdhPJyipCIyJ38tRbhMT94MHL3O0NMmglFB3vvh77tC+0eyDQ2a4pEKSzIHKnqG3HbX+LeUaMee2g== X-Received: by 2002:a17:90b:1a8b:b0:1dc:e565:3238 with SMTP id ng11-20020a17090b1a8b00b001dce5653238mr24998790pjb.64.1652792052892; Tue, 17 May 2022 05:54:12 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([46.249.98.195]) by smtp.gmail.com with ESMTPSA id gt13-20020a17090af2cd00b001df4b919937sm1598571pjb.16.2022.05.17.05.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 05:54:12 -0700 (PDT) Date: Tue, 17 May 2022 20:54:04 +0800 From: Leo Yan To: James Clark Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, acme@kernel.org, german.gomez@arm.com, mathieu.poirier@linaro.org, john.garry@huawei.com, Will Deacon , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] perf tools: arm64: Decouple Libunwind register names from Perf Message-ID: <20220517125404.GD153558@leoy-ThinkPad-X240s> References: <20220517102005.3022017-1-james.clark@arm.com> <20220517102005.3022017-4-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517102005.3022017-4-james.clark@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2022 at 11:20:04AM +0100, James Clark wrote: > Dwarf register numbers and real register numbers on aarch64 are > equivalent. Remove the references to the register names from > Libunwind so that new registers are supported without having to > add build time feature checks for each new register. > > The unwinder won't ask for a register that it doesn't know about > and Perf will already report an error for an unknown or unrecorded > register in the perf_reg_value() function so extra validation > isn't needed. > > After this change the new VG register can be read by libunwind. > > Signed-off-by: James Clark Looks good to me: Reviewed-by: Leo Yan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7825DC433F5 for ; Tue, 17 May 2022 12:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x0+Pfg4HUvB4Tg3vWSyX6day85pN64ZneUV5bEf1lLg=; b=1op2hto1tfCxLp deSG+UqxtffJc+EbPvT+MdtGk70fzRlcGDvZzlqjECmeTAgbpUbrzoIqYEzY8pUrRwlA4P2nUDS46 zYsiSE9K9yyODSBBaEWt/JSfGjzdgSTyM/axOUpMilj94FGe5qLBcLs6Aj1VWbqCUVBtN3NiryJF3 sbfgKkk9DUmNphsIrcQA5yS+8QIW+9n9aNynEbpBdcIgxei01luQZGD+ARw4O/5dohCyO/tBkwF4Y +kdo2GY7qEI9OykUnFAP0dDSALdnz+/yDK32TWYXgAsvR1UX0zWKuGAw9Ql82AliRFjR4/dxAyjyf i3u1Gf0JjUGf36PcOA9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqwiR-00DhRi-FD; Tue, 17 May 2022 12:54:19 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqwiN-00DhPv-RO for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 12:54:17 +0000 Received: by mail-pj1-x102b.google.com with SMTP id qe3-20020a17090b4f8300b001dc24e4da73so1794893pjb.1 for ; Tue, 17 May 2022 05:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tjiV1xKHbPTP8VkdWgv75f9elF2yNt/M/Hgxyubwsvs=; b=jJAeyDDGVYAM6anJp5eoX+Bdo0+J99EROle8FXnCYomSg/lbrcKJLLjd6hcvwzDvUm 6zr4/avmcBBW6EM5X3wFV/U9Ynp8o4RUuago9cZIMUpj55YnxmTwlBg3M+h97wI0fOiW 49eJ9lwL8F26LCUDhVAeljV8Hs6OWpTO/V3DqQv1co1K45gP1DEyjY4J8OIac6KE3CY+ /KjuLFXew+595Z8SpuJCTvFRgpYCLioPegnwmdHFMe8E8DcQGmo9mfKH2xHfuWJ4LNFn 2BAwRhWXavX2UiGRAsGVfYBH2NLdqOAgqwTokZNJjG5RkOtC6E7gJuy4CpCBcNCc3NLg IQdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tjiV1xKHbPTP8VkdWgv75f9elF2yNt/M/Hgxyubwsvs=; b=V2mzxae2u8ELNZWeSz/DaxSbxHTDCDh9/Aq+LuKv9w8gqeRrgqREtHGgTm3G96YAq4 L+gDngtywqUfYUpJ9IQ0kJV9Lu5Zxwnf6YWQlRH9h8X1HqJKDAOZ3UbPzwcLGDS1yBT/ 77TIGwE31cU7zvmsniRAfB3xUjTRSzN3dQF0uRQ+Cr8EP/ZlnajipbzGYn9CIZ0/u8BZ yEf+2PdEykIU4jMwYT4+ne54O9TSMwkhsWtiCAfZDzKydNCUY/6a7hrHimcXgX3Lg138 z+YlDtVha1Tv2vzpIAt3HxPGE4qnaX1rLQCwTYDijo7mVpraj301w4kWkdU1G9BrOmku F2ow== X-Gm-Message-State: AOAM531Tc5gsPBqrLv0KOBSJ697RV0xKtJdJfYYRHgKA4zSxWeSdygDF O8gO9vjJYVZ2SC5eYq6mIiDIDQ== X-Google-Smtp-Source: ABdhPJyipCIyJ38tRbhMT94MHL3O0NMmglFB3vvh77tC+0eyDQ2a4pEKSzIHKnqG3HbX+LeUaMee2g== X-Received: by 2002:a17:90b:1a8b:b0:1dc:e565:3238 with SMTP id ng11-20020a17090b1a8b00b001dce5653238mr24998790pjb.64.1652792052892; Tue, 17 May 2022 05:54:12 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([46.249.98.195]) by smtp.gmail.com with ESMTPSA id gt13-20020a17090af2cd00b001df4b919937sm1598571pjb.16.2022.05.17.05.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 05:54:12 -0700 (PDT) Date: Tue, 17 May 2022 20:54:04 +0800 From: Leo Yan To: James Clark Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, broonie@kernel.org, acme@kernel.org, german.gomez@arm.com, mathieu.poirier@linaro.org, john.garry@huawei.com, Will Deacon , Mike Leach , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] perf tools: arm64: Decouple Libunwind register names from Perf Message-ID: <20220517125404.GD153558@leoy-ThinkPad-X240s> References: <20220517102005.3022017-1-james.clark@arm.com> <20220517102005.3022017-4-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220517102005.3022017-4-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_055415_932950_0AA647FF X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 17, 2022 at 11:20:04AM +0100, James Clark wrote: > Dwarf register numbers and real register numbers on aarch64 are > equivalent. Remove the references to the register names from > Libunwind so that new registers are supported without having to > add build time feature checks for each new register. > > The unwinder won't ask for a register that it doesn't know about > and Perf will already report an error for an unknown or unrecorded > register in the perf_reg_value() function so extra validation > isn't needed. > > After this change the new VG register can be read by libunwind. > > Signed-off-by: James Clark Looks good to me: Reviewed-by: Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel