From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BB1DC433EF for ; Tue, 17 May 2022 20:58:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353078AbiEQU6o (ORCPT ); Tue, 17 May 2022 16:58:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241513AbiEQU6k (ORCPT ); Tue, 17 May 2022 16:58:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6504B51E66; Tue, 17 May 2022 13:58:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED02B61717; Tue, 17 May 2022 20:58:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C92B5C385B8; Tue, 17 May 2022 20:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652821118; bh=hk8wEywVJmfG82zsYPnxL52HFBZTcO/cUlqMVKyBPi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sqj24rsApE0TJ0U5E3nf6VNL0L/hLBs2UcaDGbyM4ljPEg/RFHnOWqFthu5E/ovwA QbiS9ODJVY7kRGpEFyk9ePkW/GqCMxyWT/jGCfhZjB9BZVUJSYXWXx2hFPdrieyzwU 3ErbcTokULnq2qn6NES38rFPRzVaFeUrFLQsSgSuXdjt7sV+8IHl/mnE3PAgtq2GKz kMCIBH0wElXRNv9tggAbtRS10Wf5HUTEAvFd9e36Ra9tT1wFU0ARJRqaEstmK6vLTD MEbfJ1lw3maaFDHG5wmC9BnWyLkGRWrv3yG++N+J+ijHVjqddC0qrxw/a0EmbIvlDO B038KW11jZ/qg== Date: Tue, 17 May 2022 13:58:36 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v2 2/5] net: dsa: add out-of-band tagging protocol Message-ID: <20220517135836.4455e77b@kernel.org> In-Reply-To: <20220517085355.4fab54b3@pc-20.home> References: <20220514150656.122108-1-maxime.chevallier@bootlin.com> <20220514150656.122108-3-maxime.chevallier@bootlin.com> <20220516122048.70e238a2@kernel.org> <20220517085355.4fab54b3@pc-20.home> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 May 2022 08:53:55 +0200 Maxime Chevallier wrote: > > This must had been asked on v1 but there's no trace of it in the > > current submission afaict... > > No you're correct, this wasn't explained. > > > If the tag is passed in the descriptor how is this not a pure > > switchdev driver? The explanation must be preserved somehow. > > The main reason is that although the MAC and switch are rightly coupled > on that platform, the switch is actually a QC8K that can live on it's > own, as an external switch. Here, it's just a slightly modified version > of this IP. > > The same goes for the MAC IP, but so far we don't support any other > platform that have the MAC as a standalone controller. As far as we can > tell, platforms that have this MAC also include a QCA8K, but the > datasheet also mentions other modes (like outputing RGMII). Got it, thanks! Please weave this justification more explicitly into the cover letter. > Is this valid to have it as a standalone ethernet driver in that > situation ? Quite possibly.. I won't pretend I've looked at the code, I defer to the reviewers :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6D63C433EF for ; Tue, 17 May 2022 20:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y4P/JnC4KWXuOwI2M2cEneZ5N1Xn4NXRF7hANL40Ue8=; b=XVW1sxk1wiShqT llqLRW7qQegg1it8IzamfvSnPUesIji0fQKo+vdy/zTahDV+hKuyh85hts7fPU8ioSWiliGLS5FRd H7sZbfesdxDAGEaA01j3akPRSPwJKYE2zMCtIhkl0MlYpF/ELGZ7jOGFunaKumSJLN4UCiLp4G/NS jPzeYWDXuXCUUI96Qj/t8GAsa6YOQsJa1zvcwOoWldBSbKdvz+KnwCPDm4qcGPXkW96D2A86WoeHs JtYaJZu9RuB02IWnoBPTxpBY3LPyQL/EBiZiboOjeHHXYfdpbNchecXff+++a4Tarq/HeFCUl4hdF yRMIUM7ydplkPqz/4L5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nr4HE-00FrQO-2r; Tue, 17 May 2022 20:58:44 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nr4HB-00FrP7-BS for linux-arm-kernel@lists.infradead.org; Tue, 17 May 2022 20:58:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E20A2616DF; Tue, 17 May 2022 20:58:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C92B5C385B8; Tue, 17 May 2022 20:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652821118; bh=hk8wEywVJmfG82zsYPnxL52HFBZTcO/cUlqMVKyBPi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sqj24rsApE0TJ0U5E3nf6VNL0L/hLBs2UcaDGbyM4ljPEg/RFHnOWqFthu5E/ovwA QbiS9ODJVY7kRGpEFyk9ePkW/GqCMxyWT/jGCfhZjB9BZVUJSYXWXx2hFPdrieyzwU 3ErbcTokULnq2qn6NES38rFPRzVaFeUrFLQsSgSuXdjt7sV+8IHl/mnE3PAgtq2GKz kMCIBH0wElXRNv9tggAbtRS10Wf5HUTEAvFd9e36Ra9tT1wFU0ARJRqaEstmK6vLTD MEbfJ1lw3maaFDHG5wmC9BnWyLkGRWrv3yG++N+J+ijHVjqddC0qrxw/a0EmbIvlDO B038KW11jZ/qg== Date: Tue, 17 May 2022 13:58:36 -0700 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, Rob Herring , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v2 2/5] net: dsa: add out-of-band tagging protocol Message-ID: <20220517135836.4455e77b@kernel.org> In-Reply-To: <20220517085355.4fab54b3@pc-20.home> References: <20220514150656.122108-1-maxime.chevallier@bootlin.com> <20220514150656.122108-3-maxime.chevallier@bootlin.com> <20220516122048.70e238a2@kernel.org> <20220517085355.4fab54b3@pc-20.home> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_135841_475133_F68C1046 X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 May 2022 08:53:55 +0200 Maxime Chevallier wrote: > > This must had been asked on v1 but there's no trace of it in the > > current submission afaict... > > No you're correct, this wasn't explained. > > > If the tag is passed in the descriptor how is this not a pure > > switchdev driver? The explanation must be preserved somehow. > > The main reason is that although the MAC and switch are rightly coupled > on that platform, the switch is actually a QC8K that can live on it's > own, as an external switch. Here, it's just a slightly modified version > of this IP. > > The same goes for the MAC IP, but so far we don't support any other > platform that have the MAC as a standalone controller. As far as we can > tell, platforms that have this MAC also include a QCA8K, but the > datasheet also mentions other modes (like outputing RGMII). Got it, thanks! Please weave this justification more explicitly into the cover letter. > Is this valid to have it as a standalone ethernet driver in that > situation ? Quite possibly.. I won't pretend I've looked at the code, I defer to the reviewers :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel