From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nqyXb-0006oe-AH for mharc-grub-devel@gnu.org; Tue, 17 May 2022 10:51:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqyXY-0006nH-Vj for grub-devel@gnu.org; Tue, 17 May 2022 10:51:14 -0400 Received: from dibed.net-space.pl ([84.10.22.86]:33550) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1nqyXX-000401-E3 for grub-devel@gnu.org; Tue, 17 May 2022 10:51:12 -0400 Received: from router-fw.i.net-space.pl ([192.168.52.1]:51334 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2126244AbiEQOvH (ORCPT ); Tue, 17 May 2022 16:51:07 +0200 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Tue, 17 May 2022 16:51:04 +0200 From: Daniel Kiper To: Glenn Washburn Cc: grub-devel@gnu.org Subject: Re: [PATCH] net: Fix incorrect condition for calling grub_net_tcp_retransmit() Message-ID: <20220517145104.4l2g6r5wcm63xkrv@tomti.i.net-space.pl> References: <20220512024401.3206077-1-development@efficientek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220512024401.3206077-1-development@efficientek.com> User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 14:51:14 -0000 On Wed, May 11, 2022 at 09:44:01PM -0500, Glenn Washburn wrote: > The commit 848724273e4 (net/net: Avoid unnecessary calls to > grub_net_tcp_retransmit()) needs to have its condition inverted to avoid > unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many > unnecessary calls and does not call grub_net_tcp_retransmit() when needed. > The call to grub_net_tcp_retransmit() should only be made when > grub_net_cards does _not_ equal NULL, meaning that there are potentially > network cards that need tcp retransmission. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel