All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allison Henderson <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 17/18] xfsprogs: add leaf to node error tag
Date: Tue, 17 May 2022 17:12:26 -0700	[thread overview]
Message-ID: <20220518001227.1779324-18-allison.henderson@oracle.com> (raw)
In-Reply-To: <20220518001227.1779324-1-allison.henderson@oracle.com>

Source kernel commit: c5218a7cd97349c53bc64e447778a07e49364d40

Add an error tag on xfs_attr3_leaf_to_node to test log attribute
recovery and replay.

Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Chandan Babu R <chandan.babu@oracle.com>
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
---
 io/inject.c            | 1 +
 libxfs/xfs_attr_leaf.c | 5 +++++
 libxfs/xfs_errortag.h  | 4 +++-
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/io/inject.c b/io/inject.c
index a7ad4df44503..4f7c6fff4cd6 100644
--- a/io/inject.c
+++ b/io/inject.c
@@ -60,6 +60,7 @@ error_tag(char *name)
 		{ XFS_ERRTAG_AG_RESV_FAIL,		"ag_resv_fail" },
 		{ XFS_ERRTAG_LARP,			"larp" },
 		{ XFS_ERRTAG_DA_LEAF_SPLIT,		"da_leaf_split" },
+		{ XFS_ERRTAG_ATTR_LEAF_TO_NODE,		"attr_leaf_to_node" },
 		{ XFS_ERRTAG_MAX,			NULL }
 	};
 	int	count;
diff --git a/libxfs/xfs_attr_leaf.c b/libxfs/xfs_attr_leaf.c
index 45d1b0634db4..6bd324844f32 100644
--- a/libxfs/xfs_attr_leaf.c
+++ b/libxfs/xfs_attr_leaf.c
@@ -1186,6 +1186,11 @@ xfs_attr3_leaf_to_node(
 
 	trace_xfs_attr_leaf_to_node(args);
 
+	if (XFS_TEST_ERROR(false, mp, XFS_ERRTAG_ATTR_LEAF_TO_NODE)) {
+		error = -EIO;
+		goto out;
+	}
+
 	error = xfs_da_grow_inode(args, &blkno);
 	if (error)
 		goto out;
diff --git a/libxfs/xfs_errortag.h b/libxfs/xfs_errortag.h
index 6d06a502bbdf..5362908164b0 100644
--- a/libxfs/xfs_errortag.h
+++ b/libxfs/xfs_errortag.h
@@ -61,7 +61,8 @@
 #define XFS_ERRTAG_AG_RESV_FAIL				38
 #define XFS_ERRTAG_LARP					39
 #define XFS_ERRTAG_DA_LEAF_SPLIT			40
-#define XFS_ERRTAG_MAX					41
+#define XFS_ERRTAG_ATTR_LEAF_TO_NODE			41
+#define XFS_ERRTAG_MAX					42
 
 /*
  * Random factors for above tags, 1 means always, 2 means 1/2 time, etc.
@@ -107,5 +108,6 @@
 #define XFS_RANDOM_AG_RESV_FAIL				1
 #define XFS_RANDOM_LARP					1
 #define XFS_RANDOM_DA_LEAF_SPLIT			1
+#define XFS_RANDOM_ATTR_LEAF_TO_NODE			1
 
 #endif /* __XFS_ERRORTAG_H_ */
-- 
2.25.1


  parent reply	other threads:[~2022-05-18  0:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  0:12 [PATCH 00/18] xfsprogs: Port larp, enable injects and log print for attri/d Allison Henderson
2022-05-18  0:12 ` [PATCH 01/18] xfsprogs: zero inode fork buffer at allocation Allison Henderson
2022-05-18  0:12 ` [PATCH 02/18] xfsprogs: hide log iovec alignment constraints Allison Henderson
2022-05-18  0:12 ` [PATCH 03/18] xfsprogs: don't commit the first deferred transaction without intents Allison Henderson
2022-05-18  0:12 ` [PATCH 04/18] xfsprogs: tag transactions that contain intent done items Allison Henderson
2022-05-18  0:12 ` [PATCH 05/18] xfsprogs: Fix double unlock in defer capture code Allison Henderson
2022-05-18  0:12 ` [PATCH 06/18] xfsprogs: Return from xfs_attr_set_iter if there are no more rmtblks to process Allison Henderson
2022-05-18  0:12 ` [PATCH 07/18] xfsprogs: Set up infrastructure for log attribute replay Allison Henderson
2022-05-18  0:12 ` [PATCH 08/18] xfsprogs: Implement attr logging and replay Allison Henderson
2022-05-18  0:31   ` Darrick J. Wong
2022-05-18 16:38     ` Alli
2022-05-18 17:00       ` Darrick J. Wong
2022-05-19 23:11         ` Alli
2022-05-19 23:17           ` Darrick J. Wong
2022-05-18  0:12 ` [PATCH 09/18] xfsprogs: Skip flip flags for delayed attrs Allison Henderson
2022-05-18  0:12 ` [PATCH 10/18] xfsprogs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson
2022-05-18  0:12 ` [PATCH 11/18] xfsprogs: Remove unused xfs_attr_*_args Allison Henderson
2022-05-18  0:12 ` [PATCH 12/18] xfsprogs: Add log attribute error tag Allison Henderson
2022-05-18  0:12 ` [PATCH 13/18] xfsprogs: Merge xfs_delattr_context into xfs_attr_item Allison Henderson
2022-05-18  0:12 ` [PATCH 14/18] xfsprogs: Add helper function xfs_attr_leaf_addname Allison Henderson
2022-05-18  0:12 ` [PATCH 15/18] xfsprogs: Add helper function xfs_init_attr_trans Allison Henderson
2022-05-18  0:12 ` [PATCH 16/18] xfsprogs: add leaf split error tag Allison Henderson
2022-05-18  0:12 ` Allison Henderson [this message]
2022-05-18  0:12 ` [PATCH 18/18] xfsprogs: Add log item printing for ATTRI and ATTRD Allison Henderson
2022-05-18  1:02   ` Darrick J. Wong
2022-05-18 16:38     ` Alli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220518001227.1779324-18-allison.henderson@oracle.com \
    --to=allison.henderson@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.