From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F412C433EF for ; Wed, 18 May 2022 00:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232881AbiERAw3 (ORCPT ); Tue, 17 May 2022 20:52:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231883AbiERAw1 (ORCPT ); Tue, 17 May 2022 20:52:27 -0400 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C269527E5; Tue, 17 May 2022 17:52:26 -0700 (PDT) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-d39f741ba0so740638fac.13; Tue, 17 May 2022 17:52:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p/MnfFetCNPy/OGaJyPe/9LawJdkP2TbRs1icnabz0g=; b=0hSRJAmywelMurkmvorrwdM8kP4n8TlwqFnZ1s8TfJDN7Nt9BwRJLkqwhoBNlkz2ou bM3dV3eesbvIOFspqDq8vzRJcLmZfUekd7wc2E3yOhJ8O4fEqVh9XcZClFNUglC4MBaW 0P+QTJwlA45J3pnFEKVeFs8o+IQPh0rRrfbGS4vITosipMPR6ZYR69aehMh5P0adSgdq QDvc8D76u/nYEEqmdeex3mASTkN/Ty6V2QAf1HgxDQftXTMoIFhxN/FA8aBmSdYgxWu0 fCCYpkzAUspJEXDOzV/83RACIe+JXrNmWUoZq6rcOs6/uXmmyc0/CdrbogJ5EHWvrFJU +gEg== X-Gm-Message-State: AOAM533uhMCqORYMTC2qdKzpLyrw+W6m28ES1EYbL+TAncnNcmOMyB28 jbfkLAM67ev7X7LCzHM7YsPX7cNQ2w== X-Google-Smtp-Source: ABdhPJzrZJlKes6PsY7+V0jGexlBqAaNhNYOWvSJc4RNos3ZrWmW0m4fxZ4fU1Xy/k9EsmytiBDLvw== X-Received: by 2002:a05:6870:5ba6:b0:f1:5840:f3a5 with SMTP id em38-20020a0568705ba600b000f15840f3a5mr12208951oab.254.1652835145409; Tue, 17 May 2022 17:52:25 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i3-20020a056870044300b000ead8b89484sm408601oak.5.2022.05.17.17.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 17:52:24 -0700 (PDT) Received: (nullmailer pid 1974016 invoked by uid 1000); Wed, 18 May 2022 00:52:23 -0000 Date: Tue, 17 May 2022 19:52:23 -0500 From: Rob Herring To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v2 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Message-ID: <20220518005223.GA1970862-robh@kernel.org> References: <20220514150656.122108-1-maxime.chevallier@bootlin.com> <20220514150656.122108-5-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220514150656.122108-5-maxime.chevallier@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 14, 2022 at 05:06:55PM +0200, Maxime Chevallier wrote: > Add the DT binding for the IPQESS Ethernet Controller. This is a simple > controller, only requiring the phy-mode, interrupts, clocks, and > possibly a MAC address setting. > > Signed-off-by: Maxime Chevallier > --- > V1->V2: > - Fixed the example > - Added reset and clocks > - Removed generic ethernet attributes > > .../devicetree/bindings/net/qcom,ipqess.yaml | 104 ++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipqess.yaml b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > new file mode 100644 > index 000000000000..ea0023509737 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qcom,ipqess.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ ESS EDMA Ethernet Controller > + > +maintainers: > + - Maxime Chevallier > + > +allOf: > + - $ref: "ethernet-controller.yaml#" > + > +properties: > + compatible: > + const: qcom,ipq4019e-ess-edma > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 2 > + maxItems: 32 > + description: One interrupt per tx and rx queue, with up to 16 queues. > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: ess Always kind of pointless to have a single *-names entry when it's just the block name. > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: ess ditto > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - phy-mode > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + gmac: ethernet@c080000 { > + compatible = "qcom,ipq4019-ess-edma"; > + reg = <0xc080000 0x8000>; > + resets = <&gcc ESS_RESET>; > + reset-names = "ess"; > + clocks = <&gcc GCC_ESS_CLK>; > + clock-names = "ess"; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + > + phy-mode = "internal"; > + fixed-link { > + speed = <1000>; > + full-duplex; > + pause; > + asym-pause; > + }; > + }; > + > +... > -- > 2.36.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 939EBC433F5 for ; Wed, 18 May 2022 00:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UW5V+adhFAHIVXKmlX8jywZ9aQQCvZJzDAu+lr5vhng=; b=G4CHWNAtZE+5TE gRRu0O/PkZMFlL74trm0xysBnoA9Y9WRKp++m/Cxexpfp8q3/WPa60vKSHYXrUROnm3kTmUyjK4pu 04bHhnR8JTJxArd7CZZt1/Ju9LbHb8FSTrUpj+hnUWXZgPNTLnI3uYNchT/kbHMc4QtNimwvTL7lO S1YQAxS+Z1z0GoMuENRcDRzDTnYYpdZ7qXmem7/L/Fzx7PJuWRu6tOJ/iXxVPAdIUeIxShIQrhS9+ MhBxKkn5MQuisEVCfzCPN34fQbqcQgjhfQWgWXfAp+Nse8bYIZbwtBvnGmQ58paVhcnaPqyrmdWHz dMBzx+IqBvEQPwvJdZmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nr7vT-00GPUD-JB; Wed, 18 May 2022 00:52:31 +0000 Received: from mail-oa1-f54.google.com ([209.85.160.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nr7vQ-00GPT9-CE for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 00:52:30 +0000 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-edf9ddb312so773103fac.8 for ; Tue, 17 May 2022 17:52:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p/MnfFetCNPy/OGaJyPe/9LawJdkP2TbRs1icnabz0g=; b=mfGm2QmO/nzGUrYNU62sr59xrhdYrmHsgZVrLrvSYpB6HMWl4Zbc7ZH/M7K+Id69eo 5MS9L8NRXa6SErPnvsYAalgUxxSHWxKUF2+kVYc8E7f2a2pA/pxhlfsOebZdCYf72FgE 5XTZUMTjJfWDkz4RCAloJii7ixws/tSCiMQtTucpt8SDNrmNZcdI1lSUDDJk26gCGuzd +rpL/pK6VyhGhdRIXZ8R25mp3AZqetfJIMzb9msY4FEw6Pi2nsDONbjREYyy7wqGy4Fs q5r46uMBTyQ4ma0jwidsw9Be3UnLbCoK1ioXFyX9Xyp6bK5yl+0UMGKWjuUcrUefl204 WJUA== X-Gm-Message-State: AOAM530OCmIn/4+qzZaKOZNFruUFwa1DX+aVCMWBDwPiinJNBshsbUI/ JjfRwklh6Qi8j5YglX0Tsw== X-Google-Smtp-Source: ABdhPJzrZJlKes6PsY7+V0jGexlBqAaNhNYOWvSJc4RNos3ZrWmW0m4fxZ4fU1Xy/k9EsmytiBDLvw== X-Received: by 2002:a05:6870:5ba6:b0:f1:5840:f3a5 with SMTP id em38-20020a0568705ba600b000f15840f3a5mr12208951oab.254.1652835145409; Tue, 17 May 2022 17:52:25 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i3-20020a056870044300b000ead8b89484sm408601oak.5.2022.05.17.17.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 17:52:24 -0700 (PDT) Received: (nullmailer pid 1974016 invoked by uid 1000); Wed, 18 May 2022 00:52:23 -0000 Date: Tue, 17 May 2022 19:52:23 -0500 From: Rob Herring To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: Re: [PATCH net-next v2 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Message-ID: <20220518005223.GA1970862-robh@kernel.org> References: <20220514150656.122108-1-maxime.chevallier@bootlin.com> <20220514150656.122108-5-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220514150656.122108-5-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_175228_457108_8427B05B X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 14, 2022 at 05:06:55PM +0200, Maxime Chevallier wrote: > Add the DT binding for the IPQESS Ethernet Controller. This is a simple > controller, only requiring the phy-mode, interrupts, clocks, and > possibly a MAC address setting. > > Signed-off-by: Maxime Chevallier > --- > V1->V2: > - Fixed the example > - Added reset and clocks > - Removed generic ethernet attributes > > .../devicetree/bindings/net/qcom,ipqess.yaml | 104 ++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipqess.yaml b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > new file mode 100644 > index 000000000000..ea0023509737 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qcom,ipqess.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ ESS EDMA Ethernet Controller > + > +maintainers: > + - Maxime Chevallier > + > +allOf: > + - $ref: "ethernet-controller.yaml#" > + > +properties: > + compatible: > + const: qcom,ipq4019e-ess-edma > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 2 > + maxItems: 32 > + description: One interrupt per tx and rx queue, with up to 16 queues. > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: ess Always kind of pointless to have a single *-names entry when it's just the block name. > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: ess ditto > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - phy-mode > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + gmac: ethernet@c080000 { > + compatible = "qcom,ipq4019-ess-edma"; > + reg = <0xc080000 0x8000>; > + resets = <&gcc ESS_RESET>; > + reset-names = "ess"; > + clocks = <&gcc GCC_ESS_CLK>; > + clock-names = "ess"; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + > + phy-mode = "internal"; > + fixed-link { > + speed = <1000>; > + full-duplex; > + pause; > + asym-pause; > + }; > + }; > + > +... > -- > 2.36.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel