From: Kees Cook <keescook@chromium.org>
To: David Howells <dhowells@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Eric Biggers <ebiggers@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Salvatore Bonaccorso <carnil@debian.org>,
keyrings@vger.kernel.org, Adam Langley <agl@google.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] sign-file: Convert API usage to support OpenSSL v3
Date: Wed, 18 May 2022 14:58:05 -0700 [thread overview]
Message-ID: <202205181457.01A586D25E@keescook> (raw)
In-Reply-To: <20220518215129.264872-1-keescook@chromium.org>
On Wed, May 18, 2022 at 02:51:29PM -0700, Kees Cook wrote:
> OpenSSL's ENGINE API is deprecated in OpenSSL v3.0, along with some
> other functions. Remove the ENGINE use and a macro work-around for
> ERR_get_error_line().
>
> Cc: David Howells <dhowells@redhat.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Cc: Salvatore Bonaccorso <carnil@debian.org>
> Cc: keyrings@vger.kernel.org
> Suggested-by: Adam Langley <agl@google.com>
> Co-developed-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v1: https://lore.kernel.org/lkml/20211005161833.1522737-1-lee.jones@linaro.org/
> v2: https://lore.kernel.org/lkml/Yicwb+Ceiu8JjVIS@google.com/
> v3:
> - Eliminate all the build warnings with OpenSSL 3
> - Fully remove ENGINE usage, if it can be optional, just drop it.
> ---
> scripts/sign-file.c | 49 ++++++++++-----------------------------------
> 1 file changed, 11 insertions(+), 38 deletions(-)
>
> diff --git a/scripts/sign-file.c b/scripts/sign-file.c
Eh, this only fixes sign-file.c. Fixes are still needed for
extract-cert.c...
--
Kees Cook
next prev parent reply other threads:[~2022-05-18 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 21:51 [PATCH v2] sign-file: Convert API usage to support OpenSSL v3 Kees Cook
2022-05-18 21:58 ` Kees Cook [this message]
2022-05-18 22:59 ` Shuah Khan
2022-05-19 6:45 ` Salvatore Bonaccorso
2022-05-19 15:21 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205181457.01A586D25E@keescook \
--to=keescook@chromium.org \
--cc=agl@google.com \
--cc=carnil@debian.org \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=ebiggers@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.