From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FD12C433F5 for ; Wed, 18 May 2022 15:22:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4577D82125; Wed, 18 May 2022 17:22:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Pw6FCpER"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9511C8426A; Wed, 18 May 2022 17:22:14 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9E9B981D8C for ; Wed, 18 May 2022 17:22:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id x22so1867088qto.2 for ; Wed, 18 May 2022 08:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BbnHRQznRPtziTSNMtOXi5BsYaiUVFhEqxjcYTY+pAs=; b=Pw6FCpERKK8BRzVSvvub9oayJXu3jKWz/Rrcz8gy+slwL3fLCgf2oWwLP7tudwRyY7 kNdayEIwe3RPfUuyi3bDR7Qql3V3jgsJ1CCsaKw8MatfhVP9K55++4ZhGpTQIVE+y3g/ PFcTYi2Kud1PSFvKyX1uIbZHqOvxQDppRca7s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BbnHRQznRPtziTSNMtOXi5BsYaiUVFhEqxjcYTY+pAs=; b=kIuaSceGFxFTOWeIQkiCnKHwueu+BooLuJb0GoaNTtrxjI7wleC3GepCIx4j3ct7L4 CtlRfbpwg97iwaKqtyOey38rAeSCMyCwXHuT4W2KXQIRu2fSgq8f0TJ6uIkC3CNcb+Vy Z0Nd0tfjEIBnfjhe7GAz6K3d6GUZUBjgKtcA56oIcEg/SG764q+nSimW5pa2m1kvQxpu ydCAbkcLJEljYUnN51MoUG9r/DzM/rgDSJ1Xrp8zdGKQxk7K8CO9mhF3LpoexRtQURoj 5OZUfPZanfLesiqvHkeKSG5UKeVICuwiLsj/zCXM3D7icqejch8FZjWVNY8r0Pescouc tQ8w== X-Gm-Message-State: AOAM5321VGLoV7Mz1015maDeoIvvvGAtrGYmjPAoA0TtecWlmEZSVJ6d 4fEsrT00Fx+6d9WcIO35C22odw== X-Google-Smtp-Source: ABdhPJxTJeCNork8dlnicxFndLWYe60o4cH1hQa6RFh3QQ96zYIlrTGqwXjRtVG6SjI79/6nw9Dk9w== X-Received: by 2002:a05:622a:248:b0:2f3:b478:d5de with SMTP id c8-20020a05622a024800b002f3b478d5demr196867qtx.519.1652887330479; Wed, 18 May 2022 08:22:10 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-4500-d95c-f120-8640-d523.res6.spectrum.com. [2603:6081:7b01:4500:d95c:f120:8640:d523]) by smtp.gmail.com with ESMTPSA id a22-20020a376616000000b0069fe1dfbeffsm1704244qkc.92.2022.05.18.08.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 08:22:09 -0700 (PDT) Date: Wed, 18 May 2022 11:22:07 -0400 From: Tom Rini To: Daniel Schwierzeck Cc: u-boot@lists.denx.de, Priyanka Jain Subject: Re: [PATCH] Kconfig: hide options not intended for users in arch/Kconfig Message-ID: <20220518152207.GB3901321@bill-the-cat> References: <20220517205353.2653667-1-daniel.schwierzeck@gmail.com> <20220518121849.GV3901321@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JeySm3848e6KficE" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --JeySm3848e6KficE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 18, 2022 at 05:12:13PM +0200, Daniel Schwierzeck wrote: >=20 >=20 > On 18.05.22 14:18, Tom Rini wrote: > > On Tue, May 17, 2022 at 10:53:53PM +0200, Daniel Schwierzeck wrote: > > > Those options show up in menuconfig when selecting ARM or MIPS which > > > is dangerous if a user accidently sets them. This also clutters up the > > > menuconfig top-level screen. Because those options should only be set > > > by SoC specific or board specific configs, make them invisible. > > >=20 > > > Signed-off-by: Daniel Schwierzeck > > >=20 > > > --- > > >=20 > > > arch/Kconfig | 14 +++++++------- > > > 1 file changed, 7 insertions(+), 7 deletions(-) > > >=20 > > > diff --git a/arch/Kconfig b/arch/Kconfig > > > index 12de8a1165..e3e28d0628 100644 > > > --- a/arch/Kconfig > > > +++ b/arch/Kconfig > > > @@ -365,7 +365,7 @@ config SYS_DISABLE_DCACHE_OPS > > > this functionality. > > > config SYS_IMMR > > > - hex "Address for the Internal Memory-Mapped Registers (IMMR) window" > > > + hex > > > depends on PPC || FSL_LSCH2 || FSL_LSCH3 || ARCH_LS1021A > > > default 0xFF000000 if MPC8xx > > > default 0xF0000000 if ARCH_MPC8313 > >=20 > > But now these aren't user selectable on the right platforms either. > > Maybe we need more menu organization, and so can have sub-menus depend > > on PPC, or whatever, and so things aren't cluttered on other > > architectures? > >=20 >=20 > my main concern was with SKIP_LOWLEVEL_INIT which definitely should not be > selectable by the user. Maybe I was to overambitious with changing the > SYS_IMMR option too, I could revert that part ;) I'd be agreeable to a patch that makes everyone that enables it today select it instead. > BTW: SYS_IMMR seems to be specific for PPC. Maybe it could be moved to > arch/powerpc/Kconfig? It's PowerPC or the 64bit ARM Layerscape platforms. There's I think only several imperfect places today for the options that are present in both due to the IP blocks / etc being updated by NXP for use in their current ARM HW. --=20 Tom --JeySm3848e6KficE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKFDx8ACgkQFHw5/5Y0 tyzy2Qv+OMEsuc5pM7PVCAPxbWhCjZuQ1LVNpg7gvqdaASae3k+yxkRhS7hwJYb1 XKEDdyyfRb05h+lrVWyyooRwMggnW6LRaBwOfcQie0sYhXchhwR3OwaIEeMtbPWW fXegZ3W7DbVJnVhy4tTS/1siV+B6mQCPiTGQ6nnYnJUqt6LijsMNV0C+8KlokyXG /XBdP5RGXG3uzExOze557FGB48n0N61tp8MW2V638Vo3/2SeCVvbN6HdbvBiXSmp VW6bKIx6wr1EUClMEMEDI9rDCoNgAVm5u8jKegQW8UiJ/oMrKqmcousj35dheFtd KRfHBW6PUUsyO3sIjLtqQggt5uLOfLGkdXHrbVp0oGncxjY7T0Qi3HFD5GLwFAMq /70Z3vSCZq2/5b5wLBYCBZ83++LknamgT8mvj2ZhnzpBKlI4PAkSPNTksUMExEo5 Wdt/nuHA1wMSaUgA6hkPQsCIfG6qyUvp0fcpX1rYW0yuSG3ahf3lD3Tp0s85uHXJ 7EW2O/KW =iVIM -----END PGP SIGNATURE----- --JeySm3848e6KficE--