From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19ED4C433F5 for ; Wed, 18 May 2022 15:57:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4010F84278; Wed, 18 May 2022 17:57:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rWZhtYtK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C822584278; Wed, 18 May 2022 17:57:39 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 911BD83DEB for ; Wed, 18 May 2022 17:57:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id k8so1796792qki.8 for ; Wed, 18 May 2022 08:57:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0mr6XXeXLKV9lrGGeQxYdeczFMJTeERQQdxtE5fCT90=; b=rWZhtYtK3qigb8ywuGzcIQtKZBiptmjJm+n4CBB/oszCbT096hZaaUFTDsAka9n8l/ Jq0hkSPlNLhhXXX4OIKwgUWheeehWUQmhSHeDWYtoVuLy6pPubYfER9FW4n7WMtaFzho r5zoW7bH70+Crwx4t3xk3knuvp7SMZfu1ccIA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0mr6XXeXLKV9lrGGeQxYdeczFMJTeERQQdxtE5fCT90=; b=Zu+TanzPTdGQPJChQ36ol3NlKZweoaWMOMKj3tNGeA/SvgYtns22utQZ3HnnhlTzRk F+cKx/25V/5TK+dTugJTa+T1xLMc9IkDhwQqM4PfySkcXItMRxJDOpxK5/u2O6Djzb3Y VTUHCghFs6hrPLEAGSiCbuD0lhV9u3+EBwGuL3YrEcGP8vKl7uA7Pb45vNz0CdtpDy3D UAMYt+7mn2vZb5IexFk6T3f1A//9d72XKoj4V09KoWhUxaRZW+XmqH5yR403yvDBHjFZ rIuijYWY3fTH+Z4K4TByvhhSy7TGIegFrMsT1Jvpjab+s9J83D+Jg3VcWAA9zJ6dpCKq 5WIA== X-Gm-Message-State: AOAM5324RxKHQWek3UWEkkFHFXAYzcVYTGkiWoN55FcaQKk8qIeTeSTm yixpXmtempAN+urWYCQNTsNLeQ== X-Google-Smtp-Source: ABdhPJzPHjFhNgDdOJvreKx7zneM+By5tunbzgFJF6i5ftwGxspPBmi7kM4sHfcgR84JutxNYNOeZA== X-Received: by 2002:a05:620a:44ca:b0:6a0:40f7:72fe with SMTP id y10-20020a05620a44ca00b006a040f772femr36903qkp.299.1652889455361; Wed, 18 May 2022 08:57:35 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-4500-d95c-f120-8640-d523.res6.spectrum.com. [2603:6081:7b01:4500:d95c:f120:8640:d523]) by smtp.gmail.com with ESMTPSA id hf4-20020a05622a608400b002f39b99f6afsm1253624qtb.73.2022.05.18.08.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 08:57:34 -0700 (PDT) Date: Wed, 18 May 2022 11:57:32 -0400 From: Tom Rini To: Daniel Schwierzeck Cc: u-boot@lists.denx.de, Priyanka Jain Subject: Re: [PATCH] Kconfig: hide options not intended for users in arch/Kconfig Message-ID: <20220518155732.GG3901321@bill-the-cat> References: <20220517205353.2653667-1-daniel.schwierzeck@gmail.com> <20220518121849.GV3901321@bill-the-cat> <20220518152207.GB3901321@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Dq+XJyfGp3MXSfHB" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --Dq+XJyfGp3MXSfHB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 18, 2022 at 05:52:36PM +0200, Daniel Schwierzeck wrote: >=20 >=20 > On 18.05.22 17:22, Tom Rini wrote: > > On Wed, May 18, 2022 at 05:12:13PM +0200, Daniel Schwierzeck wrote: > > >=20 > > >=20 > > > On 18.05.22 14:18, Tom Rini wrote: > > > > On Tue, May 17, 2022 at 10:53:53PM +0200, Daniel Schwierzeck wrote: > > > > > Those options show up in menuconfig when selecting ARM or MIPS wh= ich > > > > > is dangerous if a user accidently sets them. This also clutters u= p the > > > > > menuconfig top-level screen. Because those options should only be= set > > > > > by SoC specific or board specific configs, make them invisible. > > > > >=20 > > > > > Signed-off-by: Daniel Schwierzeck > > > > >=20 > > > > > --- > > > > >=20 > > > > > arch/Kconfig | 14 +++++++------- > > > > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > >=20 > > > > > diff --git a/arch/Kconfig b/arch/Kconfig > > > > > index 12de8a1165..e3e28d0628 100644 > > > > > --- a/arch/Kconfig > > > > > +++ b/arch/Kconfig > > > > > @@ -365,7 +365,7 @@ config SYS_DISABLE_DCACHE_OPS > > > > > this functionality. > > > > > config SYS_IMMR > > > > > - hex "Address for the Internal Memory-Mapped Registers (IMMR) wi= ndow" > > > > > + hex > > > > > depends on PPC || FSL_LSCH2 || FSL_LSCH3 || ARCH_LS1021A > > > > > default 0xFF000000 if MPC8xx > > > > > default 0xF0000000 if ARCH_MPC8313 > > > >=20 > > > > But now these aren't user selectable on the right platforms either. > > > > Maybe we need more menu organization, and so can have sub-menus dep= end > > > > on PPC, or whatever, and so things aren't cluttered on other > > > > architectures? > > > >=20 > > >=20 > > > my main concern was with SKIP_LOWLEVEL_INIT which definitely should n= ot be > > > selectable by the user. Maybe I was to overambitious with changing the > > > SYS_IMMR option too, I could revert that part ;) > >=20 > > I'd be agreeable to a patch that makes everyone that enables it today > > select it instead. >=20 > I'll look into it. Would moving this to top-level Kconfig and the "General > setup" menu be an option? Sure. Note that it's only used on ARM and some MIPS platforms today, so we could also tighten the dependncy line. --=20 Tom --Dq+XJyfGp3MXSfHB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKFF2wACgkQFHw5/5Y0 tyz/Fwv+LF8cpRQ845i5c4UoBaj8hvAzU6lDu0kdKnA1F38T1BLCMnaAS6D8DGJt x283Sp5f11Sx3RDu+V9zkQo4d2oGqIuG50abRb8yvq6Ls9PE/j4kzrfJmfIZ+X1v tAmq6m+ltkdx0JZK3S9w47pPUnUTWjAGk15JtHBp+4gEiq2Zn1ChrYGQ8nJPR31v wDXOWFLnbCWrFwcLlJqeyrWKmKG8yV81Bj1EZIzwjX3TLf81qZFAlsPpZ/fYowFn xNTLHANTfG8Ozoi1Dm+74XCzpghNq7bpiW12CTRIzz2rav5bz8+03M81iSUlKUOJ 6XI7GhmURw4EecJWKxqWbn7OBd9SXjJPMen3cPZdRiXg6zUMG8WLWbRu4+yP2nSi lyW2j0eiKag34aLloMl99ulkgV/KjNSMdC+f7U73dMbFR3g2SIXhyTp/1qYaDRUg NU1khfaDHKRY3eESFS9jPWeMKJrERWR9jqZ1DL6gbtYgRb0TQDcmkMF1upzxqWsi 8VzLuKsZ =/LVA -----END PGP SIGNATURE----- --Dq+XJyfGp3MXSfHB--