From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 669CEC433F5 for ; Wed, 18 May 2022 16:05:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239803AbiERQFb (ORCPT ); Wed, 18 May 2022 12:05:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239792AbiERQF3 (ORCPT ); Wed, 18 May 2022 12:05:29 -0400 Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D9F1D675B for ; Wed, 18 May 2022 09:05:28 -0700 (PDT) Received: by mail-qv1-xf2a.google.com with SMTP id v5so1826007qvs.10 for ; Wed, 18 May 2022 09:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AsDPJQJoORPGh0qS4EUeaOiktBXOii5jyqGHGv+kXII=; b=N76w0omWsgq1J3trQP+78nGSW1FVT0gWGjc72Mb7QVydmmWW9+FAv5I3Dcl5COOIKO 4vA4c/iw6Hjv1lPlLWYuu4ZXAV0cmilaFztjoqQq3rpGsdIFIbi3551Hy18a84tDtlM1 /PVy20Jd2KeJ0STPnZZTjPBpGkbDWJmfUuaImI4EugibkVhOCmGuKS4x5BqJjjSa84Tw nnk40ZmaQIdUG4daGMY+vWEQed0/kZKjkAfoSigwJTPRTsEEfJAYQcPLAAF4LtR/2p+U xlREPjULkf2pEVenp75I+mD993ExL5U5UfVfMA2Y0WgBGhVwjcrJdMytRTXhKHsMJl4j uWxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AsDPJQJoORPGh0qS4EUeaOiktBXOii5jyqGHGv+kXII=; b=MQbv5HErdrIqRv98vRXHbQn+F2iZBVuC5y+NWrpxn8pcr87489IcsdXHHbVgdEEv3R Q2Z9JHDqDv03y3TAk/5S3p0bQOhkFpjb5kowAPlMQ7vNojNqvN2v0cjayl7bFJBUifug FJFih9Biu/f0pVM3UCiCTJ+3BHRjsputYgupjnKF8yY3BCfBwFvxo13QiSuuQ5X6w+5H GuS6+0ZFVCA0/u7HwORElwRv0/wK04uGk37qCMFzVK8XzinloQ5GJD2zMWqTczSR82D/ DFqpvH8YT3Q4rFGbtLo6kKVEBoIZB9pSQzAvEb+TsBNQTxpkkGi4aXASPMicrkkiRyma 8TvQ== X-Gm-Message-State: AOAM533hNbZNiqKh7Nu9E8lyZ0ADpaMmuwEBBkUf9aKwtYLXymG79ak1 8zKc7sUXbqwqCe8GmTO4/m1eFw== X-Google-Smtp-Source: ABdhPJwuWum5215mzbkNuSWa3OtW1/3pKlaT8sVXotoEFY0mMu9fuRHdN8UiWPfDKaWJgTpYISj/9g== X-Received: by 2002:a05:6214:224d:b0:461:f264:ba2 with SMTP id c13-20020a056214224d00b00461f2640ba2mr406148qvc.43.1652889927418; Wed, 18 May 2022 09:05:27 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id l19-20020a05622a175300b002f39b99f670sm1567656qtk.10.2022.05.18.09.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 09:05:26 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nrMAv-008VXe-MH; Wed, 18 May 2022 13:05:25 -0300 Date: Wed, 18 May 2022 13:05:25 -0300 From: Jason Gunthorpe To: Ajay Sharma Cc: Long Li , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Leon Romanovsky , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [EXTERNAL] Re: [PATCH 05/12] net: mana: Set the DMA device max page size Message-ID: <20220518160525.GP63055@ziepe.ca> References: <1652778276-2986-1-git-send-email-longli@linuxonhyperv.com> <1652778276-2986-6-git-send-email-longli@linuxonhyperv.com> <20220517145949.GH63055@ziepe.ca> <20220517193515.GN63055@ziepe.ca> <20220518000356.GO63055@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, May 18, 2022 at 05:59:00AM +0000, Ajay Sharma wrote: > Thanks Long. > Hello Jason, > I am the author of the patch. > To your comment below : > " As I've already said, you are supposed to set the value that limits to ib_sge and *NOT* the value that is related to ib_umem_find_best_pgsz. It is usually 2G because the ib_sge's typically work on a 32 bit length." > > The ib_sge is limited by the __sg_alloc_table_from_pages() which > uses ib_dma_max_seg_size() which is what is set by the eth driver > using dma_set_max_seg_size() . Currently our hw does not support > PTEs larger than 2M. *sigh* again it has nothing to do with *PTEs* in the HW. Jason