Re: [PATCH net-next v4 05/12] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch

From: Rob Herring <robh@kernel.org>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: "Vladimir Oltean" <olteanv@gmail.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Vivien Didelot" <vivien.didelot@gmail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Miquèl Raynal" <miquel.raynal@bootlin.com>,
	"Milan Stevanovic" <milan.stevanovic@se.com>,
	"Jimmy Lalande" <jimmy.lalande@se.com>,
	"Pascal Eberhard" <pascal.eberhard@se.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 05/12] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch
Date: Wed, 18 May 2022 13:53:07 -0500	[thread overview]
Message-ID: <20220518185307.GL3302100-robh@kernel.org> (raw)
In-Reply-To: <20220518144111.135c7d0d@fixe.home>

On Wed, May 18, 2022 at 02:41:11PM +0200, Clément Léger wrote:
> Le Wed, 18 May 2022 15:05:03 +0300,
> Vladimir Oltean <olteanv@gmail.com> a écrit :
> 
> > On Tue, May 17, 2022 at 08:59:24PM -0500, Rob Herring wrote:
> > > On Wed, May 11, 2022 at 06:33:37PM +0300, Vladimir Oltean wrote:  
> > > > On Wed, May 11, 2022 at 10:22:21AM -0500, Rob Herring wrote:  
> > > > > > +patternProperties:
> > > > > > +  "^ethernet-ports$":  
> > > > > 
> > > > > Move to 'properties', not a pattern.
> > > > > 
> > > > > With that,
> > > > > 
> > > > > Reviewed-by: Rob Herring <robh@kernel.org>  
> > > > 
> > > > Even if it should have been "^(ethernet-)?ports$"?  
> > > 
> > > Why? Allowing 'ports' is for existing users. New ones don't need the 
> > > variability and should use just 'ethernet-ports'.
> > > 
> > > Rob  
> > 
> > Yeah, ok, somehow the memo that new DSA drivers shouldn't support "ports"
> > didn't reach me. They invariably will though, since the DSA framework is
> > the main parser of the property, and that is shared by both old and new
> > drivers.
> 
> Should also the subnodes of "ethernet-ports" use the
> "ethernet-port@[0-9]*" naming ? Or keeping the existing pattern is ok
> (ie "^(ethernet-)?port@[0-4]$") ?

I prefer the former, but care less. The whole reason for 'ethernet-' 
prefix is to make this distinct from the graph binding that uses ports 
and port.

Rob