From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B258EC433EF for ; Wed, 18 May 2022 19:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241911AbiERT0J (ORCPT ); Wed, 18 May 2022 15:26:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241940AbiERT0H (ORCPT ); Wed, 18 May 2022 15:26:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 315A431DC8 for ; Wed, 18 May 2022 12:26:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E64E2B821A6 for ; Wed, 18 May 2022 19:26:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B7BBC385A9; Wed, 18 May 2022 19:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652901963; bh=PjHtLEt9xDAGD6Wi0W0Dmg6YFuFG0On9+1me7OexZQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EWFaLuVUhkw1nRyvNpqefOD7R+bW9Jg4yzMKo9PtzgSIsIh3FecqX/n1Qk+cerT7K +eZLG+/dv/LcudTlZdsYdGIEx7JWPSU+u3u4dpbsbisW6EIVmHW8OabPiq5a/3+hHK LAfnlDsbsQRJ64ym6Dcu2zgGEC1WJ3fGvj2+er2mj2596Bn7140Z39/XUAK24FApr3 GZOy/YeGIk0KMfWT/EqAKLC1gzvMI/rKYnDQewrtzoap7uLlirxpd1TjMttdWCaybo MbicaCL2NVnGEyRJMbA4tXwDsOjtK7utis2syDkjEK4UcWH9Uwc5i1k2lj6XKUjpcS CaB1yg4fFj1QA== Received: by pali.im (Postfix) id AB8BE5E6; Wed, 18 May 2022 21:26:00 +0200 (CEST) Date: Wed, 18 May 2022 21:26:00 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Marek =?utf-8?B?QmVow7pu?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 04/18] PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros Message-ID: <20220518192600.usgzcaca565kt66h@pali> References: <20220220193346.23789-5-kabel@kernel.org> <20220518192322.GA1155024@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220518192322.GA1155024@bhelgaas> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wednesday 18 May 2022 14:23:22 Bjorn Helgaas wrote: > On Sun, Feb 20, 2022 at 08:33:32PM +0100, Marek Behún wrote: > > From: Pali Rohár > > > > These macros allows to easily compose and extract Slot Power Limit and > > Physical Slot Number values from Slot Capability Register. > > > > Signed-off-by: Pali Rohár > > Signed-off-by: Marek Behún > > Acked-by: Bjorn Helgaas > > We talked about using FIELD_PREP() / FIELD_GET(), which I think would > remove the need for the *_SHIFT macros. But we can always do that > later. I have already done this for pci-mvebu.c driver and patch was merged: https://lore.kernel.org/linux-pci/20220412094946.27069-5-pali@kernel.org/ IIRC we have decided to not use those *_SHIFT macros as it would flood public uapi file and from this file we cannot remove macros due to userspace backward compatibility. > > --- > > include/uapi/linux/pci_regs.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > > index bee1a9ed6e66..d825e17e448c 100644 > > --- a/include/uapi/linux/pci_regs.h > > +++ b/include/uapi/linux/pci_regs.h > > @@ -591,10 +591,13 @@ > > #define PCI_EXP_SLTCAP_HPS 0x00000020 /* Hot-Plug Surprise */ > > #define PCI_EXP_SLTCAP_HPC 0x00000040 /* Hot-Plug Capable */ > > #define PCI_EXP_SLTCAP_SPLV 0x00007f80 /* Slot Power Limit Value */ > > +#define PCI_EXP_SLTCAP_SPLV_SHIFT 7 /* Slot Power Limit Value shift */ > > #define PCI_EXP_SLTCAP_SPLS 0x00018000 /* Slot Power Limit Scale */ > > +#define PCI_EXP_SLTCAP_SPLS_SHIFT 15 /* Slot Power Limit Scale shift */ > > #define PCI_EXP_SLTCAP_EIP 0x00020000 /* Electromechanical Interlock Present */ > > #define PCI_EXP_SLTCAP_NCCS 0x00040000 /* No Command Completed Support */ > > #define PCI_EXP_SLTCAP_PSN 0xfff80000 /* Physical Slot Number */ > > +#define PCI_EXP_SLTCAP_PSN_SHIFT 19 /* Physical Slot Number shift */ > > #define PCI_EXP_SLTCTL 0x18 /* Slot Control */ > > #define PCI_EXP_SLTCTL_ABPE 0x0001 /* Attention Button Pressed Enable */ > > #define PCI_EXP_SLTCTL_PFDE 0x0002 /* Power Fault Detected Enable */ > > -- > > 2.34.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44A47C433F5 for ; Wed, 18 May 2022 19:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xy/RN8CYR2DXNIxj8n6oW1CBptEfcfEH68WwffdtlOA=; b=wdNOOA79X7/ShO UNTgKUDk5pY5snzLubzA0p2q0hENgemOjBAf3bGfn4YaYKwbZuV3SZ+c7AsiJxeF5q2ERnD/Ac2W5 W9XS8+xS6FNjcQnhKRHEsyYIoZNbR6NHRwxmePTz8rH/MMAPhPrmrX0DjsXEXDmudDKHUFEhPNVEg TXW8mZNAD69Ft5janvWkDhJgh7Rtc3mAL6ZShttWmc/zXblxFJOS4UALPr4SewsxJBExVcnpQ26kE f9vNAmWdlxywDh189lNJTQPP1RZ58HMc9dmOKGjWL4+s97LbPkWVgGqm32GPSpeqzePo3Z4uKJIZ0 WRfUfLSgREk9NaS5QPiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrPJE-003cPK-HJ; Wed, 18 May 2022 19:26:12 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrPJA-003cNN-UD for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 19:26:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F0AB4B821AD; Wed, 18 May 2022 19:26:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B7BBC385A9; Wed, 18 May 2022 19:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652901963; bh=PjHtLEt9xDAGD6Wi0W0Dmg6YFuFG0On9+1me7OexZQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EWFaLuVUhkw1nRyvNpqefOD7R+bW9Jg4yzMKo9PtzgSIsIh3FecqX/n1Qk+cerT7K +eZLG+/dv/LcudTlZdsYdGIEx7JWPSU+u3u4dpbsbisW6EIVmHW8OabPiq5a/3+hHK LAfnlDsbsQRJ64ym6Dcu2zgGEC1WJ3fGvj2+er2mj2596Bn7140Z39/XUAK24FApr3 GZOy/YeGIk0KMfWT/EqAKLC1gzvMI/rKYnDQewrtzoap7uLlirxpd1TjMttdWCaybo MbicaCL2NVnGEyRJMbA4tXwDsOjtK7utis2syDkjEK4UcWH9Uwc5i1k2lj6XKUjpcS CaB1yg4fFj1QA== Received: by pali.im (Postfix) id AB8BE5E6; Wed, 18 May 2022 21:26:00 +0200 (CEST) Date: Wed, 18 May 2022 21:26:00 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Marek =?utf-8?B?QmVow7pu?= , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gregory CLEMENT Subject: Re: [PATCH 04/18] PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros Message-ID: <20220518192600.usgzcaca565kt66h@pali> References: <20220220193346.23789-5-kabel@kernel.org> <20220518192322.GA1155024@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220518192322.GA1155024@bhelgaas> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_122609_315733_373C5FEC X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkbmVzZGF5IDE4IE1heSAyMDIyIDE0OjIzOjIyIEJqb3JuIEhlbGdhYXMgd3JvdGU6Cj4g T24gU3VuLCBGZWIgMjAsIDIwMjIgYXQgMDg6MzM6MzJQTSArMDEwMCwgTWFyZWsgQmVow7puIHdy b3RlOgo+ID4gRnJvbTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPiA+IAo+ID4gVGhl c2UgbWFjcm9zIGFsbG93cyB0byBlYXNpbHkgY29tcG9zZSBhbmQgZXh0cmFjdCBTbG90IFBvd2Vy IExpbWl0IGFuZAo+ID4gUGh5c2ljYWwgU2xvdCBOdW1iZXIgdmFsdWVzIGZyb20gU2xvdCBDYXBh YmlsaXR5IFJlZ2lzdGVyLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFs aUBrZXJuZWwub3JnPgo+ID4gU2lnbmVkLW9mZi1ieTogTWFyZWsgQmVow7puIDxrYWJlbEBrZXJu ZWwub3JnPgo+IAo+IEFja2VkLWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29t Pgo+IAo+IFdlIHRhbGtlZCBhYm91dCB1c2luZyBGSUVMRF9QUkVQKCkgLyBGSUVMRF9HRVQoKSwg d2hpY2ggSSB0aGluayB3b3VsZAo+IHJlbW92ZSB0aGUgbmVlZCBmb3IgdGhlICpfU0hJRlQgbWFj cm9zLiAgQnV0IHdlIGNhbiBhbHdheXMgZG8gdGhhdAo+IGxhdGVyLgoKSSBoYXZlIGFscmVhZHkg ZG9uZSB0aGlzIGZvciBwY2ktbXZlYnUuYyBkcml2ZXIgYW5kIHBhdGNoIHdhcyBtZXJnZWQ6Cmh0 dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXBjaS8yMDIyMDQxMjA5NDk0Ni4yNzA2OS01LXBh bGlAa2VybmVsLm9yZy8KCklJUkMgd2UgaGF2ZSBkZWNpZGVkIHRvIG5vdCB1c2UgdGhvc2UgKl9T SElGVCBtYWNyb3MgYXMgaXQgd291bGQgZmxvb2QKcHVibGljIHVhcGkgZmlsZSBhbmQgZnJvbSB0 aGlzIGZpbGUgd2UgY2Fubm90IHJlbW92ZSBtYWNyb3MgZHVlIHRvCnVzZXJzcGFjZSBiYWNrd2Fy ZCBjb21wYXRpYmlsaXR5LgoKPiA+IC0tLQo+ID4gIGluY2x1ZGUvdWFwaS9saW51eC9wY2lfcmVn cy5oIHwgMyArKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4gPiAKPiA+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvbGludXgvcGNpX3JlZ3MuaCBiL2luY2x1ZGUvdWFw aS9saW51eC9wY2lfcmVncy5oCj4gPiBpbmRleCBiZWUxYTllZDZlNjYuLmQ4MjVlMTdlNDQ4YyAx MDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvdWFwaS9saW51eC9wY2lfcmVncy5oCj4gPiArKysgYi9p bmNsdWRlL3VhcGkvbGludXgvcGNpX3JlZ3MuaAo+ID4gQEAgLTU5MSwxMCArNTkxLDEzIEBACj4g PiAgI2RlZmluZSAgUENJX0VYUF9TTFRDQVBfSFBTCTB4MDAwMDAwMjAgLyogSG90LVBsdWcgU3Vy cHJpc2UgKi8KPiA+ICAjZGVmaW5lICBQQ0lfRVhQX1NMVENBUF9IUEMJMHgwMDAwMDA0MCAvKiBI b3QtUGx1ZyBDYXBhYmxlICovCj4gPiAgI2RlZmluZSAgUENJX0VYUF9TTFRDQVBfU1BMVgkweDAw MDA3ZjgwIC8qIFNsb3QgUG93ZXIgTGltaXQgVmFsdWUgKi8KPiA+ICsjZGVmaW5lICBQQ0lfRVhQ X1NMVENBUF9TUExWX1NISUZUCTcgIC8qIFNsb3QgUG93ZXIgTGltaXQgVmFsdWUgc2hpZnQgKi8K PiA+ICAjZGVmaW5lICBQQ0lfRVhQX1NMVENBUF9TUExTCTB4MDAwMTgwMDAgLyogU2xvdCBQb3dl ciBMaW1pdCBTY2FsZSAqLwo+ID4gKyNkZWZpbmUgIFBDSV9FWFBfU0xUQ0FQX1NQTFNfU0hJRlQJ MTUgLyogU2xvdCBQb3dlciBMaW1pdCBTY2FsZSBzaGlmdCAqLwo+ID4gICNkZWZpbmUgIFBDSV9F WFBfU0xUQ0FQX0VJUAkweDAwMDIwMDAwIC8qIEVsZWN0cm9tZWNoYW5pY2FsIEludGVybG9jayBQ cmVzZW50ICovCj4gPiAgI2RlZmluZSAgUENJX0VYUF9TTFRDQVBfTkNDUwkweDAwMDQwMDAwIC8q IE5vIENvbW1hbmQgQ29tcGxldGVkIFN1cHBvcnQgKi8KPiA+ICAjZGVmaW5lICBQQ0lfRVhQX1NM VENBUF9QU04JMHhmZmY4MDAwMCAvKiBQaHlzaWNhbCBTbG90IE51bWJlciAqLwo+ID4gKyNkZWZp bmUgIFBDSV9FWFBfU0xUQ0FQX1BTTl9TSElGVAkxOSAvKiBQaHlzaWNhbCBTbG90IE51bWJlciBz aGlmdCAqLwo+ID4gICNkZWZpbmUgUENJX0VYUF9TTFRDVEwJCTB4MTgJLyogU2xvdCBDb250cm9s ICovCj4gPiAgI2RlZmluZSAgUENJX0VYUF9TTFRDVExfQUJQRQkweDAwMDEJLyogQXR0ZW50aW9u IEJ1dHRvbiBQcmVzc2VkIEVuYWJsZSAqLwo+ID4gICNkZWZpbmUgIFBDSV9FWFBfU0xUQ1RMX1BG REUJMHgwMDAyCS8qIFBvd2VyIEZhdWx0IERldGVjdGVkIEVuYWJsZSAqLwo+ID4gLS0gCj4gPiAy LjM0LjEKPiA+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=