From: Stephen Boyd <sboyd@kernel.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 6/8] rpmsg: qcom: correct kerneldoc
Date: Wed, 18 May 2022 17:11:52 -0700 [thread overview]
Message-ID: <20220519001154.A64A2C385AA@smtp.kernel.org> (raw)
In-Reply-To: <20220501103520.111561-6-krzysztof.kozlowski@linaro.org>
Quoting Krzysztof Kozlowski (2022-05-01 03:35:18)
> Correct kerneldoc warnings like:
>
> drivers/rpmsg/qcom_glink_ssr.c:45:
> warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_CLEANUP() instead
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> drivers/rpmsg/qcom_glink_ssr.c | 2 +-
> drivers/rpmsg/qcom_smd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
> index dea929c6045d..776d64446879 100644
> --- a/drivers/rpmsg/qcom_glink_ssr.c
> +++ b/drivers/rpmsg/qcom_glink_ssr.c
> @@ -39,7 +39,7 @@ struct cleanup_done_msg {
> __le32 seq_num;
> };
>
> -/**
> +/*
> * G-Link SSR protocol commands
> */
> #define GLINK_SSR_DO_CLEANUP 0
> diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
> index 7c8c29f6c91d..e7e49d972d36 100644
> --- a/drivers/rpmsg/qcom_smd.c
> +++ b/drivers/rpmsg/qcom_smd.c
> @@ -729,7 +729,7 @@ static int qcom_smd_write_fifo(struct qcom_smd_channel *channel,
> }
>
> /**
> - * qcom_smd_send - write data to smd channel
> + * __qcom_smd_send - write data to smd channel
> * @channel: channel handle
> * @data: buffer of data to write
> * @len: number of bytes to write
Not part of this patch but it says "flag to indicate if write has ca
wait" and I wonder what "ca" means.
next prev parent reply other threads:[~2022-05-19 0:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 10:35 [PATCH 1/8] clk: qcom: alpha-pll: correct kerneldoc Krzysztof Kozlowski
2022-05-01 10:35 ` [PATCH 2/8] firmware: qcom_scm-legacy: " Krzysztof Kozlowski
2022-05-19 0:03 ` Stephen Boyd
2022-05-19 7:20 ` Krzysztof Kozlowski
2022-05-01 10:35 ` [PATCH 3/8] remoteproc: qcom: " Krzysztof Kozlowski
2022-05-19 0:05 ` Stephen Boyd
2022-05-01 10:35 ` [PATCH 4/8] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
2022-07-18 22:59 ` (subset) " Bjorn Andersson
2022-05-01 10:35 ` [PATCH 5/8] rpmsg: qcom: glink: remove unused name Krzysztof Kozlowski
2022-05-19 0:09 ` Stephen Boyd
2022-05-01 10:35 ` [PATCH 6/8] rpmsg: qcom: correct kerneldoc Krzysztof Kozlowski
2022-05-19 0:11 ` Stephen Boyd [this message]
2022-05-01 10:35 ` [PATCH 7/8] soc: qcom: cmd-db: replace strncpy() with strscpy_pad() Krzysztof Kozlowski
2022-05-19 0:12 ` Stephen Boyd
2022-05-01 10:35 ` [PATCH 8/8] soc: qcom: correct kerneldoc Krzysztof Kozlowski
2022-05-19 0:13 ` Stephen Boyd
2022-05-17 16:46 ` [PATCH 1/8] clk: qcom: alpha-pll: " Krzysztof Kozlowski
2022-05-19 0:14 ` Stephen Boyd
2022-05-19 7:23 ` Krzysztof Kozlowski
2022-05-19 0:02 ` Stephen Boyd
2022-05-19 7:20 ` Krzysztof Kozlowski
2022-05-19 4:30 ` Vladimir Zapolskiy
2022-05-19 7:23 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519001154.A64A2C385AA@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.