From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C482C43217 for ; Thu, 19 May 2022 00:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbiESAjZ (ORCPT ); Wed, 18 May 2022 20:39:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232348AbiESAjQ (ORCPT ); Wed, 18 May 2022 20:39:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 00F568BD30 for ; Wed, 18 May 2022 17:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652920755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dhPoiNFlWhE/EG2LfPsngTKf/wXSwPmET9DKcPeU2e0=; b=KdhkiFv6m8ffPadNxlMILImIU5EY62LeqTyf+CMQaSCgIUObNATZ1RFgGJiPpa0HQ/ZOVO ZXArCLqaNxl6qjKi8MzNM4980iFc31eb4Gf5B5fNG/JuCU8Nt5vK3ub7FXCm8BDkM5rFSO TC0CAGpFNI7Dp/k3ECzSVzsbrpsJ6z8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-L87-ln_FMa6BzS8tUYo5IA-1; Wed, 18 May 2022 20:39:07 -0400 X-MC-Unique: L87-ln_FMa6BzS8tUYo5IA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 021A48015BA; Thu, 19 May 2022 00:39:07 +0000 (UTC) Received: from localhost (ovpn-12-103.pek2.redhat.com [10.72.12.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD749492C3B; Thu, 19 May 2022 00:39:05 +0000 (UTC) Date: Thu, 19 May 2022 08:39:02 +0800 From: Baoquan He To: Heiko Carstens , akpm@linux-foundation.org, zohar@linux.ibm.com Cc: Coiby Xu , kexec@lists.infradead.org, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Suchanek , Dave Young , Will Deacon , "Eric W . Biederman" , Mimi Zohar , Chun-Yi Lee , stable@vger.kernel.org, Philipp Rudo , linux-security-module@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Martin Schwidefsky , "open list:S390" , open list Subject: Re: [PATCH v8 4/4] kexec, KEYS, s390: Make use of built-in and secondary keyring for signature verification Message-ID: <20220519003902.GE156677@MiWiFi-R3L-srv> References: <20220512070123.29486-1-coxu@redhat.com> <20220512070123.29486-5-coxu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On 05/18/22 at 01:29pm, Heiko Carstens wrote: > On Thu, May 12, 2022 at 03:01:23PM +0800, Coiby Xu wrote: > > From: Michal Suchanek > > > > commit e23a8020ce4e ("s390/kexec_file: Signature verification prototype") > > adds support for KEXEC_SIG verification with keys from platform keyring > > but the built-in keys and secondary keyring are not used. > > > > Add support for the built-in keys and secondary keyring as x86 does. > > > > Fixes: e23a8020ce4e ("s390/kexec_file: Signature verification prototype") > > Cc: stable@vger.kernel.org > > Cc: Philipp Rudo > > Cc: kexec@lists.infradead.org > > Cc: keyrings@vger.kernel.org > > Cc: linux-security-module@vger.kernel.org > > Signed-off-by: Michal Suchanek > > Reviewed-by: "Lee, Chun-Yi" > > Acked-by: Baoquan He > > Signed-off-by: Coiby Xu > > --- > > arch/s390/kernel/machine_kexec_file.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > As far as I can tell this doesn't have any dependency to the other > patches in this series, so should I pick this up for the s390 tree, or > how will this go upstream? Thanks, Heiko. I want to ask Mimi if this can be taken into KEYS-ENCRYPTED tree. Otherwise I will ask Andrew to help pick this whole series. Surely, this patch 4 can be taken into s390 seperately since it's independent, both looks good. Thanks Baoquan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0A12C433EF for ; Thu, 19 May 2022 00:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e5t4bEco7HLQicNVAnOvOmsau07ks7H26f+4LcafCAM=; b=wX7AxI2SqEGAci uN1kf7gpBqNoBKZP9O81dEyeupr+tgqCCYOsVS/jfHLmxcUJGO+mwtL1q+dUl6/+RQbKNitan44gg i0iSpGbcZ9LHrT+BlUduK3J2lled/nnlGOzLIfJSf3lyL0R68hsUZm5BeHGA//SZC+oyIbV8R7+ib +4Q0F4/8Bq1WdCkRK6mNw473Dme09OgKXMfXRM1ofROQ+XYFqOnioPdHxiPWDACQgP9h2Ama5uag3 zq0A+X/IO7tNZYCoHbvpKodoQnNAyR7XpjyZn5vcqr8X44wa/tzsdVtSsQbVLCHH4Wh3HbEj9+vU3 GM0kJNSRpkT+6wwfDmZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrUCC-004Vf2-2R; Thu, 19 May 2022 00:39:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrUC9-004VeM-83 for linux-arm-kernel@lists.infradead.org; Thu, 19 May 2022 00:39:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652920752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dhPoiNFlWhE/EG2LfPsngTKf/wXSwPmET9DKcPeU2e0=; b=g20+EyGP9AvxddG+xUW+9AEUm8/0REdAr0DB9+HtKToO70jkscS2bM1W1qrCcYRcZtiSSW mAi4Ae4AvAl46dEjpcwzebPYeNGt2qqVl/ZQ4yPuCGwBoY3SE8JyzDZJg7DQS/Wd0BEPlU 6EL8CjDNkrmlf+lh8n43GEaOEb2XU00= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-L87-ln_FMa6BzS8tUYo5IA-1; Wed, 18 May 2022 20:39:07 -0400 X-MC-Unique: L87-ln_FMa6BzS8tUYo5IA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 021A48015BA; Thu, 19 May 2022 00:39:07 +0000 (UTC) Received: from localhost (ovpn-12-103.pek2.redhat.com [10.72.12.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD749492C3B; Thu, 19 May 2022 00:39:05 +0000 (UTC) Date: Thu, 19 May 2022 08:39:02 +0800 From: Baoquan He To: Heiko Carstens , akpm@linux-foundation.org, zohar@linux.ibm.com Cc: Coiby Xu , kexec@lists.infradead.org, keyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Suchanek , Dave Young , Will Deacon , "Eric W . Biederman" , Mimi Zohar , Chun-Yi Lee , stable@vger.kernel.org, Philipp Rudo , linux-security-module@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Martin Schwidefsky , "open list:S390" , open list Subject: Re: [PATCH v8 4/4] kexec, KEYS, s390: Make use of built-in and secondary keyring for signature verification Message-ID: <20220519003902.GE156677@MiWiFi-R3L-srv> References: <20220512070123.29486-1-coxu@redhat.com> <20220512070123.29486-5-coxu@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_173913_417522_8C2D2B30 X-CRM114-Status: GOOD ( 18.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/18/22 at 01:29pm, Heiko Carstens wrote: > On Thu, May 12, 2022 at 03:01:23PM +0800, Coiby Xu wrote: > > From: Michal Suchanek > > > > commit e23a8020ce4e ("s390/kexec_file: Signature verification prototype") > > adds support for KEXEC_SIG verification with keys from platform keyring > > but the built-in keys and secondary keyring are not used. > > > > Add support for the built-in keys and secondary keyring as x86 does. > > > > Fixes: e23a8020ce4e ("s390/kexec_file: Signature verification prototype") > > Cc: stable@vger.kernel.org > > Cc: Philipp Rudo > > Cc: kexec@lists.infradead.org > > Cc: keyrings@vger.kernel.org > > Cc: linux-security-module@vger.kernel.org > > Signed-off-by: Michal Suchanek > > Reviewed-by: "Lee, Chun-Yi" > > Acked-by: Baoquan He > > Signed-off-by: Coiby Xu > > --- > > arch/s390/kernel/machine_kexec_file.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > As far as I can tell this doesn't have any dependency to the other > patches in this series, so should I pick this up for the s390 tree, or > how will this go upstream? Thanks, Heiko. I want to ask Mimi if this can be taken into KEYS-ENCRYPTED tree. Otherwise I will ask Andrew to help pick this whole series. Surely, this patch 4 can be taken into s390 seperately since it's independent, both looks good. Thanks Baoquan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baoquan He Date: Thu, 19 May 2022 08:39:02 +0800 Subject: [PATCH v8 4/4] kexec, KEYS, s390: Make use of built-in and secondary keyring for signature verification In-Reply-To: References: <20220512070123.29486-1-coxu@redhat.com> <20220512070123.29486-5-coxu@redhat.com> Message-ID: <20220519003902.GE156677@MiWiFi-R3L-srv> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kexec@lists.infradead.org On 05/18/22 at 01:29pm, Heiko Carstens wrote: > On Thu, May 12, 2022 at 03:01:23PM +0800, Coiby Xu wrote: > > From: Michal Suchanek > > > > commit e23a8020ce4e ("s390/kexec_file: Signature verification prototype") > > adds support for KEXEC_SIG verification with keys from platform keyring > > but the built-in keys and secondary keyring are not used. > > > > Add support for the built-in keys and secondary keyring as x86 does. > > > > Fixes: e23a8020ce4e ("s390/kexec_file: Signature verification prototype") > > Cc: stable at vger.kernel.org > > Cc: Philipp Rudo > > Cc: kexec at lists.infradead.org > > Cc: keyrings at vger.kernel.org > > Cc: linux-security-module at vger.kernel.org > > Signed-off-by: Michal Suchanek > > Reviewed-by: "Lee, Chun-Yi" > > Acked-by: Baoquan He > > Signed-off-by: Coiby Xu > > --- > > arch/s390/kernel/machine_kexec_file.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > As far as I can tell this doesn't have any dependency to the other > patches in this series, so should I pick this up for the s390 tree, or > how will this go upstream? Thanks, Heiko. I want to ask Mimi if this can be taken into KEYS-ENCRYPTED tree. Otherwise I will ask Andrew to help pick this whole series. Surely, this patch 4 can be taken into s390 seperately since it's independent, both looks good. Thanks Baoquan