From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447DEC433FE for ; Thu, 19 May 2022 04:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232310AbiESExw (ORCPT ); Thu, 19 May 2022 00:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231965AbiESExv (ORCPT ); Thu, 19 May 2022 00:53:51 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A602B6D86E; Wed, 18 May 2022 21:53:48 -0700 (PDT) X-UUID: 62ccd5c15f0b4ce79265330646a3f7e4-20220519 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:35826532-d058-49d4-9326-f8f60b22eac7,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:e307bee2-edbf-4bd4-8a34-dfc5f7bb086d,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 62ccd5c15f0b4ce79265330646a3f7e4-20220519 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1331980739; Thu, 19 May 2022 12:53:41 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 19 May 2022 12:53:40 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 May 2022 12:53:39 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , <~postmarketos/upstreaming@lists.sr.ht> Subject: Re: [PATCH v2 7/7] clk: mediatek: Add MediaTek Helio X10 MT6795 clock drivers Date: Thu, 19 May 2022 12:53:40 +0800 Message-ID: <20220519045340.11198-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220518111652.223727-8-angelogioacchino.delregno@collabora.com> References: <20220518111652.223727-8-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org Hi Angelo, >Add the clock drivers for the entire clock tree of MediaTek Helio X10 >MT6795, including system clocks (apmixedsys, infracfg, pericfg, topckgen) >and multimedia clocks (mmsys, mfg, vdecsys, vencsys). > >Signed-off-by: AngeloGioacchino Del Regno >--- > drivers/clk/mediatek/Kconfig | 37 ++ > drivers/clk/mediatek/Makefile | 6 + > drivers/clk/mediatek/clk-mt6795-apmixedsys.c | 157 +++++ > drivers/clk/mediatek/clk-mt6795-infracfg.c | 148 +++++ > drivers/clk/mediatek/clk-mt6795-mfg.c | 50 ++ > drivers/clk/mediatek/clk-mt6795-mm.c | 106 ++++ > drivers/clk/mediatek/clk-mt6795-pericfg.c | 160 +++++ > drivers/clk/mediatek/clk-mt6795-topckgen.c | 611 +++++++++++++++++++ > drivers/clk/mediatek/clk-mt6795-vdecsys.c | 55 ++ > drivers/clk/mediatek/clk-mt6795-vencsys.c | 50 ++ > 10 files changed, 1380 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt6795-apmixedsys.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-infracfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-mfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-mm.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-pericfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-topckgen.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-vdecsys.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-vencsys.c > >diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig >index d5936cfb3bee..da8142dff3c3 100644 >--- a/drivers/clk/mediatek/Kconfig >+++ b/drivers/clk/mediatek/Kconfig >@@ -259,6 +259,43 @@ config COMMON_CLK_MT6779_AUDSYS > help > This driver supports Mediatek MT6779 audsys clocks. > >+config COMMON_CLK_MT6795 >+ tristate "Clock driver for MediaTek MT6795" >+ depends on ARCH_MEDIATEK || COMPILE_TEST >+ select COMMON_CLK_MEDIATEK >+ default ARCH_MEDIATEK >+ help >+ This driver supports MediaTek MT6795 basic clocks and clocks >+ required for various peripherals found on MediaTek. Thanks for doing this, I was wondering if we can use only COMMON_CLK_MT6795 to build all clk-mt6795-*? like CONFIG_COMMON_CLK_MT8195 style: obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o \ clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o \ clk-mt8195-cam.o clk-mt8195-ccu.o clk-mt8195-img.o \ clk-mt8195-ipe.o clk-mt8195-mfg.o clk-mt8195-scp_adsp.o \ clk-mt8195-vdec.o clk-mt8195-vdo0.o clk-mt8195-vdo1.o \ clk-mt8195-venc.o clk-mt8195-vpp0.o clk-mt8195-vpp1.o \ clk-mt8195-wpe.o clk-mt8195-imp_iic_wrap.o \ clk-mt8195-apusys_pll.o So we do not have to keep other COMMON_CLK_MT6795_* configs. thanks, Miles >+ >+config COMMON_CLK_MT6795_MFGCFG >+ tristate "Clock driver for MediaTek MT6795 mfgcfg" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 mfgcfg clocks. >+ >+config COMMON_CLK_MT6795_MMSYS >+ tristate "Clock driver for MediaTek MT6795 mmsys" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 mmsys clocks. >+ >+config COMMON_CLK_MT6795_VDECSYS >+ tristate "Clock driver for MediaTek MT6795 VDECSYS" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 vdecsys clocks. >+ >+config COMMON_CLK_MT6795_VENCSYS >+ tristate "Clock driver for MediaTek MT6795 VENCSYS" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 vencsys clocks. >+ > config COMMON_CLK_MT6797 > bool "Clock driver for MediaTek MT6797" > depends on (ARCH_MEDIATEK && ARM64) || COMPILE_TEST >diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile >index caf2ce93d666..57f0bf90e934 100644 >--- a/drivers/clk/mediatek/Makefile >+++ b/drivers/clk/mediatek/Makefile >@@ -17,6 +17,12 @@ obj-$(CONFIG_COMMON_CLK_MT6779_VDECSYS) += clk-mt6779-vdec.o > obj-$(CONFIG_COMMON_CLK_MT6779_VENCSYS) += clk-mt6779-venc.o > obj-$(CONFIG_COMMON_CLK_MT6779_MFGCFG) += clk-mt6779-mfg.o > obj-$(CONFIG_COMMON_CLK_MT6779_AUDSYS) += clk-mt6779-aud.o >+obj-$(CONFIG_COMMON_CLK_MT6795) += clk-mt6795-apmixedsys.o clk-mt6795-infracfg.o \ >+ clk-mt6795-pericfg.o clk-mt6795-topckgen.o >+obj-$(CONFIG_COMMON_CLK_MT6795_MFGCFG) += clk-mt6795-mfg.o >+obj-$(CONFIG_COMMON_CLK_MT6795_MMSYS) += clk-mt6795-mm.o >+obj-$(CONFIG_COMMON_CLK_MT6795_VDECSYS) += clk-mt6795-vdecsys.o >+obj-$(CONFIG_COMMON_CLK_MT6795_VENCSYS) += clk-mt6795-vencsys.o > obj-$(CONFIG_COMMON_CLK_MT6797) += clk-mt6797.o > obj-$(CONFIG_COMMON_CLK_MT6797_IMGSYS) += clk-mt6797-img.o > obj-$(CONFIG_COMMON_CLK_MT6797_MMSYS) += clk-mt6797-mm.o >diff --git a/drivers/clk/mediatek/clk-mt6795-apmixedsys.c b/drivers/clk/mediatek/clk-mt6795-apmixedsys.c >new file mode 100644 >index 000000000000..766e83765cbb >--- /dev/null >+++ b/drivers/clk/mediatek/clk-mt6795-apmixedsys.c >@@ -0,0 +1,157 @@ >+// SPDX-License-Identifier: GPL-2.0-only >+/* From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A16AAC433EF for ; Thu, 19 May 2022 04:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wZ+TlZEYnKp8qx7drir5878Ez3SpYB3LTWvigqJO3Zc=; b=UWqzu9AL58JJBi HUaX/8HJStL2x0muGqIqewcUgPmFanayWIEdsUnUjdsPXF7pSp5Tv/bjfNew/NIZmZRxUNTQd75DT ILE6Z7T0Kzq7e6AsCQEpjaVfe3ZfSp7S/yQQxcyDDZLY4HjtHGTxykHF+Eih49AJTc1NiNJjfqDfA BzxSP/WdhzuEgX8V11PR2vYjB8vQ29UlKeCeT4W3q2xkFlDP2P/pWoezh2ozxd4tQduGCTln2dmll u6zeILg/LNHenk4UM+Gz9HLpzK+dyrcAdwFBAUFXARLMfxxLcOPYE3kZyExSrzX6HovhteZBbwUPt IdRgl/SfB9aPn6iMK4oA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrYAe-005116-1R; Thu, 19 May 2022 04:53:56 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrYAS-0050yd-Pc; Thu, 19 May 2022 04:53:46 +0000 X-UUID: f46292a02d9a43b1af89c2e052f966ad-20220518 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:59da69ec-eb2e-4362-94de-b0eee2146fdc, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09, CLOUDID:bb16ce79-5ef6-470b-96c9-bdb8ced32786, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: f46292a02d9a43b1af89c2e052f966ad-20220518 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1796346257; Wed, 18 May 2022 21:53:43 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 18 May 2022 21:53:41 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 19 May 2022 12:53:40 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 May 2022 12:53:39 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , <~postmarketos/upstreaming@lists.sr.ht> Subject: Re: [PATCH v2 7/7] clk: mediatek: Add MediaTek Helio X10 MT6795 clock drivers Date: Thu, 19 May 2022 12:53:40 +0800 Message-ID: <20220519045340.11198-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220518111652.223727-8-angelogioacchino.delregno@collabora.com> References: <20220518111652.223727-8-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_215344_911519_E2B26DDC X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Angelo, >Add the clock drivers for the entire clock tree of MediaTek Helio X10 >MT6795, including system clocks (apmixedsys, infracfg, pericfg, topckgen) >and multimedia clocks (mmsys, mfg, vdecsys, vencsys). > >Signed-off-by: AngeloGioacchino Del Regno >--- > drivers/clk/mediatek/Kconfig | 37 ++ > drivers/clk/mediatek/Makefile | 6 + > drivers/clk/mediatek/clk-mt6795-apmixedsys.c | 157 +++++ > drivers/clk/mediatek/clk-mt6795-infracfg.c | 148 +++++ > drivers/clk/mediatek/clk-mt6795-mfg.c | 50 ++ > drivers/clk/mediatek/clk-mt6795-mm.c | 106 ++++ > drivers/clk/mediatek/clk-mt6795-pericfg.c | 160 +++++ > drivers/clk/mediatek/clk-mt6795-topckgen.c | 611 +++++++++++++++++++ > drivers/clk/mediatek/clk-mt6795-vdecsys.c | 55 ++ > drivers/clk/mediatek/clk-mt6795-vencsys.c | 50 ++ > 10 files changed, 1380 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt6795-apmixedsys.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-infracfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-mfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-mm.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-pericfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-topckgen.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-vdecsys.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-vencsys.c > >diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig >index d5936cfb3bee..da8142dff3c3 100644 >--- a/drivers/clk/mediatek/Kconfig >+++ b/drivers/clk/mediatek/Kconfig >@@ -259,6 +259,43 @@ config COMMON_CLK_MT6779_AUDSYS > help > This driver supports Mediatek MT6779 audsys clocks. > >+config COMMON_CLK_MT6795 >+ tristate "Clock driver for MediaTek MT6795" >+ depends on ARCH_MEDIATEK || COMPILE_TEST >+ select COMMON_CLK_MEDIATEK >+ default ARCH_MEDIATEK >+ help >+ This driver supports MediaTek MT6795 basic clocks and clocks >+ required for various peripherals found on MediaTek. Thanks for doing this, I was wondering if we can use only COMMON_CLK_MT6795 to build all clk-mt6795-*? like CONFIG_COMMON_CLK_MT8195 style: obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o \ clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o \ clk-mt8195-cam.o clk-mt8195-ccu.o clk-mt8195-img.o \ clk-mt8195-ipe.o clk-mt8195-mfg.o clk-mt8195-scp_adsp.o \ clk-mt8195-vdec.o clk-mt8195-vdo0.o clk-mt8195-vdo1.o \ clk-mt8195-venc.o clk-mt8195-vpp0.o clk-mt8195-vpp1.o \ clk-mt8195-wpe.o clk-mt8195-imp_iic_wrap.o \ clk-mt8195-apusys_pll.o So we do not have to keep other COMMON_CLK_MT6795_* configs. thanks, Miles >+ >+config COMMON_CLK_MT6795_MFGCFG >+ tristate "Clock driver for MediaTek MT6795 mfgcfg" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 mfgcfg clocks. >+ >+config COMMON_CLK_MT6795_MMSYS >+ tristate "Clock driver for MediaTek MT6795 mmsys" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 mmsys clocks. >+ >+config COMMON_CLK_MT6795_VDECSYS >+ tristate "Clock driver for MediaTek MT6795 VDECSYS" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 vdecsys clocks. >+ >+config COMMON_CLK_MT6795_VENCSYS >+ tristate "Clock driver for MediaTek MT6795 VENCSYS" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 vencsys clocks. >+ > config COMMON_CLK_MT6797 > bool "Clock driver for MediaTek MT6797" > depends on (ARCH_MEDIATEK && ARM64) || COMPILE_TEST >diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile >index caf2ce93d666..57f0bf90e934 100644 >--- a/drivers/clk/mediatek/Makefile >+++ b/drivers/clk/mediatek/Makefile >@@ -17,6 +17,12 @@ obj-$(CONFIG_COMMON_CLK_MT6779_VDECSYS) += clk-mt6779-vdec.o > obj-$(CONFIG_COMMON_CLK_MT6779_VENCSYS) += clk-mt6779-venc.o > obj-$(CONFIG_COMMON_CLK_MT6779_MFGCFG) += clk-mt6779-mfg.o > obj-$(CONFIG_COMMON_CLK_MT6779_AUDSYS) += clk-mt6779-aud.o >+obj-$(CONFIG_COMMON_CLK_MT6795) += clk-mt6795-apmixedsys.o clk-mt6795-infracfg.o \ >+ clk-mt6795-pericfg.o clk-mt6795-topckgen.o >+obj-$(CONFIG_COMMON_CLK_MT6795_MFGCFG) += clk-mt6795-mfg.o >+obj-$(CONFIG_COMMON_CLK_MT6795_MMSYS) += clk-mt6795-mm.o >+obj-$(CONFIG_COMMON_CLK_MT6795_VDECSYS) += clk-mt6795-vdecsys.o >+obj-$(CONFIG_COMMON_CLK_MT6795_VENCSYS) += clk-mt6795-vencsys.o > obj-$(CONFIG_COMMON_CLK_MT6797) += clk-mt6797.o > obj-$(CONFIG_COMMON_CLK_MT6797_IMGSYS) += clk-mt6797-img.o > obj-$(CONFIG_COMMON_CLK_MT6797_MMSYS) += clk-mt6797-mm.o >diff --git a/drivers/clk/mediatek/clk-mt6795-apmixedsys.c b/drivers/clk/mediatek/clk-mt6795-apmixedsys.c >new file mode 100644 >index 000000000000..766e83765cbb >--- /dev/null >+++ b/drivers/clk/mediatek/clk-mt6795-apmixedsys.c >@@ -0,0 +1,157 @@ >+// SPDX-License-Identifier: GPL-2.0-only >+/* _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B582C433F5 for ; Thu, 19 May 2022 04:54:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tqNDhD0fCPOcp/fBNyUcpzIkKx4xPkE6R/iY5XX5iak=; b=SbEa5rO0F4gy21 0CmtXLfERitHWJUtM22u303/aACUYTckNEZ20X44RCceF5j4vdne2Zpfj1M4OBiC9n24LOe1kkqk0 nyioio35M/1u1HuyMS0HGg6kHFM84gVp2Lehy0FgTvzbw1tkC1LOuArNTN6uBVssUTzI/SUZR2+9Y WPhQmxHmuWPxFPFdgA6wmJqYVkOXj2q8MuvBXFzS8btvW/txjKFOYnvteQQpCYq7JDsV6FtFT7l8E c0oNb0vDW/Qd96cI6Eh5LgLBUgYd3wNUQBtrv+A+hONrYsRmS6AiccVJuNM1vPITsJy6xvbwpzzLq mG5VXsl4Eos9xZBWh45A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrYAW-0050zR-5P; Thu, 19 May 2022 04:53:48 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrYAS-0050yd-Pc; Thu, 19 May 2022 04:53:46 +0000 X-UUID: f46292a02d9a43b1af89c2e052f966ad-20220518 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:59da69ec-eb2e-4362-94de-b0eee2146fdc, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09, CLOUDID:bb16ce79-5ef6-470b-96c9-bdb8ced32786, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: f46292a02d9a43b1af89c2e052f966ad-20220518 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1796346257; Wed, 18 May 2022 21:53:43 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 18 May 2022 21:53:41 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 19 May 2022 12:53:40 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 19 May 2022 12:53:39 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , <~postmarketos/upstreaming@lists.sr.ht> Subject: Re: [PATCH v2 7/7] clk: mediatek: Add MediaTek Helio X10 MT6795 clock drivers Date: Thu, 19 May 2022 12:53:40 +0800 Message-ID: <20220519045340.11198-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220518111652.223727-8-angelogioacchino.delregno@collabora.com> References: <20220518111652.223727-8-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_215344_911519_E2B26DDC X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo, >Add the clock drivers for the entire clock tree of MediaTek Helio X10 >MT6795, including system clocks (apmixedsys, infracfg, pericfg, topckgen) >and multimedia clocks (mmsys, mfg, vdecsys, vencsys). > >Signed-off-by: AngeloGioacchino Del Regno >--- > drivers/clk/mediatek/Kconfig | 37 ++ > drivers/clk/mediatek/Makefile | 6 + > drivers/clk/mediatek/clk-mt6795-apmixedsys.c | 157 +++++ > drivers/clk/mediatek/clk-mt6795-infracfg.c | 148 +++++ > drivers/clk/mediatek/clk-mt6795-mfg.c | 50 ++ > drivers/clk/mediatek/clk-mt6795-mm.c | 106 ++++ > drivers/clk/mediatek/clk-mt6795-pericfg.c | 160 +++++ > drivers/clk/mediatek/clk-mt6795-topckgen.c | 611 +++++++++++++++++++ > drivers/clk/mediatek/clk-mt6795-vdecsys.c | 55 ++ > drivers/clk/mediatek/clk-mt6795-vencsys.c | 50 ++ > 10 files changed, 1380 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt6795-apmixedsys.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-infracfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-mfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-mm.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-pericfg.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-topckgen.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-vdecsys.c > create mode 100644 drivers/clk/mediatek/clk-mt6795-vencsys.c > >diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig >index d5936cfb3bee..da8142dff3c3 100644 >--- a/drivers/clk/mediatek/Kconfig >+++ b/drivers/clk/mediatek/Kconfig >@@ -259,6 +259,43 @@ config COMMON_CLK_MT6779_AUDSYS > help > This driver supports Mediatek MT6779 audsys clocks. > >+config COMMON_CLK_MT6795 >+ tristate "Clock driver for MediaTek MT6795" >+ depends on ARCH_MEDIATEK || COMPILE_TEST >+ select COMMON_CLK_MEDIATEK >+ default ARCH_MEDIATEK >+ help >+ This driver supports MediaTek MT6795 basic clocks and clocks >+ required for various peripherals found on MediaTek. Thanks for doing this, I was wondering if we can use only COMMON_CLK_MT6795 to build all clk-mt6795-*? like CONFIG_COMMON_CLK_MT8195 style: obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o \ clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o \ clk-mt8195-cam.o clk-mt8195-ccu.o clk-mt8195-img.o \ clk-mt8195-ipe.o clk-mt8195-mfg.o clk-mt8195-scp_adsp.o \ clk-mt8195-vdec.o clk-mt8195-vdo0.o clk-mt8195-vdo1.o \ clk-mt8195-venc.o clk-mt8195-vpp0.o clk-mt8195-vpp1.o \ clk-mt8195-wpe.o clk-mt8195-imp_iic_wrap.o \ clk-mt8195-apusys_pll.o So we do not have to keep other COMMON_CLK_MT6795_* configs. thanks, Miles >+ >+config COMMON_CLK_MT6795_MFGCFG >+ tristate "Clock driver for MediaTek MT6795 mfgcfg" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 mfgcfg clocks. >+ >+config COMMON_CLK_MT6795_MMSYS >+ tristate "Clock driver for MediaTek MT6795 mmsys" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 mmsys clocks. >+ >+config COMMON_CLK_MT6795_VDECSYS >+ tristate "Clock driver for MediaTek MT6795 VDECSYS" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 vdecsys clocks. >+ >+config COMMON_CLK_MT6795_VENCSYS >+ tristate "Clock driver for MediaTek MT6795 VENCSYS" >+ depends on COMMON_CLK_MT6795 >+ default COMMON_CLK_MT6795 >+ help >+ This driver supports MediaTek MT6795 vencsys clocks. >+ > config COMMON_CLK_MT6797 > bool "Clock driver for MediaTek MT6797" > depends on (ARCH_MEDIATEK && ARM64) || COMPILE_TEST >diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile >index caf2ce93d666..57f0bf90e934 100644 >--- a/drivers/clk/mediatek/Makefile >+++ b/drivers/clk/mediatek/Makefile >@@ -17,6 +17,12 @@ obj-$(CONFIG_COMMON_CLK_MT6779_VDECSYS) += clk-mt6779-vdec.o > obj-$(CONFIG_COMMON_CLK_MT6779_VENCSYS) += clk-mt6779-venc.o > obj-$(CONFIG_COMMON_CLK_MT6779_MFGCFG) += clk-mt6779-mfg.o > obj-$(CONFIG_COMMON_CLK_MT6779_AUDSYS) += clk-mt6779-aud.o >+obj-$(CONFIG_COMMON_CLK_MT6795) += clk-mt6795-apmixedsys.o clk-mt6795-infracfg.o \ >+ clk-mt6795-pericfg.o clk-mt6795-topckgen.o >+obj-$(CONFIG_COMMON_CLK_MT6795_MFGCFG) += clk-mt6795-mfg.o >+obj-$(CONFIG_COMMON_CLK_MT6795_MMSYS) += clk-mt6795-mm.o >+obj-$(CONFIG_COMMON_CLK_MT6795_VDECSYS) += clk-mt6795-vdecsys.o >+obj-$(CONFIG_COMMON_CLK_MT6795_VENCSYS) += clk-mt6795-vencsys.o > obj-$(CONFIG_COMMON_CLK_MT6797) += clk-mt6797.o > obj-$(CONFIG_COMMON_CLK_MT6797_IMGSYS) += clk-mt6797-img.o > obj-$(CONFIG_COMMON_CLK_MT6797_MMSYS) += clk-mt6797-mm.o >diff --git a/drivers/clk/mediatek/clk-mt6795-apmixedsys.c b/drivers/clk/mediatek/clk-mt6795-apmixedsys.c >new file mode 100644 >index 000000000000..766e83765cbb >--- /dev/null >+++ b/drivers/clk/mediatek/clk-mt6795-apmixedsys.c >@@ -0,0 +1,157 @@ >+// SPDX-License-Identifier: GPL-2.0-only >+/* _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel