From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A536DC433FE for ; Thu, 19 May 2022 07:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230062AbiESHjQ (ORCPT ); Thu, 19 May 2022 03:39:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiESHjP (ORCPT ); Thu, 19 May 2022 03:39:15 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEDD0A7E2A; Thu, 19 May 2022 00:39:14 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4EA2668AFE; Thu, 19 May 2022 09:39:12 +0200 (CEST) Date: Thu, 19 May 2022 09:39:12 +0200 From: Christoph Hellwig To: Keith Busch Cc: Eric Biggers , Keith Busch , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, Kernel Team , hch@lst.de, bvanassche@acm.org, damien.lemoal@opensource.wdc.com Subject: Re: [PATCHv2 3/3] block: relax direct io memory alignment Message-ID: <20220519073912.GF22301@lst.de> References: <20220518171131.3525293-1-kbusch@fb.com> <20220518171131.3525293-4-kbusch@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, May 18, 2022 at 07:00:39PM -0600, Keith Busch wrote: > How? This patch ensures every segment is block size aligned. We can always > split a bio in the middle of a bvec for any lower level hardware constraints, > and I'm not finding any splitting criteria that would try to break a bio on a > non-block aligned boundary. Do you mean bio_vec with segment here? How do we ensure that?