From: kernel test robot <lkp@intel.com> To: Jisheng Zhang <jszhang@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Andrey Ryabinin <ryabinin.a.a@gmail.com>, Alexander Potapenko <glider@google.com>, Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov <dvyukov@google.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Alexandre Ghiti <alexandre.ghiti@canonical.com>, Anup Patel <anup@brainfault.org>, Atish Patra <atishp@rivosinc.com> Cc: kbuild-all@lists.01.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v3 2/2] riscv: turn pgtable_l4|[l5]_enabled to static key for RV64 Date: Fri, 20 May 2022 08:08:02 +0800 [thread overview] Message-ID: <202205200851.XPf3TixK-lkp@intel.com> (raw) In-Reply-To: <20220519155918.3882-3-jszhang@kernel.org> Hi Jisheng, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.18-rc7] [cannot apply to next-20220519] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Jisheng-Zhang/use-static-key-to-optimize-pgtable_l4_enabled/20220520-001459 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f993aed406eaf968ba3867a76bb46c95336a33d0 config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20220520/202205200851.XPf3TixK-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d052c69ebaf48ac2925d6f9fa033d9e394da1074 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jisheng-Zhang/use-static-key-to-optimize-pgtable_l4_enabled/20220520-001459 git checkout d052c69ebaf48ac2925d6f9fa033d9e394da1074 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from arch/riscv/include/asm/pgtable.h:112, from arch/riscv/include/asm/uaccess.h:12, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from fs/char_dev.c:9: arch/riscv/include/asm/pgtable-64.h: In function 'pgtable_l5_enabled': >> arch/riscv/include/asm/pgtable-64.h:19:13: error: implicit declaration of function 'static_branch_likely' [-Werror=implicit-function-declaration] 19 | if (static_branch_likely(&_pgtable_lx_ready)) | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from arch/riscv/include/asm/pgtable.h:112, from arch/riscv/include/asm/uaccess.h:12, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from include/uapi/linux/aio_abi.h:31, from include/linux/syscalls.h:77, from fs/d_path.c:2: arch/riscv/include/asm/pgtable-64.h: In function 'pgtable_l5_enabled': >> arch/riscv/include/asm/pgtable-64.h:19:13: error: implicit declaration of function 'static_branch_likely' [-Werror=implicit-function-declaration] 19 | if (static_branch_likely(&_pgtable_lx_ready)) | ^~~~~~~~~~~~~~~~~~~~ fs/d_path.c: At top level: fs/d_path.c:318:7: warning: no previous prototype for 'simple_dname' [-Wmissing-prototypes] 318 | char *simple_dname(struct dentry *dentry, char *buffer, int buflen) | ^~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from arch/riscv/include/asm/pgtable.h:112, from arch/riscv/include/asm/uaccess.h:12, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from include/uapi/linux/aio_abi.h:31, from include/linux/syscalls.h:77, from fs/io_uring.c:45: arch/riscv/include/asm/pgtable-64.h: In function 'pgtable_l5_enabled': >> arch/riscv/include/asm/pgtable-64.h:19:13: error: implicit declaration of function 'static_branch_likely' [-Werror=implicit-function-declaration] 19 | if (static_branch_likely(&_pgtable_lx_ready)) | ^~~~~~~~~~~~~~~~~~~~ fs/io_uring.c: In function '__io_submit_flush_completions': fs/io_uring.c:2660:40: warning: variable 'prev' set but not used [-Wunused-but-set-variable] 2660 | struct io_wq_work_node *node, *prev; | ^~~~ cc1: some warnings being treated as errors -- In file included from arch/riscv/include/asm/pgtable.h:112, from arch/riscv/include/asm/uaccess.h:12, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from fs/proc/meminfo.c:2: arch/riscv/include/asm/pgtable-64.h: In function 'pgtable_l5_enabled': >> arch/riscv/include/asm/pgtable-64.h:19:13: error: implicit declaration of function 'static_branch_likely' [-Werror=implicit-function-declaration] 19 | if (static_branch_likely(&_pgtable_lx_ready)) | ^~~~~~~~~~~~~~~~~~~~ fs/proc/meminfo.c: At top level: fs/proc/meminfo.c:22:28: warning: no previous prototype for 'arch_report_meminfo' [-Wmissing-prototypes] 22 | void __attribute__((weak)) arch_report_meminfo(struct seq_file *m) | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/static_branch_likely +19 arch/riscv/include/asm/pgtable-64.h 16 17 static __always_inline bool pgtable_l5_enabled(void) 18 { > 19 if (static_branch_likely(&_pgtable_lx_ready)) 20 return static_branch_likely(&_pgtable_l5_enabled); 21 else 22 return _pgtable_l5_enabled_early; 23 } 24 -- 0-DAY CI Kernel Test Service https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: Jisheng Zhang <jszhang@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Andrey Ryabinin <ryabinin.a.a@gmail.com>, Alexander Potapenko <glider@google.com>, Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov <dvyukov@google.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Alexandre Ghiti <alexandre.ghiti@canonical.com>, Anup Patel <anup@brainfault.org>, Atish Patra <atishp@rivosinc.com> Cc: kbuild-all@lists.01.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v3 2/2] riscv: turn pgtable_l4|[l5]_enabled to static key for RV64 Date: Fri, 20 May 2022 08:08:02 +0800 [thread overview] Message-ID: <202205200851.XPf3TixK-lkp@intel.com> (raw) In-Reply-To: <20220519155918.3882-3-jszhang@kernel.org> Hi Jisheng, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.18-rc7] [cannot apply to next-20220519] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Jisheng-Zhang/use-static-key-to-optimize-pgtable_l4_enabled/20220520-001459 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f993aed406eaf968ba3867a76bb46c95336a33d0 config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20220520/202205200851.XPf3TixK-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d052c69ebaf48ac2925d6f9fa033d9e394da1074 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jisheng-Zhang/use-static-key-to-optimize-pgtable_l4_enabled/20220520-001459 git checkout d052c69ebaf48ac2925d6f9fa033d9e394da1074 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from arch/riscv/include/asm/pgtable.h:112, from arch/riscv/include/asm/uaccess.h:12, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from fs/char_dev.c:9: arch/riscv/include/asm/pgtable-64.h: In function 'pgtable_l5_enabled': >> arch/riscv/include/asm/pgtable-64.h:19:13: error: implicit declaration of function 'static_branch_likely' [-Werror=implicit-function-declaration] 19 | if (static_branch_likely(&_pgtable_lx_ready)) | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from arch/riscv/include/asm/pgtable.h:112, from arch/riscv/include/asm/uaccess.h:12, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from include/uapi/linux/aio_abi.h:31, from include/linux/syscalls.h:77, from fs/d_path.c:2: arch/riscv/include/asm/pgtable-64.h: In function 'pgtable_l5_enabled': >> arch/riscv/include/asm/pgtable-64.h:19:13: error: implicit declaration of function 'static_branch_likely' [-Werror=implicit-function-declaration] 19 | if (static_branch_likely(&_pgtable_lx_ready)) | ^~~~~~~~~~~~~~~~~~~~ fs/d_path.c: At top level: fs/d_path.c:318:7: warning: no previous prototype for 'simple_dname' [-Wmissing-prototypes] 318 | char *simple_dname(struct dentry *dentry, char *buffer, int buflen) | ^~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from arch/riscv/include/asm/pgtable.h:112, from arch/riscv/include/asm/uaccess.h:12, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from include/uapi/linux/aio_abi.h:31, from include/linux/syscalls.h:77, from fs/io_uring.c:45: arch/riscv/include/asm/pgtable-64.h: In function 'pgtable_l5_enabled': >> arch/riscv/include/asm/pgtable-64.h:19:13: error: implicit declaration of function 'static_branch_likely' [-Werror=implicit-function-declaration] 19 | if (static_branch_likely(&_pgtable_lx_ready)) | ^~~~~~~~~~~~~~~~~~~~ fs/io_uring.c: In function '__io_submit_flush_completions': fs/io_uring.c:2660:40: warning: variable 'prev' set but not used [-Wunused-but-set-variable] 2660 | struct io_wq_work_node *node, *prev; | ^~~~ cc1: some warnings being treated as errors -- In file included from arch/riscv/include/asm/pgtable.h:112, from arch/riscv/include/asm/uaccess.h:12, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from fs/proc/meminfo.c:2: arch/riscv/include/asm/pgtable-64.h: In function 'pgtable_l5_enabled': >> arch/riscv/include/asm/pgtable-64.h:19:13: error: implicit declaration of function 'static_branch_likely' [-Werror=implicit-function-declaration] 19 | if (static_branch_likely(&_pgtable_lx_ready)) | ^~~~~~~~~~~~~~~~~~~~ fs/proc/meminfo.c: At top level: fs/proc/meminfo.c:22:28: warning: no previous prototype for 'arch_report_meminfo' [-Wmissing-prototypes] 22 | void __attribute__((weak)) arch_report_meminfo(struct seq_file *m) | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/static_branch_likely +19 arch/riscv/include/asm/pgtable-64.h 16 17 static __always_inline bool pgtable_l5_enabled(void) 18 { > 19 if (static_branch_likely(&_pgtable_lx_ready)) 20 return static_branch_likely(&_pgtable_l5_enabled); 21 else 22 return _pgtable_l5_enabled_early; 23 } 24 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-05-20 0:09 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-19 15:59 [PATCH v3 0/2] use static key to optimize pgtable_l4_enabled Jisheng Zhang 2022-05-19 15:59 ` Jisheng Zhang 2022-05-19 15:59 ` [PATCH v3 1/2] riscv: move sbi_init() earlier before jump_label_init() Jisheng Zhang 2022-05-19 15:59 ` Jisheng Zhang 2022-05-19 15:59 ` [PATCH v3 2/2] riscv: turn pgtable_l4|[l5]_enabled to static key for RV64 Jisheng Zhang 2022-05-19 15:59 ` Jisheng Zhang 2022-05-19 23:57 ` kernel test robot 2022-05-19 23:57 ` kernel test robot 2022-05-20 0:08 ` kernel test robot [this message] 2022-05-20 0:08 ` kernel test robot 2022-05-23 16:02 ` Anup Patel 2022-05-23 16:02 ` Anup Patel 2022-05-24 15:28 ` Jisheng Zhang 2022-05-24 15:28 ` Jisheng Zhang 2022-05-24 16:00 ` Anup Patel 2022-05-24 16:00 ` Anup Patel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202205200851.XPf3TixK-lkp@intel.com \ --to=lkp@intel.com \ --cc=alexandre.ghiti@canonical.com \ --cc=andreyknvl@gmail.com \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=atishp@rivosinc.com \ --cc=dvyukov@google.com \ --cc=glider@google.com \ --cc=jszhang@kernel.org \ --cc=kasan-dev@googlegroups.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=ryabinin.a.a@gmail.com \ --cc=vincenzo.frascino@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.