From: Slawomir Stepien <sst@poczta.fm>
To: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, przemyslaw.cencner@nokia.com,
krzysztof.adamski@nokia.com, alexander.sverdlin@nokia.com,
Slawomir Stepien <sst@poczta.fm>,
Slawomir Stepien <slawomir.stepien@nokia.com>
Subject: [PATCH 8/8] hwmon: (lm90) read the channel's offset from device-tree
Date: Fri, 20 May 2022 11:32:44 +0200 [thread overview]
Message-ID: <20220520093243.2523749-9-sst@poczta.fm> (raw)
In-Reply-To: <20220520093243.2523749-1-sst@poczta.fm>
From: Slawomir Stepien <slawomir.stepien@nokia.com>
Try to read the channel's offset from device-tree. Having offset in
device-tree node is not mandatory. The offset can only be set for remote
channels.
Signed-off-by: Slawomir Stepien <slawomir.stepien@nokia.com>
---
drivers/hwmon/lm90.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index e81cc21e525f..e4e7b4ddbfb6 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -1921,6 +1921,7 @@ static int lm90_probe_channel_from_dt(struct i2c_client *client,
struct lm90_data *data)
{
u32 id;
+ s32 val;
int err;
struct device *dev = &client->dev;
@@ -1944,6 +1945,25 @@ static int lm90_probe_channel_from_dt(struct i2c_client *client,
if (data->channel_label[id])
data->channel_config[id] |= HWMON_T_LABEL;
+ err = of_property_read_s32(child, "offset", &val);
+ if (!err) {
+ if (id == 0) {
+ dev_err(dev, "offset can't be set for internal channel\n");
+ return -EINVAL;
+ }
+
+ if (id == 1)
+ err = lm90_set_temp11(data, REMOTE_OFFSET, val);
+ else
+ err = lm90_set_temp11(data, REMOTE2_OFFSET, val);
+
+ if (err) {
+ dev_err(dev, "can't set offset %d for channel %d (%d)\n",
+ val, id, err);
+ return err;
+ }
+ }
+
return 0;
}
@@ -2091,6 +2111,12 @@ static int lm90_probe(struct i2c_client *client)
err = lm90_update_confreg(data, data->config | 0x04);
if (err)
return err;
+
+ /*
+ * In lm90_parse_dt_channel_info() we might set offset, so we need
+ * to use correct format indication before that
+ */
+ data->flags |= LM90_FLAG_ADT7461_EXT;
}
}
--
2.36.1
next prev parent reply other threads:[~2022-05-20 9:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 9:32 [PATCH 0/8] Add support for ADT7481 in lm90 Slawomir Stepien
2022-05-20 9:32 ` [PATCH 1/8] dt-bindings: hwmon: " Slawomir Stepien
2022-05-20 10:08 ` Krzysztof Kozlowski
2022-05-20 9:32 ` [PATCH 2/8] dt-bindings: hwmon: Add 'extended-range-enable' property support " Slawomir Stepien
2022-05-20 10:09 ` Krzysztof Kozlowski
2022-05-20 10:57 ` Slawomir Stepien
2022-05-20 9:32 ` [PATCH 3/8] dt-bindings: hwmon: Allow specifying channels for lm90 Slawomir Stepien
2022-05-20 10:13 ` Krzysztof Kozlowski
2022-05-20 12:38 ` Slawomir Stepien
2022-05-20 12:47 ` Krzysztof Kozlowski
2022-05-20 13:23 ` Slawomir Stepien
2022-05-20 13:34 ` Krzysztof Kozlowski
2022-05-20 14:02 ` Guenter Roeck
2022-05-20 13:42 ` Guenter Roeck
2022-05-20 14:09 ` Krzysztof Kozlowski
2022-05-20 14:22 ` Guenter Roeck
2022-05-24 11:53 ` Slawomir Stepien
2022-05-24 12:17 ` Slawomir Stepien
2022-05-24 17:27 ` Slawomir Stepien
2022-05-24 17:59 ` Krzysztof Kozlowski
2022-05-25 7:07 ` Slawomir Stepien
2022-05-20 9:32 ` [PATCH 4/8] hwmon: (lm90) add support for ADT7481 Slawomir Stepien
2022-05-20 9:32 ` [PATCH 5/8] hwmon: (lm90) define maximum number of channels that are supported Slawomir Stepien
2022-05-21 2:36 ` Guenter Roeck
2022-05-22 14:59 ` Slawomir Stepien
2022-05-20 9:32 ` [PATCH 6/8] hwmon: (lm90) enable the extended temperature range Slawomir Stepien
2022-05-20 9:32 ` [PATCH 7/8] hwmon: (lm90) read the channel's label from device-tree Slawomir Stepien
2022-05-20 10:15 ` Krzysztof Kozlowski
2022-05-20 11:01 ` Slawomir Stepien
2022-05-20 11:41 ` Krzysztof Kozlowski
2022-05-20 9:32 ` Slawomir Stepien [this message]
2022-05-20 13:45 ` [PATCH 0/8] Add support for ADT7481 in lm90 Guenter Roeck
2022-05-20 16:01 ` Guenter Roeck
2022-05-22 14:52 ` Slawomir Stepien
2022-05-22 15:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520093243.2523749-9-sst@poczta.fm \
--to=sst@poczta.fm \
--cc=alexander.sverdlin@nokia.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.adamski@nokia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=przemyslaw.cencner@nokia.com \
--cc=robh+dt@kernel.org \
--cc=slawomir.stepien@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.