From: Herve Codina <herve.codina@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clement Leger" <clement.leger@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032
Date: Fri, 20 May 2022 10:23:29 +0200 [thread overview]
Message-ID: <20220520102329.6b0a58d0@bootlin.com> (raw)
In-Reply-To: <29ba3db6-e5c7-06d3-29d9-918ee5b34555@linaro.org>
Hi Krzysztof,
On Sun, 1 May 2022 10:51:43 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
[...]
> > resets:
> > maxItems: 1
> > @@ -106,13 +106,45 @@ required:
> > - interrupt-map
> > - interrupt-map-mask
> > - clocks
> > - - resets
> > - power-domains
> > - bus-range
> > - "#address-cells"
> > - "#size-cells"
> > - "#interrupt-cells"
> >
> > +if:
>
> allOf.
>
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
I Have an issue with this allOf.
The yaml has the following structure and so has 2 AllOf:
...
allOf:
- $ref: /schemas/pci/pci-bus.yaml#
properties:
compatible:
...
allOf:
- if:
properties:
compatible:
contains:
...
make dt_binding_check failed with the following error:
$ make dt_binding_check DT_SCHEMA_FILES=renesas,pci-rcar-gen2.yaml
LINT Documentation/devicetree/bindings
./Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml:115:1: [error] duplication of key "allOf" in mapping (key-duplicates)
CHKDT Documentation/devicetree/bindings/processed-schema.json
Traceback (most recent call last):
File "/home/hcodina/.local/bin/dt-doc-validate", line 25, in check_doc
testtree = dtschema.load(filename, line_number=line_number)
File "/home/hcodina/.local/lib/python3.10/site-packages/dtschema/lib.py", line 912, in load
return yaml.load(f.read())
File "/home/hcodina/.local/lib/python3.10/site-packages/ruamel/yaml/main.py", line 434, in load
return constructor.get_single_data()
File "/home/hcodina/.local/lib/python3.10/site-packages/ruamel/yaml/constructor.py", line 121, in get_single_data
return self.construct_document(node)
File "/home/hcodina/.local/lib/python3.10/site-packages/ruamel/yaml/constructor.py", line 131, in construct_document
for _dummy in generator:
File "/home/hcodina/.local/lib/python3.10/site-packages/ruamel/yaml/constructor.py", line 674, in construct_yaml_map
value = self.construct_mapping(node)
File "/home/hcodina/.local/lib/python3.10/site-packages/ruamel/yaml/constructor.py", line 445, in construct_mapping
return BaseConstructor.construct_mapping(self, node, deep=deep)
File "/home/hcodina/.local/lib/python3.10/site-packages/ruamel/yaml/constructor.py", line 263, in construct_mapping
if self.check_mapping_key(node, key_node, mapping, key, value):
File "/home/hcodina/.local/lib/python3.10/site-packages/ruamel/yaml/constructor.py", line 294, in check_mapping_key
raise DuplicateKeyError(*args)
ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
in "<unicode string>", line 4, column 1
found duplicate key "allOf" with value "[]" (original value: "[]")
in "<unicode string>", line 115, column 1
To suppress this check see:
http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/hcodina/.local/bin/dt-doc-validate", line 74, in <module>
ret = check_doc(f)
File "/home/hcodina/.local/bin/dt-doc-validate", line 30, in check_doc
print(filename + ":", exc.path[-1], exc.message, file=sys.stderr)
AttributeError: 'DuplicateKeyError' object has no attribute 'path'
SCHEMA Documentation/devicetree/bindings/processed-schema.json
/home/hcodina/project/xxxx/dev/linux/upstream_usb_host/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml: ignoring, error parsing file
DTEX Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.example.dts
Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml: found duplicate key "allOf" with value "[]" (original value: "[]")
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.example.dts] Error 1
make[1]: *** Deleting file 'Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.example.dts'
make: *** [Makefile:1401: dt_binding_check] Error 2
[hcodina@localhost upstream_usb_host]$
[hcodina@localhost upstream_usb_host]$ make ARCH=arm CROSS_COMPILE=/home/hcodina/toolchain/gcc-linaro-7.5.0-2019.12-x86_64_arm-linux-gnueabihf/bin/arm-linux-gnueabihf- dt_binding_check DT_SCHEMA_FILES=renesas,pci-rcar-gen2.yaml
DTEX Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.example.dts
Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml: found duplicate key "allOf" with value "[]" (original value: "[]")
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.example.dts] Error 1
make[1]: *** Deleting file 'Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.example.dts'
make: *** [Makefile:1401: dt_binding_check] Error 2
Is having a 'allOf' for schemas inclusion and a 'allOf' for conditionnal
parts allowed ?
Regards,
Hervé
next prev parent reply other threads:[~2022-05-20 8:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 13:41 [PATCH v5 0/6] RZN1 USB Host support Herve Codina
2022-04-29 13:41 ` [PATCH v4 " Herve Codina
2022-04-29 13:41 ` [PATCH v5 1/6] dt-bindings: PCI: pci-rcar-gen2: Convert bindings to json-schema Herve Codina
2022-04-29 13:41 ` [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 Herve Codina
2022-05-01 8:51 ` Krzysztof Kozlowski
2022-05-02 9:19 ` Geert Uytterhoeven
2022-05-02 19:44 ` Rob Herring
2022-05-03 6:51 ` Geert Uytterhoeven
2022-05-03 9:29 ` Krzysztof Kozlowski
2022-05-03 9:37 ` Geert Uytterhoeven
2022-05-06 12:35 ` Herve Codina
2022-05-04 13:53 ` Rob Herring
2022-05-20 8:23 ` Herve Codina [this message]
2022-05-20 8:29 ` Geert Uytterhoeven
2022-05-20 8:31 ` Krzysztof Kozlowski
2022-04-29 13:41 ` [PATCH v5 3/6] PCI: rcar-gen2: Add RZ/N1 SOCs family compatible string Herve Codina
2022-05-11 9:42 ` Lorenzo Pieralisi
2022-05-11 12:05 ` Geert Uytterhoeven
2022-04-29 13:41 ` [PATCH v5 4/6] ARM: dts: r9a06g032: Add internal PCI bridge node Herve Codina
2022-04-29 13:41 ` [PATCH v5 5/6] ARM: dts: r9a06g032: Add USB PHY DT support Herve Codina
2022-04-29 13:41 ` [PATCH v5 6/6] ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520102329.6b0a58d0@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=thomas.petazzoni@bootlin.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.