From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0FBDC433EF for ; Fri, 20 May 2022 13:42:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A5CFF83F0A; Fri, 20 May 2022 15:42:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1653054148; bh=v4x3gKda55+bDGANSYoF3lPGlBigVk8Ceb9tmdwebvs=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=pqFfxVbhy/8glC31M+SLVPqFRN+iKSHKpyhcsmaTpI4iJmbYN7XPxy34aAWFmwIwf Xs/5wddF2K7DqLh9OLUJePkPuDiXB2vzhQ3BOaaBGoUfTGhc6MN0IYTkX7f7UcZbIe Q3kfgbY4jL91yvAVNEeVHO338q81I9LVRLIED/bm87X4RScAPL0ltCDf7aM6nicoVm samMH1tOqrPjrw809QL42iBDMjr3NeXTrJcSNvLGoLJzAXICTzTEjBXww9wKxv90+4 DdBOQinbZvEt2n0/Wd4TcDbzBqfLenr8l7q1rwUJeWtGP80BLe9LoeMSgvlIfc72gl kzBaEAx6Xz1wA== Received: by phobos.denx.de (Postfix, from userid 109) id C7B6783608; Fri, 20 May 2022 15:41:20 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DCBC983E73 for ; Fri, 20 May 2022 15:41:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4L4SYQ3sJGz1r0Pf; Fri, 20 May 2022 15:41:14 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4L4SYQ3mgcz1qqkC; Fri, 20 May 2022 15:41:14 +0200 (CEST) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id Hd95X4jNyKqo; Fri, 20 May 2022 15:41:13 +0200 (CEST) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Fri, 20 May 2022 15:41:13 +0200 (CEST) From: sbabic@denx.de X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 1621995 X-Patchwork-Delegate: sbabic@denx.de To: Rasmus Villemoes ,u-boot@lists.denx.de Subject: [PATCH] imx8m: fix reading of DDR4 MR registers In-reply-to: <20220425142248.235807-1-rasmus.villemoes@prevas.dk> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20220520134120.C7B6783608@phobos.denx.de> Date: Fri, 20 May 2022 15:41:15 +0200 (CEST) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean > I was trying to employ lpddr4_mr_read() to something similar to what > the imx8mm-cl-iot-gate board is doing for auto-detecting the RAM > type. However, the version in drivers/ddr/imx/imx8m/ddrphy_utils.c > differs from the private one used by that board in how it extracts the > byte value, and I was only getting zeroes. Adding a bit of debug > printf'ing gives me > tmp = 0x00ffff00 > tmp = 0x00070700 > tmp = 0x00000000 > tmp = 0x00101000 > and indeed I was expecting a (combined) value of 0xff070010 (0xff > being Manufacturer ID for Micron). I can't find any documentation that > says how the values are supposed to be read, but clearly the iot-gate > definition is the right one, both for its use case as well as my > imx8mp-based board. > So lift the private definition of lpddr4_mr_read() from the > imx8mm-cl-iot-gate board code to ddrphy_utils.c, and add a declaration > in the ddr.h header where e.g. get_trained_CDD() is already declared. > This has only been compile-tested for the imx8mm-cl-iot-gate > board (since I don't have the hardware), but since I've merely moved > its definition of lpddr4_mr_read(), I'd be surprised if it changed > anything for that board. > Signed-off-by: Rasmus Villemoes > Tested-by: Ying-Chun Liu (PaulLiu) > Reviewed-by: Fabio Estevam Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================