All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Raghav <pankydev8@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	patches@lists.linux.dev, amir73il@gmail.com, tytso@mit.edu,
	josef@toxicpanda.com, jmeneghi@redhat.com, jake@lwn.net
Subject: Re: [PATCH 3/4] playbooks: add a common playbook a git reset task for kdevops
Date: Fri, 20 May 2022 16:44:05 +0200	[thread overview]
Message-ID: <20220520144405.uzzejos24qizwa5c@quentin> (raw)
In-Reply-To: <20220513193831.4136212-4-mcgrof@kernel.org>

Hi Luis,

On Fri, May 13, 2022 at 12:38:30PM -0700, Luis Chamberlain wrote:
> Two playbooks share the concept of git cloning kdevops into
> the target nodes (guests, cloud hosts, baremetal hosts) so that
> expunge files can be used for avoiding tests. If you decide
> you want to change the URL for that git tree it may not be
> so obvious what to do.
> 
> Fortunately the solution is simple. You just tell ansible to use
> the new git tree URL. That's it. It won't remove the old directory
> and things work as expected.
> 
> But since we use the kdevops git tree on both fstests and blktests
> it is not so obvious to developers that the thing to do here is
> to just run 'make fstests' or 'make blktests' and even that is not
> as efficient as that will also re-clone the fstests or blktests
> tree respectively. When we just want to reset the kdevops git tree
> we currently have no semantics to specify that. But since this is
> a common post-deployment goal, just add a common playbook that let's
> us do common tasks.
> 
> All we need then is the kconfig logic to define when some commmon
> tasks might make sense. So to reset your kdevops git tree, all you
> have to do now is change the configuration for it, then run:
> 
> make
> make kdevops-git-reset
> 

While I do like the idea of having this option, I still do not
understand the main use case to have it as a separate make target.
Wouldn't the developer already put the custom kdevops tree with
CONFIG_WORKFLOW_KDEVOPS_GIT during the initial make menuconfig phase?

I am just trying to understand the usecase when someone wants to change
the kdevops tree after a test run. Maybe I am missing something here.
-- 
Pankaj Raghav

  reply	other threads:[~2022-05-20 14:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 19:38 [PATCH 0/4] kdevops: use linux-kdevops for the main tree Luis Chamberlain
2022-05-13 19:38 ` [PATCH 1/4] workflows/Kconfig: be consistent when enabling fstests or blktests Luis Chamberlain
2022-05-14  2:21   ` Bart Van Assche
2022-05-15 15:10     ` Luis Chamberlain
2022-05-13 19:38 ` [PATCH 2/4] kdevops: move generic kdevops variables to its own file Luis Chamberlain
2022-05-13 19:38 ` [PATCH 3/4] playbooks: add a common playbook a git reset task for kdevops Luis Chamberlain
2022-05-20 14:44   ` Pankaj Raghav [this message]
2022-05-23 17:38     ` Luis Chamberlain
2022-05-13 19:38 ` [PATCH 4/4] kdevops: make linux-kdevops the default tree Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520144405.uzzejos24qizwa5c@quentin \
    --to=pankydev8@gmail.com \
    --cc=amir73il@gmail.com \
    --cc=jake@lwn.net \
    --cc=jmeneghi@redhat.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.