From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D9CC433F5 for ; Fri, 20 May 2022 14:56:44 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E43C740222; Fri, 20 May 2022 16:56:43 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E170240156; Fri, 20 May 2022 16:56:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653058603; x=1684594603; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=wPdNb892BQGv+rU+TRR5ebp7ihcch19E4mARq2kQHHk=; b=FDWH/XV8HB7sUrTEZYq4usuHWcreZGZS5dzcDH+DXv85pAC10fGUa4bY L6qfx0DkTdN086UTwMygrGYZx3lDZ8sKNsfuWmRGB3CreT5rFtfCfIVe+ LNLg1rHoavvw5sfNAPKfCgGGlK1+aJ+aKmMEalThMKAbywt8JmVKGJ8UB epe3muG4glB4ib965EAfVgTrpUfXjcuWbOZh+NjUGRT/rsPJ0Yd28AuSU epdvClbiBml7d1J+DdJuFhlixbIFIb1e6+QAWjgN2hY6WsYNRFMMKo7sS GsHJ+fVQZxVGGwwMgKFR1tMxprlud7jDFLSkEA1UqMJREyvfA/GCcr4jQ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="359030972" X-IronPort-AV: E=Sophos;i="5.91,239,1647327600"; d="scan'208";a="359030972" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 07:56:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,239,1647327600"; d="scan'208";a="599257441" Received: from silpixa00401385.ir.intel.com (HELO silpixa00401385.ger.corp.intel.com.) ([10.237.223.87]) by orsmga008.jf.intel.com with ESMTP; 20 May 2022 07:56:39 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: stable@dpdk.org, weiyuanx.li@intel.com, xuemingx.zhang@intel.com, Bruce Richardson Subject: [PATCH 0/2] fix uncallable unit tests (Bugzilla 1002) Date: Fri, 20 May 2022 15:56:29 +0100 Message-Id: <20220520145631.137962-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The dump* unit tests are uncallable from our test framework because the command validation in the unit test binary is incorrect. Rather than trying to fix this directly in the binary, a better approach is to add command validation to the cmdline library - which already has 99% of what we need already - and use that from the test app. Bruce Richardson (2): cmdline: add function to verify valid commands test: use cmdline library to validate args app/test/commands.c | 11 ----------- app/test/test.c | 25 ++++++++----------------- lib/cmdline/cmdline_parse.c | 20 +++++++++++++++++--- lib/cmdline/cmdline_parse.h | 17 +++++++++++++++-- lib/cmdline/version.map | 3 +++ 5 files changed, 43 insertions(+), 33 deletions(-) -- 2.34.1