From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, weiyuanx.li@intel.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v2 0/2] fix uncallable unit tests (Bugzilla 1002)
Date: Fri, 20 May 2022 16:12:38 +0100 [thread overview]
Message-ID: <20220520151240.139566-1-bruce.richardson@intel.com> (raw)
In-Reply-To: <20220520145631.137962-1-bruce.richardson@intel.com>
The dump* unit tests are uncallable from our test framework because the command
validation in the unit test binary is incorrect. Rather than trying to fix this
directly in the binary, a better approach is to add command validation to the
cmdline library - which already has 99% of what we need already - and use that
from the test app.
V2:
* Fix checkpatch issues
Bruce Richardson (2):
cmdline: add function to verify valid commands
test: use cmdline library to validate args
app/test/commands.c | 11 -----------
app/test/test.c | 24 +++++++-----------------
lib/cmdline/cmdline_parse.c | 20 +++++++++++++++++---
lib/cmdline/cmdline_parse.h | 17 +++++++++++++++--
lib/cmdline/version.map | 3 +++
5 files changed, 42 insertions(+), 33 deletions(-)
--
2.34.1
next prev parent reply other threads:[~2022-05-20 15:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 14:56 [PATCH 0/2] fix uncallable unit tests (Bugzilla 1002) Bruce Richardson
2022-05-20 14:56 ` [PATCH 1/2] cmdline: add function to verify valid commands Bruce Richardson
2022-05-24 14:57 ` Ray Kinsella
2022-05-20 14:56 ` [PATCH 2/2] test: use cmdline library to validate args Bruce Richardson
2022-05-20 15:12 ` Bruce Richardson [this message]
2022-05-20 15:12 ` [PATCH v2 1/2] cmdline: add function to verify valid commands Bruce Richardson
2022-05-23 6:52 ` Li, WeiyuanX
2022-06-07 8:08 ` Olivier Matz
2022-06-10 14:08 ` Bruce Richardson
2022-06-10 14:21 ` Olivier Matz
2022-05-20 15:12 ` [PATCH v2 2/2] test: use cmdline library to validate args Bruce Richardson
2022-06-07 8:08 ` Olivier Matz
2022-06-10 14:24 ` [PATCH v3 0/2] fix uncallable unit tests (Bugzilla 1002) Bruce Richardson
2022-06-10 14:24 ` [PATCH v3 1/2] cmdline: add function to verify valid commands Bruce Richardson
2022-06-10 14:24 ` [PATCH v3 2/2] test: use cmdline library to validate args Bruce Richardson
2022-06-13 9:22 ` [PATCH v3 0/2] fix uncallable unit tests (Bugzilla 1002) David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520151240.139566-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=weiyuanx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.