* [v2 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec
@ 2022-05-20 16:10 ` Judy Hsiao
0 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:10 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
Put sound node and lpass_cpu node settings for boards that use rt5682
codec in the sc7280-herobrine-audio-rt5682.dtsi as there are different
choices of headset codec for herobrine projects. Common audio setting
for the internal speaker is in sc7280-herobrine.dtsi.
This series depends on:
"Add lpass pin control support for audio on sc7280 based targets" [1]
"Add soundcard support for sc7280 based platforms" [2]
[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638776
[2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=643589
Changes Since V1:
-- Remove sound-dai-cells in sound node.
-- Add dependency list.
-- Update patch subject.
Judy Hsiao (3):
arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi
in villager and herobrine-r1
.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++
.../qcom/sc7280-herobrine-herobrine-r1.dts | 1 +
.../dts/qcom/sc7280-herobrine-villager-r0.dts | 1 +
.../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++
4 files changed, 136 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply [flat|nested] 30+ messages in thread
* [v2 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec
@ 2022-05-20 16:10 ` Judy Hsiao
0 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:10 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
Put sound node and lpass_cpu node settings for boards that use rt5682
codec in the sc7280-herobrine-audio-rt5682.dtsi as there are different
choices of headset codec for herobrine projects. Common audio setting
for the internal speaker is in sc7280-herobrine.dtsi.
This series depends on:
"Add lpass pin control support for audio on sc7280 based targets" [1]
"Add soundcard support for sc7280 based platforms" [2]
[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638776
[2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=643589
Changes Since V1:
-- Remove sound-dai-cells in sound node.
-- Add dependency list.
-- Update patch subject.
Judy Hsiao (3):
arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi
in villager and herobrine-r1
.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++
.../qcom/sc7280-herobrine-herobrine-r1.dts | 1 +
.../dts/qcom/sc7280-herobrine-villager-r0.dts | 1 +
.../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++
4 files changed, 136 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
--
2.36.1.124.g0e6072fb45-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 16:10 ` Judy Hsiao
-1 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:10 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
1. Add drive strength property for mi2s1 on sc7280 based platforms.
2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 9cb1bc8ed6b5..6d8744e130b0 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -612,6 +612,20 @@ &dp_hot_plug_det {
bias-disable;
};
+&mi2s1_data0 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_sclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_ws {
+ drive-strength = <6>;
+};
+
&pcie1_clkreq_n {
bias-pull-up;
drive-strength = <2>;
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
@ 2022-05-20 16:10 ` Judy Hsiao
0 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:10 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
1. Add drive strength property for mi2s1 on sc7280 based platforms.
2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 9cb1bc8ed6b5..6d8744e130b0 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -612,6 +612,20 @@ &dp_hot_plug_det {
bias-disable;
};
+&mi2s1_data0 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_sclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_ws {
+ drive-strength = <6>;
+};
+
&pcie1_clkreq_n {
bias-pull-up;
drive-strength = <2>;
--
2.36.1.124.g0e6072fb45-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 16:10 ` Judy Hsiao
-1 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:10 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
Audio dtsi for sc7280 boards that using rt5682 headset codec:
1. Add dt nodes for sound card which use I2S playback and record
through rt5682s and I2S playback through max98357a.
2. Enable lpass cpu node and add pin control and dai-links.
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++
1 file changed, 120 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
new file mode 100644
index 000000000000..d83e99f1d417
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
@@ -0,0 +1,120 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ *
+ * This file defines the common audio settings for the child boards using rt5682 codec.
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+/ {
+ /* BOARD-SPECIFIC TOP LEVEL NODES */
+ sound: sound {
+ compatible = "google,sc7280-herobrine";
+ model = "sc7280-rt5682-max98360a-1mic";
+
+ status = "okay";
+ audio-routing =
+ "Headphone Jack", "HPOL",
+ "Headphone Jack", "HPOR";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dai-link@0 {
+ link-name = "MAX98360";
+ reg = <0>;
+
+ cpu {
+ sound-dai = <&lpass_cpu MI2S_SECONDARY>;
+ };
+
+ codec {
+ sound-dai = <&max98360a>;
+ };
+ };
+
+ dai-link@1 {
+ link-name = "ALC5682";
+ reg = <1>;
+
+ cpu {
+ sound-dai = <&lpass_cpu MI2S_PRIMARY>;
+ };
+
+ codec {
+ sound-dai = <&alc5682 0 /* aif1 */>;
+ };
+ };
+ };
+};
+
+hp_i2c: &i2c2 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ alc5682: codec@1a {
+ compatible = "realtek,rt5682s";
+ reg = <0x1a>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&hp_irq>;
+
+ #sound-dai-cells = <1>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <101 IRQ_TYPE_EDGE_BOTH>;
+
+ AVDD-supply = <&pp1800_alc5682>;
+ MICVDD-supply = <&pp3300_codec>;
+
+ realtek,dmic1-data-pin = <1>;
+ realtek,dmic1-clk-pin = <2>;
+ realtek,jd-src = <1>;
+ realtek,dmic-clk-rate-hz = <2048000>;
+ };
+};
+
+&lpass_cpu {
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&mi2s0_data0 &mi2s0_data1 &mi2s0_mclk &mi2s0_sclk &mi2s0_ws
+ &mi2s1_data0 &mi2s1_sclk &mi2s1_ws>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dai-link@0 {
+ reg = <MI2S_PRIMARY>;
+ qcom,playback-sd-lines = <1>;
+ qcom,capture-sd-lines = <0>;
+ };
+
+ dai-link@1 {
+ reg = <MI2S_SECONDARY>;
+ qcom,playback-sd-lines = <0>;
+ };
+};
+
+&mi2s0_data0 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s0_data1 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s0_mclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s0_sclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s0_ws {
+ drive-strength = <6>;
+};
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
@ 2022-05-20 16:10 ` Judy Hsiao
0 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:10 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
Audio dtsi for sc7280 boards that using rt5682 headset codec:
1. Add dt nodes for sound card which use I2S playback and record
through rt5682s and I2S playback through max98357a.
2. Enable lpass cpu node and add pin control and dai-links.
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
.../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++
1 file changed, 120 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
new file mode 100644
index 000000000000..d83e99f1d417
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
@@ -0,0 +1,120 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ *
+ * This file defines the common audio settings for the child boards using rt5682 codec.
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+/ {
+ /* BOARD-SPECIFIC TOP LEVEL NODES */
+ sound: sound {
+ compatible = "google,sc7280-herobrine";
+ model = "sc7280-rt5682-max98360a-1mic";
+
+ status = "okay";
+ audio-routing =
+ "Headphone Jack", "HPOL",
+ "Headphone Jack", "HPOR";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dai-link@0 {
+ link-name = "MAX98360";
+ reg = <0>;
+
+ cpu {
+ sound-dai = <&lpass_cpu MI2S_SECONDARY>;
+ };
+
+ codec {
+ sound-dai = <&max98360a>;
+ };
+ };
+
+ dai-link@1 {
+ link-name = "ALC5682";
+ reg = <1>;
+
+ cpu {
+ sound-dai = <&lpass_cpu MI2S_PRIMARY>;
+ };
+
+ codec {
+ sound-dai = <&alc5682 0 /* aif1 */>;
+ };
+ };
+ };
+};
+
+hp_i2c: &i2c2 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ alc5682: codec@1a {
+ compatible = "realtek,rt5682s";
+ reg = <0x1a>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&hp_irq>;
+
+ #sound-dai-cells = <1>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <101 IRQ_TYPE_EDGE_BOTH>;
+
+ AVDD-supply = <&pp1800_alc5682>;
+ MICVDD-supply = <&pp3300_codec>;
+
+ realtek,dmic1-data-pin = <1>;
+ realtek,dmic1-clk-pin = <2>;
+ realtek,jd-src = <1>;
+ realtek,dmic-clk-rate-hz = <2048000>;
+ };
+};
+
+&lpass_cpu {
+ status = "okay";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&mi2s0_data0 &mi2s0_data1 &mi2s0_mclk &mi2s0_sclk &mi2s0_ws
+ &mi2s1_data0 &mi2s1_sclk &mi2s1_ws>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dai-link@0 {
+ reg = <MI2S_PRIMARY>;
+ qcom,playback-sd-lines = <1>;
+ qcom,capture-sd-lines = <0>;
+ };
+
+ dai-link@1 {
+ reg = <MI2S_SECONDARY>;
+ qcom,playback-sd-lines = <0>;
+ };
+};
+
+&mi2s0_data0 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s0_data1 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s0_mclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s0_sclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s0_ws {
+ drive-strength = <6>;
+};
--
2.36.1.124.g0e6072fb45-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [v2 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 16:10 ` Judy Hsiao
-1 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:10 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
Include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 as
these boards use rt5682 codec.
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts | 1 +
arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
index b69ca09d9bfb..f68d28f8701b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
@@ -8,6 +8,7 @@
/dts-v1/;
#include "sc7280-herobrine.dtsi"
+#include "sc7280-herobrine-audio-rt5682.dtsi"
/ {
model = "Google Herobrine (rev1+)";
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
index d3d6ffad4eff..7a4acd3b9ee3 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
@@ -8,6 +8,7 @@
/dts-v1/;
#include "sc7280-herobrine.dtsi"
+#include "sc7280-herobrine-audio-rt5682.dtsi"
/ {
model = "Google Villager (rev0+)";
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [v2 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1
@ 2022-05-20 16:10 ` Judy Hsiao
0 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:10 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
Include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 as
these boards use rt5682 codec.
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts | 1 +
arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
index b69ca09d9bfb..f68d28f8701b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
@@ -8,6 +8,7 @@
/dts-v1/;
#include "sc7280-herobrine.dtsi"
+#include "sc7280-herobrine-audio-rt5682.dtsi"
/ {
model = "Google Herobrine (rev1+)";
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
index d3d6ffad4eff..7a4acd3b9ee3 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
@@ -8,6 +8,7 @@
/dts-v1/;
#include "sc7280-herobrine.dtsi"
+#include "sc7280-herobrine-audio-rt5682.dtsi"
/ {
model = "Google Villager (rev0+)";
--
2.36.1.124.g0e6072fb45-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 17:27 ` Matthias Kaehlcke
-1 siblings, 0 replies; 30+ messages in thread
From: Matthias Kaehlcke @ 2022-05-20 17:27 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
dianders, cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel
On Fri, May 20, 2022 at 04:10:02PM +0000, Judy Hsiao wrote:
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
@ 2022-05-20 17:27 ` Matthias Kaehlcke
0 siblings, 0 replies; 30+ messages in thread
From: Matthias Kaehlcke @ 2022-05-20 17:27 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
dianders, cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel
On Fri, May 20, 2022 at 04:10:02PM +0000, Judy Hsiao wrote:
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 17:36 ` Matthias Kaehlcke
-1 siblings, 0 replies; 30+ messages in thread
From: Matthias Kaehlcke @ 2022-05-20 17:36 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
dianders, cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel
On Fri, May 20, 2022 at 04:10:03PM +0000, Judy Hsiao wrote:
> Audio dtsi for sc7280 boards that using rt5682 headset codec:
> 1. Add dt nodes for sound card which use I2S playback and record
> through rt5682s and I2S playback through max98357a.
> 2. Enable lpass cpu node and add pin control and dai-links.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++
> 1 file changed, 120 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> new file mode 100644
> index 000000000000..d83e99f1d417
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -0,0 +1,120 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + *
> + * This file defines the common audio settings for the child boards using rt5682 codec.
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +/ {
> + /* BOARD-SPECIFIC TOP LEVEL NODES */
> + sound: sound {
nit: the label might not be needed, unless we expect board files to override
settings. But well, there is also nothing inherently wrong with having it :)
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
@ 2022-05-20 17:36 ` Matthias Kaehlcke
0 siblings, 0 replies; 30+ messages in thread
From: Matthias Kaehlcke @ 2022-05-20 17:36 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
dianders, cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel
On Fri, May 20, 2022 at 04:10:03PM +0000, Judy Hsiao wrote:
> Audio dtsi for sc7280 boards that using rt5682 headset codec:
> 1. Add dt nodes for sound card which use I2S playback and record
> through rt5682s and I2S playback through max98357a.
> 2. Enable lpass cpu node and add pin control and dai-links.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++
> 1 file changed, 120 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> new file mode 100644
> index 000000000000..d83e99f1d417
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -0,0 +1,120 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + *
> + * This file defines the common audio settings for the child boards using rt5682 codec.
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +/ {
> + /* BOARD-SPECIFIC TOP LEVEL NODES */
> + sound: sound {
nit: the label might not be needed, unless we expect board files to override
settings. But well, there is also nothing inherently wrong with having it :)
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 17:59 ` Matthias Kaehlcke
-1 siblings, 0 replies; 30+ messages in thread
From: Matthias Kaehlcke @ 2022-05-20 17:59 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
dianders, cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel
On Fri, May 20, 2022 at 04:10:04PM +0000, Judy Hsiao wrote:
> Include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 as
> these boards use rt5682 codec.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
Please make sure to collect tags when sending new revisions, you already
had this for v1:
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1
@ 2022-05-20 17:59 ` Matthias Kaehlcke
0 siblings, 0 replies; 30+ messages in thread
From: Matthias Kaehlcke @ 2022-05-20 17:59 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
dianders, cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel
On Fri, May 20, 2022 at 04:10:04PM +0000, Judy Hsiao wrote:
> Include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 as
> these boards use rt5682 codec.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
Please make sure to collect tags when sending new revisions, you already
had this for v1:
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 20:38 ` Stephen Boyd
-1 siblings, 0 replies; 30+ messages in thread
From: Stephen Boyd @ 2022-05-20 20:38 UTC (permalink / raw)
To: Andy Gross, Judy Hsiao
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, linux-arm-kernel, linux-arm-msm,
devicetree, linux-kernel
Quoting Judy Hsiao (2022-05-20 09:10:02)
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
s/Disbale/Disable/
The commit text is a list of things done but no reason why they're done.
I'd appreciate more freeform text with a blurb why a drive strength is
chosen and why pulls are disabled.
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 9cb1bc8ed6b5..6d8744e130b0 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -612,6 +612,20 @@ &dp_hot_plug_det {
> bias-disable;
> };
>
> +&mi2s1_data0 {
> + drive-strength = <6>;
> + bias-disable;
Is there an external pull on this line?
> +};
> +
> +&mi2s1_sclk {
> + drive-strength = <6>;
> + bias-disable;
Is there an external pull on this line? If so please add that details as
a comment like we do for other external pulls.
> +};
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
@ 2022-05-20 20:38 ` Stephen Boyd
0 siblings, 0 replies; 30+ messages in thread
From: Stephen Boyd @ 2022-05-20 20:38 UTC (permalink / raw)
To: Andy Gross, Judy Hsiao
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, linux-arm-kernel, linux-arm-msm,
devicetree, linux-kernel
Quoting Judy Hsiao (2022-05-20 09:10:02)
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
s/Disbale/Disable/
The commit text is a list of things done but no reason why they're done.
I'd appreciate more freeform text with a blurb why a drive strength is
chosen and why pulls are disabled.
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 9cb1bc8ed6b5..6d8744e130b0 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -612,6 +612,20 @@ &dp_hot_plug_det {
> bias-disable;
> };
>
> +&mi2s1_data0 {
> + drive-strength = <6>;
> + bias-disable;
Is there an external pull on this line?
> +};
> +
> +&mi2s1_sclk {
> + drive-strength = <6>;
> + bias-disable;
Is there an external pull on this line? If so please add that details as
a comment like we do for other external pulls.
> +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
2022-05-20 20:38 ` Stephen Boyd
@ 2022-05-20 20:39 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 20:39 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Judy Hsiao, Bjorn Andersson, Rob Herring,
Srini Kandagatla, Matthias Kaehlcke, Jimmy Cheng-Yi Chiang,
Judy Hsiao, Tzung-Bi Shih, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 1:38 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Judy Hsiao (2022-05-20 09:10:02)
> > 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
>
> s/Disbale/Disable/
>
> The commit text is a list of things done but no reason why they're done.
> I'd appreciate more freeform text with a blurb why a drive strength is
> chosen and why pulls are disabled.
>
> > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > index 9cb1bc8ed6b5..6d8744e130b0 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > @@ -612,6 +612,20 @@ &dp_hot_plug_det {
> > bias-disable;
> > };
> >
> > +&mi2s1_data0 {
> > + drive-strength = <6>;
> > + bias-disable;
>
> Is there an external pull on this line?
>
> > +};
> > +
> > +&mi2s1_sclk {
> > + drive-strength = <6>;
> > + bias-disable;
>
> Is there an external pull on this line? If so please add that details as
> a comment like we do for other external pulls.
Actually, I think they are output lines, which is why they have a
drive-strength. I think for output lines we don't usually comment
about why we're disabling the pulls, only for input lines?
-Doug
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
@ 2022-05-20 20:39 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 20:39 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Judy Hsiao, Bjorn Andersson, Rob Herring,
Srini Kandagatla, Matthias Kaehlcke, Jimmy Cheng-Yi Chiang,
Judy Hsiao, Tzung-Bi Shih, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 1:38 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Judy Hsiao (2022-05-20 09:10:02)
> > 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
>
> s/Disbale/Disable/
>
> The commit text is a list of things done but no reason why they're done.
> I'd appreciate more freeform text with a blurb why a drive strength is
> chosen and why pulls are disabled.
>
> > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > index 9cb1bc8ed6b5..6d8744e130b0 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> > @@ -612,6 +612,20 @@ &dp_hot_plug_det {
> > bias-disable;
> > };
> >
> > +&mi2s1_data0 {
> > + drive-strength = <6>;
> > + bias-disable;
>
> Is there an external pull on this line?
>
> > +};
> > +
> > +&mi2s1_sclk {
> > + drive-strength = <6>;
> > + bias-disable;
>
> Is there an external pull on this line? If so please add that details as
> a comment like we do for other external pulls.
Actually, I think they are output lines, which is why they have a
drive-strength. I think for output lines we don't usually comment
about why we're disabling the pulls, only for input lines?
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 20:43 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 20:43 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
Matthias Kaehlcke, Jimmy Cheng-Yi Chiang, Judy Hsiao,
Tzung-Bi Shih, Stephen Boyd, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 9:10 AM Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 9cb1bc8ed6b5..6d8744e130b0 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -612,6 +612,20 @@ &dp_hot_plug_det {
> bias-disable;
> };
>
> +&mi2s1_data0 {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s1_sclk {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s1_ws {
> + drive-strength = <6>;
> +};
I'm actually curious why this line has a drive-strength but _no_ bias
setting. I guess I should figure out what the heck "ws" is. Ah, I
guess it is word select.
Since this is an output I'd expect to see "bias-disable" here too.
-Doug
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
@ 2022-05-20 20:43 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 20:43 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
Matthias Kaehlcke, Jimmy Cheng-Yi Chiang, Judy Hsiao,
Tzung-Bi Shih, Stephen Boyd, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 9:10 AM Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 9cb1bc8ed6b5..6d8744e130b0 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -612,6 +612,20 @@ &dp_hot_plug_det {
> bias-disable;
> };
>
> +&mi2s1_data0 {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s1_sclk {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s1_ws {
> + drive-strength = <6>;
> +};
I'm actually curious why this line has a drive-strength but _no_ bias
setting. I guess I should figure out what the heck "ws" is. Ah, I
guess it is word select.
Since this is an output I'd expect to see "bias-disable" here too.
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 20:49 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 20:49 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
Matthias Kaehlcke, Jimmy Cheng-Yi Chiang, Judy Hsiao,
Tzung-Bi Shih, Stephen Boyd, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 9:10 AM Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> Audio dtsi for sc7280 boards that using rt5682 headset codec:
> 1. Add dt nodes for sound card which use I2S playback and record
> through rt5682s and I2S playback through max98357a.
> 2. Enable lpass cpu node and add pin control and dai-links.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++
> 1 file changed, 120 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> new file mode 100644
> index 000000000000..d83e99f1d417
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -0,0 +1,120 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + *
> + * This file defines the common audio settings for the child boards using rt5682 codec.
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +/ {
> + /* BOARD-SPECIFIC TOP LEVEL NODES */
> + sound: sound {
> + compatible = "google,sc7280-herobrine";
> + model = "sc7280-rt5682-max98360a-1mic";
> +
> + status = "okay";
> + audio-routing =
> + "Headphone Jack", "HPOL",
> + "Headphone Jack", "HPOR";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dai-link@0 {
> + link-name = "MAX98360";
> + reg = <0>;
> +
> + cpu {
> + sound-dai = <&lpass_cpu MI2S_SECONDARY>;
> + };
> +
> + codec {
> + sound-dai = <&max98360a>;
> + };
> + };
> +
> + dai-link@1 {
> + link-name = "ALC5682";
> + reg = <1>;
> +
> + cpu {
> + sound-dai = <&lpass_cpu MI2S_PRIMARY>;
> + };
> +
> + codec {
> + sound-dai = <&alc5682 0 /* aif1 */>;
> + };
> + };
> + };
> +};
> +
> +hp_i2c: &i2c2 {
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + alc5682: codec@1a {
> + compatible = "realtek,rt5682s";
> + reg = <0x1a>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&hp_irq>;
> +
> + #sound-dai-cells = <1>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <101 IRQ_TYPE_EDGE_BOTH>;
> +
> + AVDD-supply = <&pp1800_alc5682>;
> + MICVDD-supply = <&pp3300_codec>;
> +
> + realtek,dmic1-data-pin = <1>;
> + realtek,dmic1-clk-pin = <2>;
> + realtek,jd-src = <1>;
> + realtek,dmic-clk-rate-hz = <2048000>;
> + };
> +};
> +
> +&lpass_cpu {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&mi2s0_data0 &mi2s0_data1 &mi2s0_mclk &mi2s0_sclk &mi2s0_ws
> + &mi2s1_data0 &mi2s1_sclk &mi2s1_ws>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dai-link@0 {
> + reg = <MI2S_PRIMARY>;
> + qcom,playback-sd-lines = <1>;
> + qcom,capture-sd-lines = <0>;
> + };
> +
> + dai-link@1 {
> + reg = <MI2S_SECONDARY>;
> + qcom,playback-sd-lines = <0>;
> + };
> +};
> +
> +&mi2s0_data0 {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s0_data1 {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s0_mclk {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s0_sclk {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s0_ws {
> + drive-strength = <6>;
Just like for patch #1, I think you want "bias-disable" here, too.
-Doug
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi
@ 2022-05-20 20:49 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 20:49 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
Matthias Kaehlcke, Jimmy Cheng-Yi Chiang, Judy Hsiao,
Tzung-Bi Shih, Stephen Boyd, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 9:10 AM Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> Audio dtsi for sc7280 boards that using rt5682 headset codec:
> 1. Add dt nodes for sound card which use I2S playback and record
> through rt5682s and I2S playback through max98357a.
> 2. Enable lpass cpu node and add pin control and dai-links.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 120 ++++++++++++++++++
> 1 file changed, 120 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> new file mode 100644
> index 000000000000..d83e99f1d417
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi
> @@ -0,0 +1,120 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + *
> + * This file defines the common audio settings for the child boards using rt5682 codec.
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +/ {
> + /* BOARD-SPECIFIC TOP LEVEL NODES */
> + sound: sound {
> + compatible = "google,sc7280-herobrine";
> + model = "sc7280-rt5682-max98360a-1mic";
> +
> + status = "okay";
> + audio-routing =
> + "Headphone Jack", "HPOL",
> + "Headphone Jack", "HPOR";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dai-link@0 {
> + link-name = "MAX98360";
> + reg = <0>;
> +
> + cpu {
> + sound-dai = <&lpass_cpu MI2S_SECONDARY>;
> + };
> +
> + codec {
> + sound-dai = <&max98360a>;
> + };
> + };
> +
> + dai-link@1 {
> + link-name = "ALC5682";
> + reg = <1>;
> +
> + cpu {
> + sound-dai = <&lpass_cpu MI2S_PRIMARY>;
> + };
> +
> + codec {
> + sound-dai = <&alc5682 0 /* aif1 */>;
> + };
> + };
> + };
> +};
> +
> +hp_i2c: &i2c2 {
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + alc5682: codec@1a {
> + compatible = "realtek,rt5682s";
> + reg = <0x1a>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&hp_irq>;
> +
> + #sound-dai-cells = <1>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <101 IRQ_TYPE_EDGE_BOTH>;
> +
> + AVDD-supply = <&pp1800_alc5682>;
> + MICVDD-supply = <&pp3300_codec>;
> +
> + realtek,dmic1-data-pin = <1>;
> + realtek,dmic1-clk-pin = <2>;
> + realtek,jd-src = <1>;
> + realtek,dmic-clk-rate-hz = <2048000>;
> + };
> +};
> +
> +&lpass_cpu {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&mi2s0_data0 &mi2s0_data1 &mi2s0_mclk &mi2s0_sclk &mi2s0_ws
> + &mi2s1_data0 &mi2s1_sclk &mi2s1_ws>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dai-link@0 {
> + reg = <MI2S_PRIMARY>;
> + qcom,playback-sd-lines = <1>;
> + qcom,capture-sd-lines = <0>;
> + };
> +
> + dai-link@1 {
> + reg = <MI2S_SECONDARY>;
> + qcom,playback-sd-lines = <0>;
> + };
> +};
> +
> +&mi2s0_data0 {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s0_data1 {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s0_mclk {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s0_sclk {
> + drive-strength = <6>;
> + bias-disable;
> +};
> +
> +&mi2s0_ws {
> + drive-strength = <6>;
Just like for patch #1, I think you want "bias-disable" here, too.
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1
2022-05-20 16:10 ` Judy Hsiao
@ 2022-05-20 20:50 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 20:50 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
Matthias Kaehlcke, Jimmy Cheng-Yi Chiang, Judy Hsiao,
Tzung-Bi Shih, Stephen Boyd, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 9:10 AM Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> Include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 as
> these boards use rt5682 codec.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts | 1 +
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 1 +
> 2 files changed, 2 insertions(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1
@ 2022-05-20 20:50 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 20:50 UTC (permalink / raw)
To: Judy Hsiao
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Srini Kandagatla,
Matthias Kaehlcke, Jimmy Cheng-Yi Chiang, Judy Hsiao,
Tzung-Bi Shih, Stephen Boyd, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 9:10 AM Judy Hsiao <judyhsiao@chromium.org> wrote:
>
> Include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 as
> these boards use rt5682 codec.
>
> Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts | 1 +
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 1 +
> 2 files changed, 2 insertions(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
2022-05-20 20:39 ` Doug Anderson
@ 2022-05-20 21:01 ` Stephen Boyd
-1 siblings, 0 replies; 30+ messages in thread
From: Stephen Boyd @ 2022-05-20 21:01 UTC (permalink / raw)
To: Doug Anderson
Cc: Andy Gross, Judy Hsiao, Bjorn Andersson, Rob Herring,
Srini Kandagatla, Matthias Kaehlcke, Jimmy Cheng-Yi Chiang,
Judy Hsiao, Tzung-Bi Shih, Linux ARM, linux-arm-msm, devicetree,
LKML
Quoting Doug Anderson (2022-05-20 13:39:21)
> On Fri, May 20, 2022 at 1:38 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > Quoting Judy Hsiao (2022-05-20 09:10:02)
> > > +};
> > > +
> > > +&mi2s1_sclk {
> > > + drive-strength = <6>;
> > > + bias-disable;
> >
> > Is there an external pull on this line? If so please add that details as
> > a comment like we do for other external pulls.
>
> Actually, I think they are output lines, which is why they have a
> drive-strength. I think for output lines we don't usually comment
> about why we're disabling the pulls, only for input lines?
Ok makes sense. Even for an open drain signal it would be an "input" so
that rule still applies?
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
@ 2022-05-20 21:01 ` Stephen Boyd
0 siblings, 0 replies; 30+ messages in thread
From: Stephen Boyd @ 2022-05-20 21:01 UTC (permalink / raw)
To: Doug Anderson
Cc: Andy Gross, Judy Hsiao, Bjorn Andersson, Rob Herring,
Srini Kandagatla, Matthias Kaehlcke, Jimmy Cheng-Yi Chiang,
Judy Hsiao, Tzung-Bi Shih, Linux ARM, linux-arm-msm, devicetree,
LKML
Quoting Doug Anderson (2022-05-20 13:39:21)
> On Fri, May 20, 2022 at 1:38 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > Quoting Judy Hsiao (2022-05-20 09:10:02)
> > > +};
> > > +
> > > +&mi2s1_sclk {
> > > + drive-strength = <6>;
> > > + bias-disable;
> >
> > Is there an external pull on this line? If so please add that details as
> > a comment like we do for other external pulls.
>
> Actually, I think they are output lines, which is why they have a
> drive-strength. I think for output lines we don't usually comment
> about why we're disabling the pulls, only for input lines?
Ok makes sense. Even for an open drain signal it would be an "input" so
that rule still applies?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
2022-05-20 21:01 ` Stephen Boyd
@ 2022-05-20 21:05 ` Doug Anderson
-1 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 21:05 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Judy Hsiao, Bjorn Andersson, Rob Herring,
Srini Kandagatla, Matthias Kaehlcke, Jimmy Cheng-Yi Chiang,
Judy Hsiao, Tzung-Bi Shih, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 2:01 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Doug Anderson (2022-05-20 13:39:21)
> > On Fri, May 20, 2022 at 1:38 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > Quoting Judy Hsiao (2022-05-20 09:10:02)
> > > > +};
> > > > +
> > > > +&mi2s1_sclk {
> > > > + drive-strength = <6>;
> > > > + bias-disable;
> > >
> > > Is there an external pull on this line? If so please add that details as
> > > a comment like we do for other external pulls.
> >
> > Actually, I think they are output lines, which is why they have a
> > drive-strength. I think for output lines we don't usually comment
> > about why we're disabling the pulls, only for input lines?
>
> Ok makes sense. Even for an open drain signal it would be an "input" so
> that rule still applies?
I think open drain is mostly used for bidirectional signals, like i2c
lines. In that case then you're right, you can have a drive-strength
and a pull. ...I thought i2s was not bidirectoinal and not open-drain,
but I certainly could be wrong.
-Doug
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
@ 2022-05-20 21:05 ` Doug Anderson
0 siblings, 0 replies; 30+ messages in thread
From: Doug Anderson @ 2022-05-20 21:05 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Judy Hsiao, Bjorn Andersson, Rob Herring,
Srini Kandagatla, Matthias Kaehlcke, Jimmy Cheng-Yi Chiang,
Judy Hsiao, Tzung-Bi Shih, Linux ARM, linux-arm-msm,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Hi,
On Fri, May 20, 2022 at 2:01 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Doug Anderson (2022-05-20 13:39:21)
> > On Fri, May 20, 2022 at 1:38 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > Quoting Judy Hsiao (2022-05-20 09:10:02)
> > > > +};
> > > > +
> > > > +&mi2s1_sclk {
> > > > + drive-strength = <6>;
> > > > + bias-disable;
> > >
> > > Is there an external pull on this line? If so please add that details as
> > > a comment like we do for other external pulls.
> >
> > Actually, I think they are output lines, which is why they have a
> > drive-strength. I think for output lines we don't usually comment
> > about why we're disabling the pulls, only for input lines?
>
> Ok makes sense. Even for an open drain signal it would be an "input" so
> that rule still applies?
I think open drain is mostly used for bidirectional signals, like i2c
lines. In that case then you're right, you can have a drive-strength
and a pull. ...I thought i2s was not bidirectoinal and not open-drain,
but I certainly could be wrong.
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 30+ messages in thread
* [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
2022-05-20 16:07 [v2 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec Judy Hsiao
@ 2022-05-20 16:07 ` Judy Hsiao
0 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:07 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
1. Add drive strength property for mi2s1 on sc7280 based platforms.
2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
Change-Id: Ie227da1076a4343b88b331a937169745fe91902c
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 9cb1bc8ed6b5..6d8744e130b0 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -612,6 +612,20 @@ &dp_hot_plug_det {
bias-disable;
};
+&mi2s1_data0 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_sclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_ws {
+ drive-strength = <6>;
+};
+
&pcie1_clkreq_n {
bias-pull-up;
drive-strength = <2>;
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1
@ 2022-05-20 16:07 ` Judy Hsiao
0 siblings, 0 replies; 30+ messages in thread
From: Judy Hsiao @ 2022-05-20 16:07 UTC (permalink / raw)
To: Andy Gross
Cc: Bjorn Andersson, Rob Herring, Srini Kandagatla, dianders, mka,
cychiang, judyhsiao, tzungbi, swboyd, linux-arm-kernel,
linux-arm-msm, devicetree, linux-kernel, Judy Hsiao
1. Add drive strength property for mi2s1 on sc7280 based platforms.
2. Disbale the pull-up mi2s1_data0, mi2s1_sclk.
Change-Id: Ie227da1076a4343b88b331a937169745fe91902c
Signed-off-by: Judy Hsiao <judyhsiao@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 9cb1bc8ed6b5..6d8744e130b0 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -612,6 +612,20 @@ &dp_hot_plug_det {
bias-disable;
};
+&mi2s1_data0 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_sclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_ws {
+ drive-strength = <6>;
+};
+
&pcie1_clkreq_n {
bias-pull-up;
drive-strength = <2>;
--
2.36.1.124.g0e6072fb45-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 30+ messages in thread
end of thread, other threads:[~2022-05-20 21:07 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-20 16:10 [v2 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec Judy Hsiao
2022-05-20 16:10 ` Judy Hsiao
2022-05-20 16:10 ` [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 Judy Hsiao
2022-05-20 16:10 ` Judy Hsiao
2022-05-20 17:27 ` Matthias Kaehlcke
2022-05-20 17:27 ` Matthias Kaehlcke
2022-05-20 20:38 ` Stephen Boyd
2022-05-20 20:38 ` Stephen Boyd
2022-05-20 20:39 ` Doug Anderson
2022-05-20 20:39 ` Doug Anderson
2022-05-20 21:01 ` Stephen Boyd
2022-05-20 21:01 ` Stephen Boyd
2022-05-20 21:05 ` Doug Anderson
2022-05-20 21:05 ` Doug Anderson
2022-05-20 20:43 ` Doug Anderson
2022-05-20 20:43 ` Doug Anderson
2022-05-20 16:10 ` [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi Judy Hsiao
2022-05-20 16:10 ` Judy Hsiao
2022-05-20 17:36 ` Matthias Kaehlcke
2022-05-20 17:36 ` Matthias Kaehlcke
2022-05-20 20:49 ` Doug Anderson
2022-05-20 20:49 ` Doug Anderson
2022-05-20 16:10 ` [v2 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 Judy Hsiao
2022-05-20 16:10 ` Judy Hsiao
2022-05-20 17:59 ` Matthias Kaehlcke
2022-05-20 17:59 ` Matthias Kaehlcke
2022-05-20 20:50 ` Doug Anderson
2022-05-20 20:50 ` Doug Anderson
-- strict thread matches above, loose matches on Subject: below --
2022-05-20 16:07 [v2 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec Judy Hsiao
2022-05-20 16:07 ` [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 Judy Hsiao
2022-05-20 16:07 ` Judy Hsiao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.