All of lore.kernel.org
 help / color / mirror / Atom feed
From: Plato Kiorpelidis <kioplato@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, phillip.wood123@gmail.com, avarab@gmail.com
Subject: Re: [PATCH v2 00/15][GSoC] iterate dirs before or after their contents
Date: Fri, 20 May 2022 20:43:10 +0300	[thread overview]
Message-ID: <20220520174310.2worceevbqkqn6oo@compass> (raw)
In-Reply-To: <xmqqilqd8i33.fsf@gitster.g>

On 22/05/10 09:31AM, Junio C Hamano wrote:
> Plato Kiorpelidis <kioplato@gmail.com> writes:
> 
> > This is the second version of a patch series which implements pre-order and
> > post-order iteration over directories. In this version I use the new iteration
> > scheme to convert entry.c remove_subtree() function from using opendir/readdir/
> > closedir API to dir-iterator API.
> 
> This cover letter seems to be written specifically for those who
> have read v1.  It is not very advisable way to write your cover
> letter, unless you are aiming to shrink your reviewer base in each
> iteration.
> 
> Do not assume that everybody who didn't give reviews to the previous
> round is not interested in the topic.
> 
> Instead, at least repeat the justification and the motivation enough
> in each iteration to make it easier for those who were not involved
> in earlier rounds to join the discussion.
> 
> "implements pre-order and post-order" is "what" and not "why".  Even
> in this version, "convert remove_subtree()" is only a "what" and not
> "why".  The reviewers need to learn why helping these patches is a
> worthwhile thing to do before they decide to devote their time, so
> helping them would in return help your cause.
> 
> You highlighted the difference since the previous round very well
> (omitted here).  It would be very appreciated by those who were in
> the first round.  Keep up the good work ;-)
> 
> > I also didn't CC Michael and Matheus in this version, since they weren't
> > interested in v1 where I did CC them.
> 
> This is OK as long as the message goes to the list, but again, "no
> responses" should not be taken as more than "no information".
> Seeing no review comments from somebody on CC: is not a vote of "no"
> by the recipient (nor it is not a vote of "yes").
> 
> Thanks for working on the topic.

That's great advice, thank you. Indeed, I did assume the above. I'll
follow this up with a patch on how to write better cover letters in
the related section and file of Documentation/. I've seen these patch
series[1] and I've read through them in detail. I'll figure out how
to incorporate such information in them.

[1]: https://lore.kernel.org/git/pull.1226.v3.git.1652399017.gitgitgadget@gmail.com/

Thanks,
Plato

      reply	other threads:[~2022-05-20 17:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 17:51 [PATCH v2 00/15][GSoC] iterate dirs before or after their contents Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 01/15] t0066: refactor dir-iterator tests Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 02/15] t0066: remove dependency between unrelated tests Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 03/15] t0066: shorter expected and actual output file names Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 04/15] test-dir-iterator: consistently return EXIT_FAILURE or EXIT_SUCCESS Plato Kiorpelidis
2022-05-09 21:03   ` Junio C Hamano
2022-05-18 14:13     ` Plato Kiorpelidis
2022-05-18 17:57       ` Junio C Hamano
2022-05-09 17:51 ` [PATCH v2 05/15] test-dir-iterator: print EACCES and ELOOP errno set by dir_iterator Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 06/15] test-dir-iterator: print errno name set by dir_iterator_advance Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 07/15] t0066: better test coverage for dir-iterator Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 08/15] t0066: reorder tests from simple to more complex Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 09/15] t0066: rename test directories Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 10/15] dir-iterator: refactor dir_iterator_advance() Plato Kiorpelidis
2022-05-09 21:16   ` Junio C Hamano
2022-05-18 15:39     ` Plato Kiorpelidis
2022-05-10 13:04   ` Phillip Wood
2022-05-09 17:51 ` [PATCH v2 11/15] dir-iterator: open root dir in dir_iterator_begin() Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 12/15] t0066: rename subtest descriptions Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 13/15] dir-iterator: option to iterate dirs in pre-order Plato Kiorpelidis
2022-05-10 13:07   ` Phillip Wood
2022-05-18 17:40     ` Plato Kiorpelidis
2022-05-18 17:47       ` rsbecker
2022-05-18 18:09         ` Junio C Hamano
2022-05-18 18:36           ` rsbecker
2022-05-09 17:51 ` [PATCH v2 14/15] dir-iterator: option to iterate dirs in post-order Plato Kiorpelidis
2022-05-09 17:51 ` [PATCH v2 15/15] entry.c: use dir-iterator to avoid explicit dir traversal Plato Kiorpelidis
2022-05-10 13:10   ` Phillip Wood
2022-05-10 13:13 ` [PATCH v2 00/15][GSoC] iterate dirs before or after their contents Phillip Wood
2022-05-10 16:31 ` Junio C Hamano
2022-05-20 17:43   ` Plato Kiorpelidis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520174310.2worceevbqkqn6oo@compass \
    --to=kioplato@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.