From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA579C433F5 for ; Sat, 21 May 2022 01:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354287AbiEUBBV (ORCPT ); Fri, 20 May 2022 21:01:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354240AbiEUBBS (ORCPT ); Fri, 20 May 2022 21:01:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27F16532EA for ; Fri, 20 May 2022 18:01:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D411FB82E70 for ; Sat, 21 May 2022 01:01:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40173C34113; Sat, 21 May 2022 01:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653094872; bh=Ryxe2ZZrchcHMLxEHjbPWYfiG2EoSxWIr+UlZcCmo8c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A0EwjmYuSPJ0TN8mnoGH9SbzuI7zzIGqBE2B5tlkbET3b/JaInnHmKmu4DNvN3gRX yjJMaoejHE+Zq2q1H4b4JAH6OxMoA7WWXaUHUeao9NR01k8akhi1EfZLWCH/vGdN+R vFvrT63X6tmIkvUSpWFHxpTON95jtt+1qgEXH+F2L7wKQwqIFrfw4IgOFBMphHdAVz ndjDdxwYHvgKskOz418aFJDoiZjlXtDPODjjJ2ajpR2WZFGX8Ur3sTxGMYPT6UhY91 V55qJBay54fGFFawhyW2SAinLaYjrt/IYjDseQiFW7wcOPMMiZjXRX8ReqglqsUmHD dk3Rp1TT7Kw4w== Date: Fri, 20 May 2022 18:01:11 -0700 From: Jakub Kicinski To: Loic Poulain Cc: Ziyang Xuan , chandrashekar.devegowda@intel.com, linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next v3] net: wwan: t7xx: fix GFP_KERNEL usage in spin_lock context Message-ID: <20220520180111.7e9b2b84@kernel.org> In-Reply-To: <20220520172556.1d62b899@kernel.org> References: <20220519074351.829774-1-william.xuanziyang@huawei.com> <20220520172556.1d62b899@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 20 May 2022 17:25:56 -0700 Jakub Kicinski wrote: > On Thu, 19 May 2022 09:29:12 +0200 Loic Poulain wrote: > > On Thu, 19 May 2022 at 09:26, Ziyang Xuan wrote: > > > > > > t7xx_cldma_clear_rxq() call t7xx_cldma_alloc_and_map_skb() in spin_lock > > > context, But __dev_alloc_skb() in t7xx_cldma_alloc_and_map_skb() uses > > > GFP_KERNEL, that will introduce scheduling factor in spin_lock context. > > > > > > Because t7xx_cldma_clear_rxq() is called after stopping CLDMA, so we can > > > remove the spin_lock from t7xx_cldma_clear_rxq(). > > > > > > Fixes: 39d439047f1d ("net: wwan: t7xx: Add control DMA interface") > > > Suggested-by: Ricardo Martinez > > > Signed-off-by: Ziyang Xuan > > > > Reviewed-by: Loic Poulain > > Wait, you reviewed two different fixes for the same issue? > Please say something when that happens I thought both are needed :/ FWIW I pushed out the other one before I realized (they both apply without conflicts so I thought they fixed different issues) If this one is preferred please respin and squash a revert of 9ee152ee3ee3 into it.