* [PATCH 0/4] rtw88: Fix some Sparse warnings
@ 2022-05-20 18:45 Larry Finger
2022-05-20 18:45 ` [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Larry Finger
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Larry Finger @ 2022-05-20 18:45 UTC (permalink / raw)
To: Kalle Valo; +Cc: Johannes Berg, linux-wireless, Larry Finger, Ping-Ke Shih
Sparse shows warnings for symbols that can be static.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry Finger (4):
rtw88: Fix Sparse warning for rtw8822b
rtw88: Fix Sparse warning for rtw8822c
rtw88: Fix Sparse warning for rtw8723d
rtw88: Fix Sparse warning for rtw8821c
drivers/net/wireless/realtek/rtw88/rtw8723d.c | 2 +-
drivers/net/wireless/realtek/rtw88/rtw8821c.c | 2 +-
drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
--
2.36.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b
2022-05-20 18:45 [PATCH 0/4] rtw88: Fix some Sparse warnings Larry Finger
@ 2022-05-20 18:45 ` Larry Finger
2022-05-21 5:52 ` Kalle Valo
2022-05-23 0:45 ` Ping-Ke Shih
2022-05-20 18:45 ` [PATCH 2/4] rtw88: Fix Sparse warning for rtw8822c Larry Finger
2022-05-20 18:45 ` [PATCH 3/4] rtw88: Fix Sparse warning for rtw8723d Larry Finger
2 siblings, 2 replies; 6+ messages in thread
From: Larry Finger @ 2022-05-20 18:45 UTC (permalink / raw)
To: Kalle Valo; +Cc: Johannes Berg, linux-wireless, Larry Finger, Ping-Ke Shih
Sparse lists the following for rtw88:
CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c
drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
index dccd722b8e62..60c4e75df035 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
@@ -2497,7 +2497,7 @@ static struct rtw_hw_reg_offset rtw8822b_edcca_th[] = {
[EDCCA_TH_H2L_IDX] = {{.addr = 0x8a4, .mask = MASKBYTE1}, .offset = 0},
};
-struct rtw_chip_info rtw8822b_hw_spec = {
+static struct rtw_chip_info rtw8822b_hw_spec = {
.ops = &rtw8822b_ops,
.id = RTW_CHIP_TYPE_8822B,
.fw_name = "rtw88/rtw8822b_fw.bin",
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] rtw88: Fix Sparse warning for rtw8822c
2022-05-20 18:45 [PATCH 0/4] rtw88: Fix some Sparse warnings Larry Finger
2022-05-20 18:45 ` [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Larry Finger
@ 2022-05-20 18:45 ` Larry Finger
2022-05-20 18:45 ` [PATCH 3/4] rtw88: Fix Sparse warning for rtw8723d Larry Finger
2 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2022-05-20 18:45 UTC (permalink / raw)
To: Kalle Valo; +Cc: Johannes Berg, linux-wireless, Larry Finger, Ping-Ke Shih
Sparse reports the following:
CHECK drivers/net/wireless/realtek/rtw88/rtw8822c.c
drivers/net/wireless/realtek/rtw88/rtw8822c.c:5313:22: warning: symbol 'rtw8822c_hw_spec' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index c043b5c520b9..5ae72d7f5c50 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -5310,7 +5310,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8822c[] = {
{0xc50, MASKBYTE0, RTW_REG_DOMAIN_MAC8},
};
-struct rtw_chip_info rtw8822c_hw_spec = {
+static struct rtw_chip_info rtw8822c_hw_spec = {
.ops = &rtw8822c_ops,
.id = RTW_CHIP_TYPE_8822C,
.fw_name = "rtw88/rtw8822c_fw.bin",
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] rtw88: Fix Sparse warning for rtw8723d
2022-05-20 18:45 [PATCH 0/4] rtw88: Fix some Sparse warnings Larry Finger
2022-05-20 18:45 ` [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Larry Finger
2022-05-20 18:45 ` [PATCH 2/4] rtw88: Fix Sparse warning for rtw8822c Larry Finger
@ 2022-05-20 18:45 ` Larry Finger
2 siblings, 0 replies; 6+ messages in thread
From: Larry Finger @ 2022-05-20 18:45 UTC (permalink / raw)
To: Kalle Valo; +Cc: Johannes Berg, linux-wireless, Larry Finger, Ping-Ke Shih
Sparse list the following:
CHECK drivers/net/wireless/realtek/rtw88/rtw8723d.c
drivers/net/wireless/realtek/rtw88/rtw8723d.c:2704:22: warning: symbol 'rtw8723d_hw_spec' was not declared. Should it be static?
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/realtek/rtw88/rtw8723d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.c b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
index 93cce44df531..05e826e6ed0d 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8723d.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.c
@@ -2701,7 +2701,7 @@ static const struct rtw_reg_domain coex_info_hw_regs_8723d[] = {
{0x953, BIT(1), RTW_REG_DOMAIN_MAC8},
};
-struct rtw_chip_info rtw8723d_hw_spec = {
+static struct rtw_chip_info rtw8723d_hw_spec = {
.ops = &rtw8723d_ops,
.id = RTW_CHIP_TYPE_8723D,
.fw_name = "rtw88/rtw8723d_fw.bin",
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b
2022-05-20 18:45 ` [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Larry Finger
@ 2022-05-21 5:52 ` Kalle Valo
2022-05-23 0:45 ` Ping-Ke Shih
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-05-21 5:52 UTC (permalink / raw)
To: Larry Finger; +Cc: Johannes Berg, linux-wireless, Ping-Ke Shih
Larry Finger <Larry.Finger@lwfinger.net> writes:
> Sparse lists the following for rtw88:
>
> CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c
> drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not declared. Should it be static?
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
It's good to try to make title's unique, so maybe something like this:
rtw88: make rtw8822b_hw_spec static
> ---
> drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> index dccd722b8e62..60c4e75df035 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> @@ -2497,7 +2497,7 @@ static struct rtw_hw_reg_offset rtw8822b_edcca_th[] = {
> [EDCCA_TH_H2L_IDX] = {{.addr = 0x8a4, .mask = MASKBYTE1}, .offset = 0},
> };
>
> -struct rtw_chip_info rtw8822b_hw_spec = {
> +static struct rtw_chip_info rtw8822b_hw_spec = {
This should be static const to make sure it's not modified.
Similar comments for other patches in this patchset.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b
2022-05-20 18:45 ` [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Larry Finger
2022-05-21 5:52 ` Kalle Valo
@ 2022-05-23 0:45 ` Ping-Ke Shih
1 sibling, 0 replies; 6+ messages in thread
From: Ping-Ke Shih @ 2022-05-23 0:45 UTC (permalink / raw)
To: Larry Finger, Kalle Valo; +Cc: Johannes Berg, linux-wireless
> -----Original Message-----
> From: Larry Finger <Larry.Finger@lwfinger.net>
> Sent: Saturday, May 21, 2022 2:45 AM
> To: Kalle Valo <kvalo@kernel.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>; linux-wireless@vger.kernel.org; Larry Finger
> <Larry.Finger@lwfinger.net>; Pkshih <pkshih@realtek.com>
> Subject: [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b
>
> Sparse lists the following for rtw88:
>
> CHECK drivers/net/wireless/realtek/rtw88/rtw8822b.c
> drivers/net/wireless/realtek/rtw88/rtw8822b.c:2500:22: warning: symbol 'rtw8822b_hw_spec' was not
> declared. Should it be static?
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> index dccd722b8e62..60c4e75df035 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> @@ -2497,7 +2497,7 @@ static struct rtw_hw_reg_offset rtw8822b_edcca_th[] = {
> [EDCCA_TH_H2L_IDX] = {{.addr = 0x8a4, .mask = MASKBYTE1}, .offset = 0},
> };
>
> -struct rtw_chip_info rtw8822b_hw_spec = {
> +static struct rtw_chip_info rtw8822b_hw_spec = {
As Kalle's recommendation, this should be 'const'
> .ops = &rtw8822b_ops,
> .id = RTW_CHIP_TYPE_8822B,
> .fw_name = "rtw88/rtw8822b_fw.bin",
I do grep with 'rtw8822b_hw_spec':
rtw8822b.c:struct rtw_chip_info rtw8822b_hw_spec = {
rtw8822b.c:EXPORT_SYMBOL(rtw8822b_hw_spec);
rtw8822be.c: .driver_data = (kernel_ulong_t)&rtw8822b_hw_spec
rtw8822be.h:extern struct rtw_chip_info rtw8822b_hw_spec;
Making rtw8822b_hw_spec static can avoid sparse warning, but I worry that it can't
be loaded, because it is an "external" symbol and used by rtw8822be.ko.
Spuriously, it works.
However, I think we should correct them by moving extern prototype to rtw8822b.h and
include rtw8822b.h by rtw8822be.c.
Ping-Ke
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-23 0:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-20 18:45 [PATCH 0/4] rtw88: Fix some Sparse warnings Larry Finger
2022-05-20 18:45 ` [PATCH 1/4] rtw88: Fix Sparse warning for rtw8822b Larry Finger
2022-05-21 5:52 ` Kalle Valo
2022-05-23 0:45 ` Ping-Ke Shih
2022-05-20 18:45 ` [PATCH 2/4] rtw88: Fix Sparse warning for rtw8822c Larry Finger
2022-05-20 18:45 ` [PATCH 3/4] rtw88: Fix Sparse warning for rtw8723d Larry Finger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.