From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A71CC433EF for ; Sat, 21 May 2022 12:05:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5E70E83BBF; Sat, 21 May 2022 14:05:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qVlQcgrx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CA8D383DEB; Sat, 21 May 2022 14:05:28 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E19AB832C3 for ; Sat, 21 May 2022 14:05:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id 135so7125380qkm.4 for ; Sat, 21 May 2022 05:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=je6LNibGYkxN3KfwDwzSuHh25cDdI/v4TclrbTJ/O6k=; b=qVlQcgrx1EHM7miXY3iW/mX1WnuyCjf0YFnuid9E2tXI4tVo5jlHS4ynMHqO6+Omcn HVduVTWlEZy0ehWpvISHneal8+8Y8fkd45Q2NDCjcRlurDBJn+zxHWjPTK9ymG6mxsZp zlMYcW32sReYxMPcYS8xcvbHRvdpZ27c+oJM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=je6LNibGYkxN3KfwDwzSuHh25cDdI/v4TclrbTJ/O6k=; b=NgGGp8IGNPqSOT5b8cWpzfNCWG5uLMKdEKfIiZEP7iEWjOhB5p8n8+zo41lH2JM1sK lLPfU3AufVc4eR4YkDWCY/2APwONKw+NZt0Bhgd6qVUYiILHAXoSyPco9VuL+XW5Jk+b k95DPsLCcjrCMVSKwQdc055CRDFkiSWDuDVjROgEPV1GdPttBZFgJig/VPOVvjknF6N2 Nckb3NQrxw5gTFxPIhJ4RakppdDqmo6Qhj4LgcFTdhR4RsXmW8vTk2zmV6mbLoQ270Wb JPnbXHmdLef5jdtfsSBG4Rf0Uo1ueSMUmrK2mMoVXZ4UgjORWf3JRA59jYelAI/SRMAj 6FDQ== X-Gm-Message-State: AOAM533p49VWlHHQTsG2csme1ow5EaLaOeQu8nFKN3NL4KmMbmEIjz5c KzJBhq5USHFQ1kEE/kGbw5Qrcw== X-Google-Smtp-Source: ABdhPJyRpgT6n+0kmEKrKNZlgFN4aKzi7dpvFkzdXarRRRX1ssExFgqS3d5zgrRmQatt+6N9l7t16Q== X-Received: by 2002:a05:620a:2544:b0:680:a53b:ec1a with SMTP id s4-20020a05620a254400b00680a53bec1amr9007005qko.544.1653134721702; Sat, 21 May 2022 05:05:21 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-200-14.ec.res.rr.com. [65.184.200.14]) by smtp.gmail.com with ESMTPSA id cc7-20020a05622a410700b002f917b670a2sm1176353qtb.74.2022.05.21.05.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 05:05:20 -0700 (PDT) Date: Sat, 21 May 2022 08:05:18 -0400 From: Tom Rini To: Peng Fan Cc: "Peng Fan (OSS)" , "sbabic@denx.de" , "festevam@gmail.com" , "ariel.dalessandro@collabora.com" , "michael@amarulasolutions.com" , "tharvey@gateworks.com" , "sjg@chromium.org" , "alpernebiyasak@gmail.com" , "marek.behun@nic.cz" , "pali@kernel.org" , "sr@denx.de" , Ricardo Salveti , "patrick.delaunay@foss.st.com" , "u-boot@lists.denx.de" Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 Message-ID: <20220521120518.GI13239@bill-the-cat> References: <20220520141048.20034-1-peng.fan@oss.nxp.com> <20220520141048.20034-2-peng.fan@oss.nxp.com> <20220520152127.GC13239@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHbokkKX1kTiQeDC" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --xHbokkKX1kTiQeDC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 21, 2022 at 08:33:56AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > >=20 > > On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote: > >=20 > > > From: Peng Fan > > > > > > set the symbol as weak not work if LTO is enabled. Since u_boot_any is > > > only used on X86 for now, so guard it with X86, otherwise build break > > > if we use BINMAN_SYMBOLS on i.MX. > > > > > > Tested-by: Tim Harvey #imx8m[m,n,p]-venice > > > Signed-off-by: Peng Fan > > > --- > > > common/spl/spl.c | 8 ++++++-- > > > common/spl/spl_ram.c | 4 ++++ > > > 2 files changed, 10 insertions(+), 2 deletions(-) > >=20 > > I think we long term need to figure this out and address it so LTO work= s. But > > for now can you please guard this with a test on LTO instead, so it's c= lear > > where the problem is? >=20 > Sorry, I could not get your point about guard with a test on LTO. >=20 > Actually binman weak symbol will report a warning log if there is no u_bo= ot_any > binman symbol. Since only X86 use it, I guard with X86. Why are you mentioning LTO in the commit message? When I read the commit message it sounds like you're saying the problem is that LTO doesn't like how this symbol is handled, but if LTO was disabled, everything would be fine. If it's not LTO-related, please re-word the message instead. --=20 Tom --xHbokkKX1kTiQeDC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKI1XoACgkQFHw5/5Y0 tyyHhwwAljHagxCN3GtfFE2JU+zcW9/q4LpEbtnHap1EhUaX2b+wDaSJa+1i/UZb LJr/tk5OpE/Fv/omLr4IRxGBdBjkfRiGAX7psUllNltL4ISpnn2PeIJ7gBN0KQdY EV1ln97pwVCI8BE7NjSWEh9mqIFIpkZ+Cg+r/6cECShnv8h3Od6WpNA37fjzzdbr BUkNgOK6yYg40942juzHzW2Toi6MHe84h+G4xZ4aXf8gZ5Svt7IJlMSjwOx2rl/l 6aLNVeI79kBpEejEwfRhLzdCOiJrZ1dUXmXzcHJOavGB/5m8K3Be8vsYBF0sWJk/ 7XgY4K88YmgUz1xt8Jhr+4trv80EM0Og3HGL2+IuhpqynIagh0nVr8JPi+tkjKX/ BOnCETj/OeCLMOzfVbkBRDq56pslfiBqCvxMFT1WbvgnkoUMPw+GLGXvF4QFodOm tPyqU2dnWKdvD3YZoDmL5nS8dPzWqNNT16NDFlt9yaeEHTfbmGzlVocPrID5J8Lx hdttzPwZ =Dy5s -----END PGP SIGNATURE----- --xHbokkKX1kTiQeDC--