* [PATCH] drm/vkms: Update vkms_composer_worker documentation
@ 2022-05-21 19:13 ` André Almeida
0 siblings, 0 replies; 4+ messages in thread
From: André Almeida @ 2022-05-21 19:13 UTC (permalink / raw)
To: Rodrigo Siqueira, Melissa Wen, Haneen Mohammed, Daniel Vetter,
David Airlie
Cc: dri-devel, linux-kernel, kernel-dev, André Almeida
Since commit ba420afab565 ("drm/vkms: Bugfix racing hrtimer vblank
handle") the work is scheduled at vkms_vblank_simulate() and since
commit 5ef8100a3919 ("drm/vkms: flush crc workers earlier in commit
flow") the work is flushed at vkms_atomic_commit_tail(). Update function
commment to reflect that.
Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
index c6a1036bf2ea..914c0ac7dc8b 100644
--- a/drivers/gpu/drm/vkms/vkms_composer.c
+++ b/drivers/gpu/drm/vkms/vkms_composer.c
@@ -213,7 +213,7 @@ static int compose_active_planes(void **vaddr_out,
*
* Work handler for composing and computing CRCs. work_struct scheduled in
* an ordered workqueue that's periodically scheduled to run by
- * _vblank_handle() and flushed at vkms_atomic_crtc_destroy_state().
+ * vkms_vblank_simulate() and flushed at vkms_atomic_commit_tail().
*/
void vkms_composer_worker(struct work_struct *work)
{
--
2.36.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] drm/vkms: Update vkms_composer_worker documentation
@ 2022-05-21 19:13 ` André Almeida
0 siblings, 0 replies; 4+ messages in thread
From: André Almeida @ 2022-05-21 19:13 UTC (permalink / raw)
To: Rodrigo Siqueira, Melissa Wen, Haneen Mohammed, Daniel Vetter,
David Airlie
Cc: kernel-dev, André Almeida, linux-kernel, dri-devel
Since commit ba420afab565 ("drm/vkms: Bugfix racing hrtimer vblank
handle") the work is scheduled at vkms_vblank_simulate() and since
commit 5ef8100a3919 ("drm/vkms: flush crc workers earlier in commit
flow") the work is flushed at vkms_atomic_commit_tail(). Update function
commment to reflect that.
Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
index c6a1036bf2ea..914c0ac7dc8b 100644
--- a/drivers/gpu/drm/vkms/vkms_composer.c
+++ b/drivers/gpu/drm/vkms/vkms_composer.c
@@ -213,7 +213,7 @@ static int compose_active_planes(void **vaddr_out,
*
* Work handler for composing and computing CRCs. work_struct scheduled in
* an ordered workqueue that's periodically scheduled to run by
- * _vblank_handle() and flushed at vkms_atomic_crtc_destroy_state().
+ * vkms_vblank_simulate() and flushed at vkms_atomic_commit_tail().
*/
void vkms_composer_worker(struct work_struct *work)
{
--
2.36.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/vkms: Update vkms_composer_worker documentation
2022-05-21 19:13 ` André Almeida
@ 2022-05-25 15:41 ` Daniel Vetter
-1 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2022-05-25 15:41 UTC (permalink / raw)
To: André Almeida
Cc: Rodrigo Siqueira, Melissa Wen, Haneen Mohammed, Daniel Vetter,
David Airlie, dri-devel, linux-kernel, kernel-dev
On Sat, May 21, 2022 at 04:13:42PM -0300, André Almeida wrote:
> Since commit ba420afab565 ("drm/vkms: Bugfix racing hrtimer vblank
> handle") the work is scheduled at vkms_vblank_simulate() and since
> commit 5ef8100a3919 ("drm/vkms: flush crc workers earlier in commit
> flow") the work is flushed at vkms_atomic_commit_tail(). Update function
> commment to reflect that.
>
> Signed-off-by: André Almeida <andrealmeid@igalia.com>
Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
> index c6a1036bf2ea..914c0ac7dc8b 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -213,7 +213,7 @@ static int compose_active_planes(void **vaddr_out,
> *
> * Work handler for composing and computing CRCs. work_struct scheduled in
> * an ordered workqueue that's periodically scheduled to run by
> - * _vblank_handle() and flushed at vkms_atomic_crtc_destroy_state().
> + * vkms_vblank_simulate() and flushed at vkms_atomic_commit_tail().
> */
> void vkms_composer_worker(struct work_struct *work)
> {
> --
> 2.36.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/vkms: Update vkms_composer_worker documentation
@ 2022-05-25 15:41 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2022-05-25 15:41 UTC (permalink / raw)
To: André Almeida
Cc: Haneen Mohammed, kernel-dev, Rodrigo Siqueira, David Airlie,
linux-kernel, dri-devel, Melissa Wen
On Sat, May 21, 2022 at 04:13:42PM -0300, André Almeida wrote:
> Since commit ba420afab565 ("drm/vkms: Bugfix racing hrtimer vblank
> handle") the work is scheduled at vkms_vblank_simulate() and since
> commit 5ef8100a3919 ("drm/vkms: flush crc workers earlier in commit
> flow") the work is flushed at vkms_atomic_commit_tail(). Update function
> commment to reflect that.
>
> Signed-off-by: André Almeida <andrealmeid@igalia.com>
Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/vkms/vkms_composer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
> index c6a1036bf2ea..914c0ac7dc8b 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -213,7 +213,7 @@ static int compose_active_planes(void **vaddr_out,
> *
> * Work handler for composing and computing CRCs. work_struct scheduled in
> * an ordered workqueue that's periodically scheduled to run by
> - * _vblank_handle() and flushed at vkms_atomic_crtc_destroy_state().
> + * vkms_vblank_simulate() and flushed at vkms_atomic_commit_tail().
> */
> void vkms_composer_worker(struct work_struct *work)
> {
> --
> 2.36.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-25 15:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-21 19:13 [PATCH] drm/vkms: Update vkms_composer_worker documentation André Almeida
2022-05-21 19:13 ` André Almeida
2022-05-25 15:41 ` Daniel Vetter
2022-05-25 15:41 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.